aerialship / SamlSPBundle

src/AerialShip/SamlSPBundle/Bridge/Authenticate.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace AerialShip\SamlSPBundle\Bridge;
 
-use AerialShip\LightSaml\Binding\HttpRedirect;
 use AerialShip\LightSaml\Meta\AuthnRequestBuilder;
 use AerialShip\SamlSPBundle\Config\ServiceInfoCollection;
 use AerialShip\SamlSPBundle\RelyingParty\RelyingPartyInterface;

src/AerialShip/SamlSPBundle/Bridge/LogoutFallback.php

Doc Comments +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     /**
      * @param \Symfony\Component\HttpFoundation\Request $request
      * @throws \InvalidArgumentException if cannot manage the Request
-     * @return \Symfony\Component\HttpFoundation\Response|SamlSpInfo|null
+     * @return \Symfony\Component\HttpFoundation\RedirectResponse
      */
     public function manage(Request $request)
     {

src/AerialShip/SamlSPBundle/Config/SpEntityDescriptorBuilder.php

Doc Comments +5 added lines

@@ -42,6 +42,11 @@
 
 
 
+    /**
+     * @param string $authenticationServiceID
+     * @param string $checkPath
+     * @param string $logoutPath
+     */
     public function __construct(
         $authenticationServiceID,
         SPSigningProviderInterface $signingProvider,

src/AerialShip/SamlSPBundle/DependencyInjection/AerialShipSamlSPExtension.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace AerialShip\SamlSPBundle\DependencyInjection;
 
-use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;

src/AerialShip/SamlSPBundle/Security/Core/Authentication/Provider/SamlSpAuthenticationProvider.php

Doc Comments +6 added lines, -3 removed lines

@@ -30,6 +30,9 @@ 
 
 
 
+    /**
+     * @param string $providerKey
+     */
     public function __construct(
         $providerKey,
         UserManagerInterface $userProvider = null,
@@ -52,7 +55,7 @@ 
     /**
      * Attempts to authenticate a TokenInterface object.
      * @param TokenInterface $token The TokenInterface instance to authenticate
-     * @return TokenInterface An authenticated TokenInterface instance, never null
+     * @return null|SamlSpToken An authenticated TokenInterface instance, never null
      * @throws AuthenticationException if the authentication fails
      */
     public function authenticate(TokenInterface $token)
@@ -82,7 +85,7 @@ 
 
     /**
      * @param SamlSpToken $token
-     * @return mixed|UserInterface
+     * @return UserInterface
      */
     protected function getUser(SamlSpToken $token)
     {
@@ -113,7 +116,7 @@ 
      * @param \AerialShip\SamlSPBundle\Bridge\SamlSpInfo $samlInfo
      * @param array $attributes
      * @param array $roles
-     * @param mixed $user
+     * @param UserInterface $user
      * @return SamlSpToken
      */
     protected function createAuthenticatedToken(SamlSpInfo $samlInfo, array $attributes, array $roles, $user)

src/AerialShip/SamlSPBundle/State/SSO/AbstractSSOStateStore.php

Doc Comments +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
     protected $entityClass;
 
     /**
-     * @param $entityClass
+     * @param string $entityClass
      */
     public function __construct($entityClass)
     {

src/AerialShip/SamlSPBundle/Tests/Config/ServiceInfoCollectionTest.php

Doc Comments +3 added lines, -3 removed lines

@@ -254,8 +254,8 @@ 
 
 
     /**
-     * @param $providerID
-     * @param $idpID
+     * @param string $providerID
+     * @param string $idpID
      * @param $spProvider
      * @param $idpProvider
      * @param $spMetaProvider
@@ -303,7 +303,7 @@ 
     }
 
     /**
-     * @param $entityID
+     * @param string $entityID
      * @return EntityDescriptor|\PHPUnit_Framework_MockObject_MockObject
      */
     protected function createEntityDescriptorStub($entityID)

src/AerialShip/SamlSPBundle/Tests/Config/SpEntityDescriptorBuilderTest.php

Doc Comments +3 added lines, -3 removed lines

@@ -300,7 +300,7 @@ 
 
 
     /**
-     * @param $enabled
+     * @param boolean $enabled
      * @param $certificate
      * @param $key
      * @return SPSigningProviderInterface|\PHPUnit_Framework_MockObject_MockObject
@@ -328,7 +328,7 @@ 
     }
 
     /**
-     * @param $generateUriReturn
+     * @param string $generateUriReturn
      * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\Security\Http\HttpUtils
      */
     protected function createHttpUtilsStub($generateUriReturn)
@@ -350,7 +350,7 @@ 
 
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\HttpFoundation\Request
+     * @return \Symfony\Component\HttpFoundation\Request
      */
     private function createRequestMock()
     {

src/AerialShip/SamlSPBundle/Tests/RelyingParty/RelyingPartyCollectionTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -233,7 +233,7 @@
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\HttpFoundation\Request
+     * @return \Symfony\Component\HttpFoundation\Request
      */
     public function createRequestMock()
     {