Issues in pnotify.buttons.js (master) - Issues in master - aepnat/simpuskesmas - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4542)

js/notify/pnotify.buttons.js (17 issues)

Labels

Severity

// Buttons
// Uses AMD or browser globals for jQuery.
(function (factory) {
    if (typeof define === 'function' && define.amd) {
        // AMD. Register as a module.
        define('pnotify.buttons', ['jquery', 'pnotify'], factory);
    } else {
        // Browser globals
        factory(jQuery, PNotify);
    }
}(function($, PNotify){
	PNotify.prototype.options.buttons = {
		// Provide a button for the user to manually close the notice.
		closer: true,
		// Only show the closer button on hover.
		closer_hover: true,
		// Provide a button for the user to manually stick the notice.
		sticker: true,
		// Only show the sticker button on hover.
		sticker_hover: true,
		// The various displayed text, helps facilitating internationalization.
		labels: {
			close: "Close",
			stick: "Stick"
		}
	};
	PNotify.prototype.modules.buttons = {
		// This lets us update the options available in the closures.
		myOptions: null,

		closer: null,
		sticker: null,

		init: function(notice, options){
			var that = this;
			this.myOptions = options;
			notice.elem.on({
				"mouseenter": function(e){

					// Show the buttons.
					if (that.myOptions.sticker && !(notice.options.nonblock && notice.options.nonblock.nonblock)) that.sticker.trigger("pnotify_icon").css("visibility", "visible");
if (a > 0)
    b = 42;
					if (that.myOptions.closer && !(notice.options.nonblock && notice.options.nonblock.nonblock)) that.closer.css("visibility", "visible");
if (a > 0)
    b = 42;
				},
				"mouseleave": function(e){

					// Hide the buttons.
					if (that.myOptions.sticker_hover)
						that.sticker.css("visibility", "hidden");
if (a > 0)
    b = 42;
					if (that.myOptions.closer_hover)
						that.closer.css("visibility", "hidden");
if (a > 0)
    b = 42;
				}
			});

			// Provide a button to stick the notice.
			this.sticker = $("<div />", {
				"class": "ui-pnotify-sticker",
				"css": {"cursor": "pointer", "visibility": options.sticker_hover ? "hidden" : "visible"},
				"click": function(){
					notice.options.hide = !notice.options.hide;
					if (notice.options.hide)
						notice.queueRemove();
if (a > 0)
    b = 42;
					else
						notice.cancelRemove();
					$(this).trigger("pnotify_icon");
				}
			})
			.bind("pnotify_icon", function(){
				$(this).children().removeClass(notice.styles.pin_up+" "+notice.styles.pin_down).addClass(notice.options.hide ? notice.styles.pin_up : notice.styles.pin_down);
			})
			.append($("<span />", {"class": notice.styles.pin_up, "title": options.labels.stick}))
			.prependTo(notice.container);
			if (!options.sticker || (notice.options.nonblock && notice.options.nonblock.nonblock))
				this.sticker.css("display", "none");
if (a > 0)
    b = 42;

			// Provide a button to close the notice.
			this.closer = $("<div />", {
				"class": "ui-pnotify-closer",
				"css": {"cursor": "pointer", "visibility": options.closer_hover ? "hidden" : "visible"},
				"click": function(){
					notice.remove(false);
					that.sticker.css("visibility", "hidden");
					that.closer.css("visibility", "hidden");
				}
			})
			.append($("<span />", {"class": notice.styles.closer, "title": options.labels.close}))
			.prependTo(notice.container);
			if (!options.closer || (notice.options.nonblock && notice.options.nonblock.nonblock))
				this.closer.css("display", "none");
if (a > 0)
    b = 42;
		},
		update: function(notice, options){
			this.myOptions = options;
			// Update the sticker and closer buttons.
			if (!options.closer || (notice.options.nonblock && notice.options.nonblock.nonblock))
				this.closer.css("display", "none");
if (a > 0)
    b = 42;
			else if (options.closer)
				this.closer.css("display", "block");
if (a > 0)
    b = 42;
			if (!options.sticker || (notice.options.nonblock && notice.options.nonblock.nonblock))
				this.sticker.css("display", "none");
if (a > 0)
    b = 42;
			else if (options.sticker)
				this.sticker.css("display", "block");
if (a > 0)
    b = 42;
			// Update the sticker icon.
			this.sticker.trigger("pnotify_icon");
			// Update the hover status of the buttons.
			if (options.sticker_hover)
				this.sticker.css("visibility", "hidden");
if (a > 0)
    b = 42;
			else if (!(notice.options.nonblock && notice.options.nonblock.nonblock))
				this.sticker.css("visibility", "visible");
if (a > 0)
    b = 42;
			if (options.closer_hover)
				this.closer.css("visibility", "hidden");
if (a > 0)
    b = 42;
			else if (!(notice.options.nonblock && notice.options.nonblock.nonblock))
				this.closer.css("visibility", "visible");
if (a > 0)
    b = 42;
		}
	};
	$.extend(PNotify.styling.jqueryui, {
		closer: "ui-icon ui-icon-close",
		pin_up: "ui-icon ui-icon-pin-w",
		pin_down: "ui-icon ui-icon-pin-s"
	});
	$.extend(PNotify.styling.bootstrap2, {
		closer: "icon-remove",
		pin_up: "icon-pause",
		pin_down: "icon-play"
	});
	$.extend(PNotify.styling.bootstrap3, {
		closer: "glyphicon glyphicon-remove",
		pin_up: "glyphicon glyphicon-pause",
		pin_down: "glyphicon glyphicon-play"
	});
	$.extend(PNotify.styling.fontawesome, {
		closer: "fa fa-times",
		pin_up: "fa fa-pause",
		pin_down: "fa fa-play"
	});
}));


1			// Buttons
2			// Uses AMD or browser globals for jQuery.
3			(function (factory) {
4			if (typeof define === 'function' && define.amd) {
5			// AMD. Register as a module.
6			define('pnotify.buttons', ['jquery', 'pnotify'], factory);
7			} else {
8			// Browser globals
9			factory(jQuery, PNotify);
10			}
11			}(function($, PNotify){
12			PNotify.prototype.options.buttons = {
13			// Provide a button for the user to manually close the notice.
14			closer: true,
15			// Only show the closer button on hover.
16			closer_hover: true,
17			// Provide a button for the user to manually stick the notice.
18			sticker: true,
19			// Only show the sticker button on hover.
20			sticker_hover: true,
21			// The various displayed text, helps facilitating internationalization.
22			labels: {
23			close: "Close",
24			stick: "Stick"
25			}
26			};
27			PNotify.prototype.modules.buttons = {
28			// This lets us update the options available in the closures.
29			myOptions: null,
30
31			closer: null,
32			sticker: null,
33
34			init: function(notice, options){
35			var that = this;
36			this.myOptions = options;
37			notice.elem.on({
38			"mouseenter": function(e){
			0 ignored issues – show Unused Code introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `e` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
39			// Show the buttons.
40			if (that.myOptions.sticker && !(notice.options.nonblock && notice.options.nonblock.nonblock)) that.sticker.trigger("pnotify_icon").css("visibility", "visible");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
41			if (that.myOptions.closer && !(notice.options.nonblock && notice.options.nonblock.nonblock)) that.closer.css("visibility", "visible");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
42			},
43			"mouseleave": function(e){
			0 ignored issues – show Unused Code introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `e` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
44			// Hide the buttons.
45			if (that.myOptions.sticker_hover)
46			that.sticker.css("visibility", "hidden");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
47			if (that.myOptions.closer_hover)
48			that.closer.css("visibility", "hidden");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
49			}
50			});
51
52			// Provide a button to stick the notice.
53			this.sticker = $("<div />", {
54			"class": "ui-pnotify-sticker",
55			"css": {"cursor": "pointer", "visibility": options.sticker_hover ? "hidden" : "visible"},
56			"click": function(){
57			notice.options.hide = !notice.options.hide;
58			if (notice.options.hide)
59			notice.queueRemove();
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
60			else
61			notice.cancelRemove();
62			$(this).trigger("pnotify_icon");
63			}
64			})
65			.bind("pnotify_icon", function(){
66			$(this).children().removeClass(notice.styles.pin_up+" "+notice.styles.pin_down).addClass(notice.options.hide ? notice.styles.pin_up : notice.styles.pin_down);
67			})
68			.append($("<span />", {"class": notice.styles.pin_up, "title": options.labels.stick}))
69			.prependTo(notice.container);
70			if (!options.sticker \|\| (notice.options.nonblock && notice.options.nonblock.nonblock))
71			this.sticker.css("display", "none");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
72
73			// Provide a button to close the notice.
74			this.closer = $("<div />", {
75			"class": "ui-pnotify-closer",
76			"css": {"cursor": "pointer", "visibility": options.closer_hover ? "hidden" : "visible"},
77			"click": function(){
78			notice.remove(false);
79			that.sticker.css("visibility", "hidden");
80			that.closer.css("visibility", "hidden");
81			}
82			})
83			.append($("<span />", {"class": notice.styles.closer, "title": options.labels.close}))
84			.prependTo(notice.container);
85			if (!options.closer \|\| (notice.options.nonblock && notice.options.nonblock.nonblock))
86			this.closer.css("display", "none");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
87			},
88			update: function(notice, options){
89			this.myOptions = options;
90			// Update the sticker and closer buttons.
91			if (!options.closer \|\| (notice.options.nonblock && notice.options.nonblock.nonblock))
92			this.closer.css("display", "none");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
93			else if (options.closer)
94			this.closer.css("display", "block");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
95			if (!options.sticker \|\| (notice.options.nonblock && notice.options.nonblock.nonblock))
96			this.sticker.css("display", "none");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
97			else if (options.sticker)
98			this.sticker.css("display", "block");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
99			// Update the sticker icon.
100			this.sticker.trigger("pnotify_icon");
101			// Update the hover status of the buttons.
102			if (options.sticker_hover)
103			this.sticker.css("visibility", "hidden");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
104			else if (!(notice.options.nonblock && notice.options.nonblock.nonblock))
105			this.sticker.css("visibility", "visible");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
106			if (options.closer_hover)
107			this.closer.css("visibility", "hidden");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
108			else if (!(notice.options.nonblock && notice.options.nonblock.nonblock))
109			this.closer.css("visibility", "visible");
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-30 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
110			}
111			};
112			$.extend(PNotify.styling.jqueryui, {
113			closer: "ui-icon ui-icon-close",
114			pin_up: "ui-icon ui-icon-pin-w",
115			pin_down: "ui-icon ui-icon-pin-s"
116			});
117			$.extend(PNotify.styling.bootstrap2, {
118			closer: "icon-remove",
119			pin_up: "icon-pause",
120			pin_down: "icon-play"
121			});
122			$.extend(PNotify.styling.bootstrap3, {
123			closer: "glyphicon glyphicon-remove",
124			pin_up: "glyphicon glyphicon-pause",
125			pin_down: "glyphicon glyphicon-play"
126			});
127			$.extend(PNotify.styling.fontawesome, {
128			closer: "fa fa-times",
129			pin_up: "fa fa-pause",
130			pin_down: "fa fa-play"
131			});
132			}));
133

aepnat / simpuskesmas

Issues (4542)

js/notify/pnotify.buttons.js (17 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like