| Conditions | 9 |
| Paths | 144 |
| Total Lines | 68 |
| Code Lines | 21 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 31 | public function navHalaman($halaman_aktif, $jmlhalaman) |
||
| 32 | { |
||
| 33 | $link_halaman = ''; |
||
| 34 | |||
| 35 | if (($halaman_aktif - 1) > 0) { |
||
| 36 | $previous = $halaman_aktif - 1; |
||
| 37 | |||
| 38 | $link_halaman .= "<a href=$_SERVER[PHP_SELF]?module=$_GET[module]&halaman=$previous title=Previous><<</a> "; |
||
| 39 | } |
||
| 40 | |||
| 41 | // Link halaman 1,2,3, ... |
||
| 42 | |||
| 43 | //for ($i=1; $i<=$jmlhalaman; $i++) |
||
| 44 | // |
||
| 45 | //{ |
||
| 46 | // |
||
| 47 | //if ($i == $halaman_aktif) |
||
| 48 | // |
||
| 49 | //{ |
||
| 50 | // |
||
| 51 | //$link_halaman .= "<b class='currenthalaman'>$i</b>"; |
||
| 52 | // |
||
| 53 | //} |
||
| 54 | // |
||
| 55 | //else |
||
| 56 | // |
||
| 57 | //{ |
||
| 58 | // |
||
| 59 | //$link_halaman .= "<a href=$_SERVER[PHP_SELF]?module=$_GET[module]&halaman=$i>$i</a>"; |
||
| 60 | // |
||
| 61 | //} |
||
| 62 | // |
||
| 63 | //$link_halaman .= " "; |
||
| 64 | // |
||
| 65 | //} |
||
| 66 | |||
| 67 | /// |
||
| 68 | |||
| 69 | $angka = ($halaman > 3 ? ' ... ' : ' '); |
||
| 70 | for ($i = $halaman - 2; $i < $halaman; $i++) { |
||
| 71 | if ($i < 1) { |
||
| 72 | continue; |
||
| 73 | } |
||
| 74 | $angka .= "<a href=$_SERVER[PHP_SELF]?halaman=$i>$i</A> "; |
||
| 75 | } |
||
| 76 | |||
| 77 | $angka .= " <b>$halaman</b> "; |
||
| 78 | for ($i = $halaman + 1; $i < ($halaman + 3); $i++) { |
||
| 79 | if ($i > $jmlhalaman) { |
||
| 80 | break; |
||
| 81 | } |
||
| 82 | $angka .= "<a href=$_SERVER[PHP_SELF]?module=$_GET[module]&halaman=$i>$i</A> "; |
||
| 83 | } |
||
| 84 | |||
| 85 | $angka .= ($halaman + 2 < $jmlhalaman ? " ... |
||
| 86 | <a href=$_SERVER[PHP_SELF]?module=$_GET[module]&halaman=$jmlhalaman>$jmlhalaman</A> " : ' '); |
||
| 87 | |||
| 88 | echo "$angka"; |
||
| 89 | |||
| 90 | // Link Next dan Last |
||
| 91 | |||
| 92 | if ($halaman_aktif < $jmlhalaman) { |
||
| 93 | $next = $halaman_aktif + 1; |
||
| 94 | |||
| 95 | $link_halaman .= " <a href=$_SERVER[PHP_SELF]?module=$_GET[module]&halaman=$next title=Next>>></a> "; |
||
| 96 | } |
||
| 97 | |||
| 98 | return $link_halaman; |
||
| 99 | } |
||
| 228 | <?php */?> |
||