copyImage() - Code Metrics - aepnat/simpuskesmas - Measure and Improve Code Quality continuously with Scrutinizer

copyImage() B
last analyzed 2019-02-14 14:22 UTC

↳ Parent: Project

Complexity

Conditions	10
Paths	3

Size

Total Lines	44
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	32
nc	3
nop	5
dl	0
loc	44
rs	7.6666
c	0
b	0
f	0

How to fix Complexity

<?php

/*
    Upload an image and create the thumbnail. The thumbnail is stored
    under the thumbnail sub-directory of $uploadDir.

    Return the uploaded image name and the thumbnail also.
*/
function uploadImage($inputName, $uploadDir)
{
    $image = $_FILES[$inputName];
    $imagePath = '';
    $thumbnailPath = '';

    // if a file is given
    if (trim($image['tmp_name']) != '') {
        $ext = substr(strrchr($image['name'], '.'), 1);


        // generate a random new file name to avoid name conflict
        // then save the image under the new file name
        $imagePath = '';
        $result = move_uploaded_file($image['tmp_name'], $uploadDir.$imagePath);

        if ($result) {
            // create thumbnail
            $thumbnailPath = '';
            $result = createThumbnail($uploadDir.$imagePath, $uploadDir.'thumbnail/'.$thumbnailPath, THUMBNAIL_WIDTH);


            // create thumbnail failed, delete the image
            if (!$result) {
                unlink($uploadDir.$imagePath);
                $imagePath = $thumbnailPath = '';
            } else {
                $thumbnailPath = $result;
            }
        } else {
            // the image cannot be uploaded
            $imagePath = $thumbnailPath = '';
        }
    }

    return ['image' => $imagePath, 'thumbnail' => $thumbnailPath];
}

/*
    Create a thumbnail of $srcFile and save it to $destFile.
    The thumbnail will be $width pixels.
*/
function createThumbnail($srcFile, $destFile, $width, $quality = 75)
{
    $thumbnail = '';

    if (file_exists($srcFile) && isset($destFile)) {
        $size = getimagesize($srcFile);
        $w = number_format($width, 0, ',', '');
        $h = number_format(($size[1] / $size[0]) * $width, 0, ',', '');

        $thumbnail = copyImage($srcFile, $destFile, $w, $h, $quality);
    }

    // return the thumbnail file name on sucess or blank on fail
    return basename($thumbnail);
}

/*
    Copy an image to a destination file. The destination
    image size will be $w X $h pixels
*/
function copyImage($srcFile, $destFile, $w, $h, $quality = 100)
{
    $tmpSrc = pathinfo(strtolower($srcFile));

    $tmpDest = pathinfo(strtolower($destFile));
    $size = getimagesize($srcFile);

    if ($tmpDest['extension'] == 'gif' || $tmpDest['extension'] == 'jpg') {
        $destFile = substr_replace($destFile, 'jpg', -3);
        $dest = imagecreatetruecolor($w, $h);
    //imageantialias($dest, TRUE);
    } elseif ($tmpDest['extension'] == 'png') {
        $dest = imagecreatetruecolor($w, $h);
    //imageantialias($dest, TRUE);
    } else {
        return false;
    }

    switch ($size[2]) {
        case 1:       //GIF
           $src = imagecreatefromgif($srcFile);
            break;
        case 2:       //JPEG
           $src = imagecreatefromjpeg($srcFile);
            break;
        case 3:       //PNG
           $src = imagecreatefrompng($srcFile);
            break;
        default:
           return false;
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
    }

    imagecopyresampled($dest, $src, 0, 0, 0, 0, $w, $h, $size[0], $size[1]);

    switch ($size[2]) {
        case 1:
       case 2:
           imagejpeg($dest, $destFile, $quality);
            break;
        case 3:
           imagepng($dest, $destFile);
    }

    return $destFile;
}


1			<?php
2
3			/*
4			Upload an image and create the thumbnail. The thumbnail is stored
5			under the thumbnail sub-directory of $uploadDir.
6
7			Return the uploaded image name and the thumbnail also.
8			*/
9			function uploadImage($inputName, $uploadDir)
10			{
11			$image = $_FILES[$inputName];
12			$imagePath = '';
13			$thumbnailPath = '';
14
15			// if a file is given
16			if (trim($image['tmp_name']) != '') {
17			$ext = substr(strrchr($image['name'], '.'), 1);
			0 ignored issues – show Unused Code introduced 2018-11-30 16:41 UTC by Report Bug Copy Issue Report The assignment to `$ext` is dead and can be removed. Loading history...
18
19			// generate a random new file name to avoid name conflict
20			// then save the image under the new file name
21			$imagePath = '';
22			$result = move_uploaded_file($image['tmp_name'], $uploadDir.$imagePath);
23
24			if ($result) {
25			// create thumbnail
26			$thumbnailPath = '';
27			$result = createThumbnail($uploadDir.$imagePath, $uploadDir.'thumbnail/'.$thumbnailPath, THUMBNAIL_WIDTH);
			0 ignored issues – show Bug introduced 2018-11-30 16:41 UTC by Report Bug Copy Issue Report The constant `THUMBNAIL_WIDTH` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
28
29			// create thumbnail failed, delete the image
30			if (!$result) {
31			unlink($uploadDir.$imagePath);
32			$imagePath = $thumbnailPath = '';
33			} else {
34			$thumbnailPath = $result;
35			}
36			} else {
37			// the image cannot be uploaded
38			$imagePath = $thumbnailPath = '';
39			}
40			}
41
42			return ['image' => $imagePath, 'thumbnail' => $thumbnailPath];
43			}
44
45			/*
46			Create a thumbnail of $srcFile and save it to $destFile.
47			The thumbnail will be $width pixels.
48			*/
49			function createThumbnail($srcFile, $destFile, $width, $quality = 75)
50			{
51			$thumbnail = '';
52
53			if (file_exists($srcFile) && isset($destFile)) {
54			$size = getimagesize($srcFile);
55			$w = number_format($width, 0, ',', '');
56			$h = number_format(($size[1] / $size[0]) * $width, 0, ',', '');
57
58			$thumbnail = copyImage($srcFile, $destFile, $w, $h, $quality);
59			}
60
61			// return the thumbnail file name on sucess or blank on fail
62			return basename($thumbnail);
63			}
64
65			/*
66			Copy an image to a destination file. The destination
67			image size will be $w X $h pixels
68			*/
69			function copyImage($srcFile, $destFile, $w, $h, $quality = 100)
70			{
71			$tmpSrc = pathinfo(strtolower($srcFile));
			0 ignored issues – show Unused Code introduced 2018-11-30 16:41 UTC by Report Bug Copy Issue Report The assignment to `$tmpSrc` is dead and can be removed. Loading history...
72			$tmpDest = pathinfo(strtolower($destFile));
73			$size = getimagesize($srcFile);
74
75			if ($tmpDest['extension'] == 'gif' \|\| $tmpDest['extension'] == 'jpg') {
76			$destFile = substr_replace($destFile, 'jpg', -3);
77			$dest = imagecreatetruecolor($w, $h);
78			//imageantialias($dest, TRUE);
79			} elseif ($tmpDest['extension'] == 'png') {
80			$dest = imagecreatetruecolor($w, $h);
81			//imageantialias($dest, TRUE);
82			} else {
83			return false;
84			}
85
86			switch ($size[2]) {
87			case 1: //GIF
88			$src = imagecreatefromgif($srcFile);
89			break;
90			case 2: //JPEG
91			$src = imagecreatefromjpeg($srcFile);
92			break;
93			case 3: //PNG
94			$src = imagecreatefrompng($srcFile);
95			break;
96			default:
97			return false;
98			break;
			0 ignored issues – show Unused Code introduced 2018-11-30 16:41 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
99			}
100
101			imagecopyresampled($dest, $src, 0, 0, 0, 0, $w, $h, $size[0], $size[1]);
102
103			switch ($size[2]) {
104			case 1:
105			case 2:
106			imagejpeg($dest, $destFile, $quality);
107			break;
108			case 3:
109			imagepng($dest, $destFile);
110			}
111
112			return $destFile;
113			}
114

aepnat / simpuskesmas

copyImage() B last analyzed 2019-02-14 14:22 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

copyImage() B
last analyzed 2019-02-14 14:22 UTC