Inspection of "menu my assignment only for admin" - aepnat/simhelpdesk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ce6199...f8d49f )

by Saepul

created 2018-12-01 16:36 UTC

Status

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -51,20 +51,20 @@
 block discarded – undo
     </thead>
     <tbody>
 		<?php 
-        foreach ($tickets as $ticket) {
-            $sla = $slas->sla_data($ticket['sla']);
-            $customer = $customers->customer_data($ticket['idcustomer']);
-            $user = $users->userdata($ticket['assignee']);
-            echo '<tr><td><a href="ticketedit.php?id='.$ticket['id'].'">'.$ticket['ticketnumber'].'</a></td>'.
-                 '<td>'.$sla['namasla'].'</td>'.
-                 '<td>'.$customer['namacustomer'].'</td>'.
-                 '<td>'.date('d-M-Y', $ticket['reporteddate']).'</td>'.
-                 '<td>'.$ticket['reportedby'].'</td>'.
-                 '<td>'.$ticket['problemsummary'].'</td>'.
-                 '<td>'.$ticket['ticketstatus'].'</td>'.
-                 '<td>'.$user['fullname'].'</td></tr>';
-        }
-        ?>
+		foreach ($tickets as $ticket) {
+			$sla = $slas->sla_data($ticket['sla']);
+			$customer = $customers->customer_data($ticket['idcustomer']);
+			$user = $users->userdata($ticket['assignee']);
+			echo '<tr><td><a href="ticketedit.php?id='.$ticket['id'].'">'.$ticket['ticketnumber'].'</a></td>'.
+				 '<td>'.$sla['namasla'].'</td>'.
+				 '<td>'.$customer['namacustomer'].'</td>'.
+				 '<td>'.date('d-M-Y', $ticket['reporteddate']).'</td>'.
+				 '<td>'.$ticket['reportedby'].'</td>'.
+				 '<td>'.$ticket['problemsummary'].'</td>'.
+				 '<td>'.$ticket['ticketstatus'].'</td>'.
+				 '<td>'.$user['fullname'].'</td></tr>';
+		}
+		?>
     </tbody>
 	</table>
 	<p>&nbsp;</p>

Please login to merge, or discard this patch.

useredit.php 1 patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -4,19 +4,19 @@
 block discarded – undo
 $id = $_GET['id'];
 $member = $users->userdata($id);
 if (isset($_POST['submit'])) {
-    $fullname = $_POST['fullname'];
-    $username = htmlentities($_POST['username']);
-    $password = $_POST['password'];
-    $email = htmlentities($_POST['email']);
-    $Telp = $_POST['telp'];
-    $level = $_POST['level'];
-    $locked = $_POST['locked'];
-    //echo 'Old Passw: '.$member['password']. ' New Passw:'. $password;
-    if ($password == '') {
-        $password = $member['password'];
-    }
-    $users->update($id, $username, $password, $email, $fullname, $Telp, $level, $locked);
-    header('Location: userlist.php');
+	$fullname = $_POST['fullname'];
+	$username = htmlentities($_POST['username']);
+	$password = $_POST['password'];
+	$email = htmlentities($_POST['email']);
+	$Telp = $_POST['telp'];
+	$level = $_POST['level'];
+	$locked = $_POST['locked'];
+	//echo 'Old Passw: '.$member['password']. ' New Passw:'. $password;
+	if ($password == '') {
+		$password = $member['password'];
+	}
+	$users->update($id, $username, $password, $email, $fullname, $Telp, $level, $locked);
+	header('Location: userlist.php');
 }
 ?>
 <!DOCTYPE HTML>

Please login to merge, or discard this patch.

useradd.php 1 patch

Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

@@ -2,23 +2,23 @@  discard block
 block discarded – undo
 require 'core/init.php';
 $general->logged_out_protect();
 if (isset($_POST['submit'])) {
-    if ($users->user_exists($_POST['username']) == true && !empty($_POST['username'])) {
-        $errors[] = 'Sorry, username '.$_POST['username'].' is already exists!';
-    }
-    if ($users->email_exists($_POST['email']) == true && !empty($_POST['email'])) {
-        $errors[] = 'Sorry, email '.$_POST['email'].' is already exists!';
-    }
-    if (empty($errors) === true) {
-        $fullname = $_POST['fullname'];
-        $username = htmlentities($_POST['username']);
-        $password = $_POST['password'];
-        $email = htmlentities($_POST['email']);
-        $Telp = $_POST['telp'];
-        $level = $_POST['level'];
-        $locked = $_POST['locked'];
-        $users->register($username, $password, $email, $fullname, $Telp, $level, $locked);
-        header('Location: userlist.php');
-    }
+	if ($users->user_exists($_POST['username']) == true && !empty($_POST['username'])) {
+		$errors[] = 'Sorry, username '.$_POST['username'].' is already exists!';
+	}
+	if ($users->email_exists($_POST['email']) == true && !empty($_POST['email'])) {
+		$errors[] = 'Sorry, email '.$_POST['email'].' is already exists!';
+	}
+	if (empty($errors) === true) {
+		$fullname = $_POST['fullname'];
+		$username = htmlentities($_POST['username']);
+		$password = $_POST['password'];
+		$email = htmlentities($_POST['email']);
+		$Telp = $_POST['telp'];
+		$level = $_POST['level'];
+		$locked = $_POST['locked'];
+		$users->register($username, $password, $email, $fullname, $Telp, $level, $locked);
+		header('Location: userlist.php');
+	}
 }
 ?>
 <!DOCTYPE HTML>
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
 	</fieldset>
 	</form>
 	<?php 
-    if (empty($errors) === false) {
-        echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
-    }
-    ?>
+	if (empty($errors) === false) {
+		echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
+	}
+	?>
 </body>
 </html>
\ No newline at end of file

Please login to merge, or discard this patch.

myticketbyrequester.php 1 patch

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -51,20 +51,20 @@
 block discarded – undo
     </thead>
     <tbody>
 		<?php 
-        foreach ($tickets as $ticket) {
-            $sla = $slas->sla_data($ticket['sla']);
-            $customer = $customers->customer_data($ticket['idcustomer']);
-            $user = $users->userdata($ticket['assignee']);
-            echo '<tr><td><a href=ticketedituser.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
-                 '<td>'.$sla['namasla'].'</td>'.
-                 '<td>'.$customer['namacustomer'].'</td>'.
-                 '<td>'.date('d-M-Y', $ticket['reporteddate']).'</td>'.
-                 '<td>'.$ticket['reportedby'].'</td>'.
-                 '<td>'.$ticket['problemsummary'].'</td>'.
-                 '<td>'.$ticket['ticketstatus'].'</td>'.
-                 '<td>'.$user['fullname'].'</td></tr>';
-        }
-        ?>
+		foreach ($tickets as $ticket) {
+			$sla = $slas->sla_data($ticket['sla']);
+			$customer = $customers->customer_data($ticket['idcustomer']);
+			$user = $users->userdata($ticket['assignee']);
+			echo '<tr><td><a href=ticketedituser.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
+				 '<td>'.$sla['namasla'].'</td>'.
+				 '<td>'.$customer['namacustomer'].'</td>'.
+				 '<td>'.date('d-M-Y', $ticket['reporteddate']).'</td>'.
+				 '<td>'.$ticket['reportedby'].'</td>'.
+				 '<td>'.$ticket['problemsummary'].'</td>'.
+				 '<td>'.$ticket['ticketstatus'].'</td>'.
+				 '<td>'.$user['fullname'].'</td></tr>';
+		}
+		?>
     </tbody>
 	</table>
 	<p>&nbsp;</p>

Please login to merge, or discard this patch.

slaadd.php 2 patches

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -3,21 +3,21 @@  discard block
 block discarded – undo
 $general->logged_out_protect();
 $user = $users->userdata($_SESSION['loginid']);
 if ($user['level'] != 'Admin') {
-    exit("You don't have permission to access this page!");
+	exit("You don't have permission to access this page!");
 }
 
 if (isset($_POST['submit'])) {
-    $slaid = $_POST['slaid'];
-    $namasla = $_POST['namasla'];
-    $responsetime = $_POST['responsetime'];
-    $resolutiontime = $_POST['resolutiontime'];
-    $slawarning = $_POST['slawarning'];
-    if ($slas->sla_exists($slaid) === true) {
-        $errors[] = 'SLA ID is already exists!';
-    } else {
-        $slas->add_sla($slaid, $namasla, $responsetime, $resolutiontime, $slawarning);
-        header('location:slalist.php');
-    }
+	$slaid = $_POST['slaid'];
+	$namasla = $_POST['namasla'];
+	$responsetime = $_POST['responsetime'];
+	$resolutiontime = $_POST['resolutiontime'];
+	$slawarning = $_POST['slawarning'];
+	if ($slas->sla_exists($slaid) === true) {
+		$errors[] = 'SLA ID is already exists!';
+	} else {
+		$slas->add_sla($slaid, $namasla, $responsetime, $resolutiontime, $slawarning);
+		header('location:slalist.php');
+	}
 }
 ?>
 <!DOCTYPE HTML>
@@ -100,9 +100,9 @@  discard block
 block discarded – undo
 	</fieldset>
 	</form>
 	<?php 
-    if (empty($errors) === false) {
-        echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
-    }
-    ?>
+	if (empty($errors) === false) {
+		echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
+	}
+	?>
 </body>
 </html>
\ No newline at end of file

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -14,7 +14,7 @@
 block discarded – undo
     $slawarning = $_POST['slawarning'];
     if ($slas->sla_exists($slaid) === true) {
         $errors[] = 'SLA ID is already exists!';
-    } else {
+    }else {
         $slas->add_sla($slaid, $namasla, $responsetime, $resolutiontime, $slawarning);
         header('location:slalist.php');
     }

Please login to merge, or discard this patch.

ticketlist.php 2 patches

Indentation +34 added lines, -34 removed lines patch added patch discarded remove patch

@@ -3,12 +3,12 @@  discard block
 block discarded – undo
 $general->logged_out_protect();
 $user = $users->userdata($_SESSION['loginid']);
 if ($user['level'] == 'Admin' || $user['level'] == 'Manager') {
-    $akses = true;
+	$akses = true;
 } else {
-    $akses = false;
+	$akses = false;
 }
 if ($akses = false) {
-    exit("You don't have permission to access this page!");
+	exit("You don't have permission to access this page!");
 }
 $ticket_list = $tickets->get_tickets();
 $tickets_count = count($ticket_list);
@@ -71,37 +71,37 @@  discard block
 block discarded – undo
     </thead>
     <tbody>
 		<?php 
-        foreach ($ticket_list as $ticket) {
-            $sla = $slas->sla_data($ticket['sla']);
-            $documenteddate = $ticket['documenteddate'];
-            $resolutiontime = $sla['resolutiontime'];
-            $slawarning = $sla['slawarning'];
-            $slagoaltime = strtotime("+$resolutiontime hours", $documenteddate);
-            $slawarningtime = strtotime("+$slawarning hours", $documenteddate);
-            if ($currenttime > $slagoaltime) {
-                $slabgcolor = '#FF0000';
-                $slatxtcolor = '#ffffff';
-            } elseif ($currenttime >= $slawarningtime) {
-                $slabgcolor = '#FFFF00';
-                $slatxtcolor = '#000000';
-            } else {
-                $slabgcolor = '#00FF00';
-                $slatxtcolor = '#000000';
-            }
-            $customer = $customers->customer_data($ticket['idcustomer']);
-            $user = $users->userdata($ticket['assignee']);
-            echo '<tr><td><a href=ticketedit.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
-                 '<td style="background-color:'.$slabgcolor.';color:'.$slatxtcolor.';">'.$sla['namasla'].'</td>'.
-                 '<td>'.date('d-M-Y H:i:s', $slagoaltime).'</td>'.
-                 '<td>'.$customer['namacustomer'].'</td>'.
-                 '<td>'.date('d-M-Y H:i:s', $ticket['reporteddate']).'</td>'.
-                 '<td>'.date('d-M-Y H:i:s', $ticket['documenteddate']).'</td>'.
-                 '<td>'.$ticket['problemsummary'].'</td>'.
-                 '<td>'.$ticket['ticketstatus'].'</td>'.
-                 '<td>'.$user['fullname'].'</td>'.
-                 '<td><a href=ticketdel.php?id='.$ticket['id'].' onclick="return delete_confirm();">del</a></td></tr>';
-        }
-        ?>
+		foreach ($ticket_list as $ticket) {
+			$sla = $slas->sla_data($ticket['sla']);
+			$documenteddate = $ticket['documenteddate'];
+			$resolutiontime = $sla['resolutiontime'];
+			$slawarning = $sla['slawarning'];
+			$slagoaltime = strtotime("+$resolutiontime hours", $documenteddate);
+			$slawarningtime = strtotime("+$slawarning hours", $documenteddate);
+			if ($currenttime > $slagoaltime) {
+				$slabgcolor = '#FF0000';
+				$slatxtcolor = '#ffffff';
+			} elseif ($currenttime >= $slawarningtime) {
+				$slabgcolor = '#FFFF00';
+				$slatxtcolor = '#000000';
+			} else {
+				$slabgcolor = '#00FF00';
+				$slatxtcolor = '#000000';
+			}
+			$customer = $customers->customer_data($ticket['idcustomer']);
+			$user = $users->userdata($ticket['assignee']);
+			echo '<tr><td><a href=ticketedit.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
+				 '<td style="background-color:'.$slabgcolor.';color:'.$slatxtcolor.';">'.$sla['namasla'].'</td>'.
+				 '<td>'.date('d-M-Y H:i:s', $slagoaltime).'</td>'.
+				 '<td>'.$customer['namacustomer'].'</td>'.
+				 '<td>'.date('d-M-Y H:i:s', $ticket['reporteddate']).'</td>'.
+				 '<td>'.date('d-M-Y H:i:s', $ticket['documenteddate']).'</td>'.
+				 '<td>'.$ticket['problemsummary'].'</td>'.
+				 '<td>'.$ticket['ticketstatus'].'</td>'.
+				 '<td>'.$user['fullname'].'</td>'.
+				 '<td><a href=ticketdel.php?id='.$ticket['id'].' onclick="return delete_confirm();">del</a></td></tr>';
+		}
+		?>
     </tbody>
 	</table>
 	<p>&nbsp;</p>

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -5,7 +5,7 @@  discard block
 block discarded – undo
 $user = $users->userdata($_SESSION['loginid']);
 if ($user['level'] == 'Admin' || $user['level'] == 'Manager') {
     $akses = true;
-} else {
+}else {
     $akses = false;
 }
 if ($akses = false) {
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
             } elseif ($currenttime >= $slawarningtime) {
                 $slabgcolor = '#FFFF00';
                 $slatxtcolor = '#000000';
-            } else {
+            }else {
                 $slabgcolor = '#00FF00';
                 $slatxtcolor = '#000000';
             }

Please login to merge, or discard this patch.

slalist.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -3,7 +3,7 @@  discard block
 block discarded – undo
 $general->logged_out_protect();
 $user = $users->userdata($_SESSION['loginid']);
 if ($user['level'] != 'Admin') {
-    exit("You don't have permission to access this page!");
+	exit("You don't have permission to access this page!");
 }
 $sla = $slas->get_sla();
 ?>
@@ -58,15 +58,15 @@  discard block
 block discarded – undo
     </thead>
     <tbody>
 		<?php 
-        foreach ($sla as $slaval) {
-            echo '<tr><td>'.$slaval['slaid'].'</td>'.
-                 '<td><a href=slaedit.php?id='.$slaval['slaid'].'>'.$slaval['namasla'].'</a></td>'.
-                 '<td>'.$slaval['responsetime'].' Hours</td>'.
-                 '<td>'.$slaval['resolutiontime'].' Hours</td>'.
-                 '<td>'.$slaval['slawarning'].' Hours</td>'.
-                 '<td><a href=sladel.php?id='.$slaval['slaid'].' onclick="return delete_confirm();">del</a></td></tr>';
-        }
-        ?>
+		foreach ($sla as $slaval) {
+			echo '<tr><td>'.$slaval['slaid'].'</td>'.
+				 '<td><a href=slaedit.php?id='.$slaval['slaid'].'>'.$slaval['namasla'].'</a></td>'.
+				 '<td>'.$slaval['responsetime'].' Hours</td>'.
+				 '<td>'.$slaval['resolutiontime'].' Hours</td>'.
+				 '<td>'.$slaval['slawarning'].' Hours</td>'.
+				 '<td><a href=sladel.php?id='.$slaval['slaid'].' onclick="return delete_confirm();">del</a></td></tr>';
+		}
+		?>
     </tbody>
 	</table>
 	</div>

Please login to merge, or discard this patch.

email/notify_new_ticket.php 2 patches

Indentation +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -5,24 +5,24 @@
 block discarded – undo
 $emailstatus = 'New';
 $new_emails = $emails->get_email_by_status($emailstatus);
 foreach ($new_emails as $new_email) {
-    $idemail = $new_email['idemail'];
-    $to = $new_email['emailto'];
-    $cc = substr($new_email['emailcc'], 0, -2);
-    $subject = $new_email['emailsubject'];
-    $message = $new_email['message'];
+	$idemail = $new_email['idemail'];
+	$to = $new_email['emailto'];
+	$cc = substr($new_email['emailcc'], 0, -2);
+	$subject = $new_email['emailsubject'];
+	$message = $new_email['message'];
 
-    $headers = [];
-    $headers[] = 'MIME-Version: 1.0';
-    $headers[] = 'Content-type: text/plain; charset=iso-8859-1';
-    $headers[] = 'From: Helpdesk System <[email protected]>';
-    $headers[] = "Cc: $cc";
-    $headers[] = 'Bcc:';
-    $headers[] = 'Reply-To: Helpdesk System <[email protected]>';
-    $headers[] = 'X-Mailer: PHP/'.phpversion();
-    $ok = mail($to, $subject, $message, implode("\r\n", $headers));
-    if ($ok) {
-        $emails->update_status_email($idemail, 'Sent');
-    } else {
-        $emails->update_status_email($idemail, 'Cannot Send');
-    }
+	$headers = [];
+	$headers[] = 'MIME-Version: 1.0';
+	$headers[] = 'Content-type: text/plain; charset=iso-8859-1';
+	$headers[] = 'From: Helpdesk System <[email protected]>';
+	$headers[] = "Cc: $cc";
+	$headers[] = 'Bcc:';
+	$headers[] = 'Reply-To: Helpdesk System <[email protected]>';
+	$headers[] = 'X-Mailer: PHP/'.phpversion();
+	$ok = mail($to, $subject, $message, implode("\r\n", $headers));
+	if ($ok) {
+		$emails->update_status_email($idemail, 'Sent');
+	} else {
+		$emails->update_status_email($idemail, 'Cannot Send');
+	}
 }

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@
 block discarded – undo
     $ok = mail($to, $subject, $message, implode("\r\n", $headers));
     if ($ok) {
         $emails->update_status_email($idemail, 'Sent');
-    } else {
+    }else {
         $emails->update_status_email($idemail, 'Cannot Send');
     }
 }

Please login to merge, or discard this patch.

email/sla_remainder.php 1 patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -4,22 +4,22 @@
 block discarded – undo
 //$general->logged_out_protect();
 $sla_emails = $emails->get_email_sla_remainder();
 foreach ($sla_emails as $sla_email) {
-    $idemail = $sla_email['idemail'];
-    $to = $sla_email['emailto'];
-    $cc = substr($sla_email['emailcc'], 0, -2);
-    $subject = $sla_email['emailsubject'];
-    $message = $sla_email['message'];
+	$idemail = $sla_email['idemail'];
+	$to = $sla_email['emailto'];
+	$cc = substr($sla_email['emailcc'], 0, -2);
+	$subject = $sla_email['emailsubject'];
+	$message = $sla_email['message'];
 
-    $headers = [];
-    $headers[] = 'MIME-Version: 1.0';
-    $headers[] = 'Content-type: text/plain; charset=iso-8859-1';
-    $headers[] = 'From: Helpdesk System <[email protected]>';
-    $headers[] = "Cc:$cc";
-    $headers[] = 'Bcc:';
-    $headers[] = 'Reply-To: Helpdesk System <[email protected]>';
-    $headers[] = 'X-Mailer: PHP/'.phpversion();
-    echo $idemail.'<br>';
-    /*
+	$headers = [];
+	$headers[] = 'MIME-Version: 1.0';
+	$headers[] = 'Content-type: text/plain; charset=iso-8859-1';
+	$headers[] = 'From: Helpdesk System <[email protected]>';
+	$headers[] = "Cc:$cc";
+	$headers[] = 'Bcc:';
+	$headers[] = 'Reply-To: Helpdesk System <[email protected]>';
+	$headers[] = 'X-Mailer: PHP/'.phpversion();
+	echo $idemail.'<br>';
+	/*
     $ok = mail($to, $subject, $message, implode("\r\n", $headers));
     if ($ok)
     {	$emails->update_status_email($idemail,"Sent");

Please login to merge, or discard this patch.

		@@ -51,20 +51,20 @@
		block discarded – undo
51	51	</thead>
52	52	<tbody>
53	53	<?php
54		- foreach ($tickets as $ticket) {
55		- $sla = $slas->sla_data($ticket['sla']);
56		- $customer = $customers->customer_data($ticket['idcustomer']);
57		- $user = $users->userdata($ticket['assignee']);
58		- echo '<tr><td><a href="ticketedit.php?id='.$ticket['id'].'">'.$ticket['ticketnumber'].'</a></td>'.
59		- '<td>'.$sla['namasla'].'</td>'.
60		- '<td>'.$customer['namacustomer'].'</td>'.
61		- '<td>'.date('d-M-Y', $ticket['reporteddate']).'</td>'.
62		- '<td>'.$ticket['reportedby'].'</td>'.
63		- '<td>'.$ticket['problemsummary'].'</td>'.
64		- '<td>'.$ticket['ticketstatus'].'</td>'.
65		- '<td>'.$user['fullname'].'</td></tr>';
66		- }
67		- ?>
	54	+ foreach ($tickets as $ticket) {
	55	+ $sla = $slas->sla_data($ticket['sla']);
	56	+ $customer = $customers->customer_data($ticket['idcustomer']);
	57	+ $user = $users->userdata($ticket['assignee']);
	58	+ echo '<tr><td><a href="ticketedit.php?id='.$ticket['id'].'">'.$ticket['ticketnumber'].'</a></td>'.
	59	+ '<td>'.$sla['namasla'].'</td>'.
	60	+ '<td>'.$customer['namacustomer'].'</td>'.
	61	+ '<td>'.date('d-M-Y', $ticket['reporteddate']).'</td>'.
	62	+ '<td>'.$ticket['reportedby'].'</td>'.
	63	+ '<td>'.$ticket['problemsummary'].'</td>'.
	64	+ '<td>'.$ticket['ticketstatus'].'</td>'.
	65	+ '<td>'.$user['fullname'].'</td></tr>';
	66	+ }
	67	+ ?>
68	68	</tbody>
69	69	</table>
70	70	<p> </p>

		@@ -4,19 +4,19 @@
		block discarded – undo
4	4	$id = $_GET['id'];
5	5	$member = $users->userdata($id);
6	6	if (isset($_POST['submit'])) {
7		- $fullname = $_POST['fullname'];
8		- $username = htmlentities($_POST['username']);
9		- $password = $_POST['password'];
10		- $email = htmlentities($_POST['email']);
11		- $Telp = $_POST['telp'];
12		- $level = $_POST['level'];
13		- $locked = $_POST['locked'];
14		- //echo 'Old Passw: '.$member['password']. ' New Passw:'. $password;
15		- if ($password == '') {
16		- $password = $member['password'];
17		- }
18		- $users->update($id, $username, $password, $email, $fullname, $Telp, $level, $locked);
19		- header('Location: userlist.php');
	7	+ $fullname = $_POST['fullname'];
	8	+ $username = htmlentities($_POST['username']);
	9	+ $password = $_POST['password'];
	10	+ $email = htmlentities($_POST['email']);
	11	+ $Telp = $_POST['telp'];
	12	+ $level = $_POST['level'];
	13	+ $locked = $_POST['locked'];
	14	+ //echo 'Old Passw: '.$member['password']. ' New Passw:'. $password;
	15	+ if ($password == '') {
	16	+ $password = $member['password'];
	17	+ }
	18	+ $users->update($id, $username, $password, $email, $fullname, $Telp, $level, $locked);
	19	+ header('Location: userlist.php');
20	20	}
21	21	?>
22	22	<!DOCTYPE HTML>

		@@ -2,23 +2,23 @@ discard block
		block discarded – undo
2	2	require 'core/init.php';
3	3	$general->logged_out_protect();
4	4	if (isset($_POST['submit'])) {
5		- if ($users->user_exists($_POST['username']) == true && !empty($_POST['username'])) {
6		- $errors[] = 'Sorry, username '.$_POST['username'].' is already exists!';
7		- }
8		- if ($users->email_exists($_POST['email']) == true && !empty($_POST['email'])) {
9		- $errors[] = 'Sorry, email '.$_POST['email'].' is already exists!';
10		- }
11		- if (empty($errors) === true) {
12		- $fullname = $_POST['fullname'];
13		- $username = htmlentities($_POST['username']);
14		- $password = $_POST['password'];
15		- $email = htmlentities($_POST['email']);
16		- $Telp = $_POST['telp'];
17		- $level = $_POST['level'];
18		- $locked = $_POST['locked'];
19		- $users->register($username, $password, $email, $fullname, $Telp, $level, $locked);
20		- header('Location: userlist.php');
21		- }
	5	+ if ($users->user_exists($_POST['username']) == true && !empty($_POST['username'])) {
	6	+ $errors[] = 'Sorry, username '.$_POST['username'].' is already exists!';
	7	+ }
	8	+ if ($users->email_exists($_POST['email']) == true && !empty($_POST['email'])) {
	9	+ $errors[] = 'Sorry, email '.$_POST['email'].' is already exists!';
	10	+ }
	11	+ if (empty($errors) === true) {
	12	+ $fullname = $_POST['fullname'];
	13	+ $username = htmlentities($_POST['username']);
	14	+ $password = $_POST['password'];
	15	+ $email = htmlentities($_POST['email']);
	16	+ $Telp = $_POST['telp'];
	17	+ $level = $_POST['level'];
	18	+ $locked = $_POST['locked'];
	19	+ $users->register($username, $password, $email, $fullname, $Telp, $level, $locked);
	20	+ header('Location: userlist.php');
	21	+ }
22	22	}
23	23	?>
24	24	<!DOCTYPE HTML>
		@@ -102,9 +102,9 @@ discard block
		block discarded – undo
102	102	</fieldset>
103	103	</form>
104	104	<?php
105		- if (empty($errors) === false) {
106		- echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
107		- }
108		- ?>
	105	+ if (empty($errors) === false) {
	106	+ echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
	107	+ }
	108	+ ?>
109	109	</body>
110	110	</html>
111	111	\ No newline at end of file

		@@ -3,21 +3,21 @@ discard block
		block discarded – undo
3	3	$general->logged_out_protect();
4	4	$user = $users->userdata($_SESSION['loginid']);
5	5	if ($user['level'] != 'Admin') {
6		- exit("You don't have permission to access this page!");
	6	+ exit("You don't have permission to access this page!");
7	7	}
8	8
9	9	if (isset($_POST['submit'])) {
10		- $slaid = $_POST['slaid'];
11		- $namasla = $_POST['namasla'];
12		- $responsetime = $_POST['responsetime'];
13		- $resolutiontime = $_POST['resolutiontime'];
14		- $slawarning = $_POST['slawarning'];
15		- if ($slas->sla_exists($slaid) === true) {
16		- $errors[] = 'SLA ID is already exists!';
17		- } else {
18		- $slas->add_sla($slaid, $namasla, $responsetime, $resolutiontime, $slawarning);
19		- header('location:slalist.php');
20		- }
	10	+ $slaid = $_POST['slaid'];
	11	+ $namasla = $_POST['namasla'];
	12	+ $responsetime = $_POST['responsetime'];
	13	+ $resolutiontime = $_POST['resolutiontime'];
	14	+ $slawarning = $_POST['slawarning'];
	15	+ if ($slas->sla_exists($slaid) === true) {
	16	+ $errors[] = 'SLA ID is already exists!';
	17	+ } else {
	18	+ $slas->add_sla($slaid, $namasla, $responsetime, $resolutiontime, $slawarning);
	19	+ header('location:slalist.php');
	20	+ }
21	21	}
22	22	?>
23	23	<!DOCTYPE HTML>
		@@ -100,9 +100,9 @@ discard block
		block discarded – undo
100	100	</fieldset>
101	101	</form>
102	102	<?php
103		- if (empty($errors) === false) {
104		- echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
105		- }
106		- ?>
	103	+ if (empty($errors) === false) {
	104	+ echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
	105	+ }
	106	+ ?>
107	107	</body>
108	108	</html>
109	109	\ No newline at end of file

		@@ -14,7 +14,7 @@
		block discarded – undo
14	14	$slawarning = $_POST['slawarning'];
15	15	if ($slas->sla_exists($slaid) === true) {
16	16	$errors[] = 'SLA ID is already exists!';
17		- } else {
	17	+ }else {
18	18	$slas->add_sla($slaid, $namasla, $responsetime, $resolutiontime, $slawarning);
19	19	header('location:slalist.php');
20	20	}

		@@ -3,12 +3,12 @@ discard block
		block discarded – undo
3	3	$general->logged_out_protect();
4	4	$user = $users->userdata($_SESSION['loginid']);
5	5	if ($user['level'] == 'Admin' \|\| $user['level'] == 'Manager') {
6		- $akses = true;
	6	+ $akses = true;
7	7	} else {
8		- $akses = false;
	8	+ $akses = false;
9	9	}
10	10	if ($akses = false) {
11		- exit("You don't have permission to access this page!");
	11	+ exit("You don't have permission to access this page!");
12	12	}
13	13	$ticket_list = $tickets->get_tickets();
14	14	$tickets_count = count($ticket_list);
		@@ -71,37 +71,37 @@ discard block
		block discarded – undo
71	71	</thead>
72	72	<tbody>
73	73	<?php
74		- foreach ($ticket_list as $ticket) {
75		- $sla = $slas->sla_data($ticket['sla']);
76		- $documenteddate = $ticket['documenteddate'];
77		- $resolutiontime = $sla['resolutiontime'];
78		- $slawarning = $sla['slawarning'];
79		- $slagoaltime = strtotime("+$resolutiontime hours", $documenteddate);
80		- $slawarningtime = strtotime("+$slawarning hours", $documenteddate);
81		- if ($currenttime > $slagoaltime) {
82		- $slabgcolor = '#FF0000';
83		- $slatxtcolor = '#ffffff';
84		- } elseif ($currenttime >= $slawarningtime) {
85		- $slabgcolor = '#FFFF00';
86		- $slatxtcolor = '#000000';
87		- } else {
88		- $slabgcolor = '#00FF00';
89		- $slatxtcolor = '#000000';
90		- }
91		- $customer = $customers->customer_data($ticket['idcustomer']);
92		- $user = $users->userdata($ticket['assignee']);
93		- echo '<tr><td><a href=ticketedit.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
94		- '<td style="background-color:'.$slabgcolor.';color:'.$slatxtcolor.';">'.$sla['namasla'].'</td>'.
95		- '<td>'.date('d-M-Y H:i:s', $slagoaltime).'</td>'.
96		- '<td>'.$customer['namacustomer'].'</td>'.
97		- '<td>'.date('d-M-Y H:i:s', $ticket['reporteddate']).'</td>'.
98		- '<td>'.date('d-M-Y H:i:s', $ticket['documenteddate']).'</td>'.
99		- '<td>'.$ticket['problemsummary'].'</td>'.
100		- '<td>'.$ticket['ticketstatus'].'</td>'.
101		- '<td>'.$user['fullname'].'</td>'.
102		- '<td><a href=ticketdel.php?id='.$ticket['id'].' onclick="return delete_confirm();">del</a></td></tr>';
103		- }
104		- ?>
	74	+ foreach ($ticket_list as $ticket) {
	75	+ $sla = $slas->sla_data($ticket['sla']);
	76	+ $documenteddate = $ticket['documenteddate'];
	77	+ $resolutiontime = $sla['resolutiontime'];
	78	+ $slawarning = $sla['slawarning'];
	79	+ $slagoaltime = strtotime("+$resolutiontime hours", $documenteddate);
	80	+ $slawarningtime = strtotime("+$slawarning hours", $documenteddate);
	81	+ if ($currenttime > $slagoaltime) {
	82	+ $slabgcolor = '#FF0000';
	83	+ $slatxtcolor = '#ffffff';
	84	+ } elseif ($currenttime >= $slawarningtime) {
	85	+ $slabgcolor = '#FFFF00';
	86	+ $slatxtcolor = '#000000';
	87	+ } else {
	88	+ $slabgcolor = '#00FF00';
	89	+ $slatxtcolor = '#000000';
	90	+ }
	91	+ $customer = $customers->customer_data($ticket['idcustomer']);
	92	+ $user = $users->userdata($ticket['assignee']);
	93	+ echo '<tr><td><a href=ticketedit.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
	94	+ '<td style="background-color:'.$slabgcolor.';color:'.$slatxtcolor.';">'.$sla['namasla'].'</td>'.
	95	+ '<td>'.date('d-M-Y H:i:s', $slagoaltime).'</td>'.
	96	+ '<td>'.$customer['namacustomer'].'</td>'.
	97	+ '<td>'.date('d-M-Y H:i:s', $ticket['reporteddate']).'</td>'.
	98	+ '<td>'.date('d-M-Y H:i:s', $ticket['documenteddate']).'</td>'.
	99	+ '<td>'.$ticket['problemsummary'].'</td>'.
	100	+ '<td>'.$ticket['ticketstatus'].'</td>'.
	101	+ '<td>'.$user['fullname'].'</td>'.
	102	+ '<td><a href=ticketdel.php?id='.$ticket['id'].' onclick="return delete_confirm();">del</a></td></tr>';
	103	+ }
	104	+ ?>
105	105	</tbody>
106	106	</table>
107	107	<p> </p>

		@@ -5,7 +5,7 @@ discard block
		block discarded – undo
5	5	$user = $users->userdata($_SESSION['loginid']);
6	6	if ($user['level'] == 'Admin' \|\| $user['level'] == 'Manager') {
7	7	$akses = true;
8		-} else {
	8	+}else {
9	9	$akses = false;
10	10	}
11	11	if ($akses = false) {
		@@ -78,7 +78,7 @@ discard block
		block discarded – undo
78	78	} elseif ($currenttime >= $slawarningtime) {
79	79	$slabgcolor = '#FFFF00';
80	80	$slatxtcolor = '#000000';
81		- } else {
	81	+ }else {
82	82	$slabgcolor = '#00FF00';
83	83	$slatxtcolor = '#000000';
84	84	}

		@@ -3,7 +3,7 @@ discard block
		block discarded – undo
3	3	$general->logged_out_protect();
4	4	$user = $users->userdata($_SESSION['loginid']);
5	5	if ($user['level'] != 'Admin') {
6		- exit("You don't have permission to access this page!");
	6	+ exit("You don't have permission to access this page!");
7	7	}
8	8	$sla = $slas->get_sla();
9	9	?>
		@@ -58,15 +58,15 @@ discard block
		block discarded – undo
58	58	</thead>
59	59	<tbody>
60	60	<?php
61		- foreach ($sla as $slaval) {
62		- echo '<tr><td>'.$slaval['slaid'].'</td>'.
63		- '<td><a href=slaedit.php?id='.$slaval['slaid'].'>'.$slaval['namasla'].'</a></td>'.
64		- '<td>'.$slaval['responsetime'].' Hours</td>'.
65		- '<td>'.$slaval['resolutiontime'].' Hours</td>'.
66		- '<td>'.$slaval['slawarning'].' Hours</td>'.
67		- '<td><a href=sladel.php?id='.$slaval['slaid'].' onclick="return delete_confirm();">del</a></td></tr>';
68		- }
69		- ?>
	61	+ foreach ($sla as $slaval) {
	62	+ echo '<tr><td>'.$slaval['slaid'].'</td>'.
	63	+ '<td><a href=slaedit.php?id='.$slaval['slaid'].'>'.$slaval['namasla'].'</a></td>'.
	64	+ '<td>'.$slaval['responsetime'].' Hours</td>'.
	65	+ '<td>'.$slaval['resolutiontime'].' Hours</td>'.
	66	+ '<td>'.$slaval['slawarning'].' Hours</td>'.
	67	+ '<td><a href=sladel.php?id='.$slaval['slaid'].' onclick="return delete_confirm();">del</a></td></tr>';
	68	+ }
	69	+ ?>
70	70	</tbody>
71	71	</table>
72	72	</div>

		@@ -5,24 +5,24 @@
		block discarded – undo
5	5	$emailstatus = 'New';
6	6	$new_emails = $emails->get_email_by_status($emailstatus);
7	7	foreach ($new_emails as $new_email) {
8		- $idemail = $new_email['idemail'];
9		- $to = $new_email['emailto'];
10		- $cc = substr($new_email['emailcc'], 0, -2);
11		- $subject = $new_email['emailsubject'];
12		- $message = $new_email['message'];
	8	+ $idemail = $new_email['idemail'];
	9	+ $to = $new_email['emailto'];
	10	+ $cc = substr($new_email['emailcc'], 0, -2);
	11	+ $subject = $new_email['emailsubject'];
	12	+ $message = $new_email['message'];
13	13
14		- $headers = [];
15		- $headers[] = 'MIME-Version: 1.0';
16		- $headers[] = 'Content-type: text/plain; charset=iso-8859-1';
17		- $headers[] = 'From: Helpdesk System <[email protected]>';
18		- $headers[] = "Cc: $cc";
19		- $headers[] = 'Bcc:';
20		- $headers[] = 'Reply-To: Helpdesk System <[email protected]>';
21		- $headers[] = 'X-Mailer: PHP/'.phpversion();
22		- $ok = mail($to, $subject, $message, implode("\r\n", $headers));
23		- if ($ok) {
24		- $emails->update_status_email($idemail, 'Sent');
25		- } else {
26		- $emails->update_status_email($idemail, 'Cannot Send');
27		- }
	14	+ $headers = [];
	15	+ $headers[] = 'MIME-Version: 1.0';
	16	+ $headers[] = 'Content-type: text/plain; charset=iso-8859-1';
	17	+ $headers[] = 'From: Helpdesk System <[email protected]>';
	18	+ $headers[] = "Cc: $cc";
	19	+ $headers[] = 'Bcc:';
	20	+ $headers[] = 'Reply-To: Helpdesk System <[email protected]>';
	21	+ $headers[] = 'X-Mailer: PHP/'.phpversion();
	22	+ $ok = mail($to, $subject, $message, implode("\r\n", $headers));
	23	+ if ($ok) {
	24	+ $emails->update_status_email($idemail, 'Sent');
	25	+ } else {
	26	+ $emails->update_status_email($idemail, 'Cannot Send');
	27	+ }
28	28	}

		@@ -22,7 +22,7 @@
		block discarded – undo
22	22	$ok = mail($to, $subject, $message, implode("\r\n", $headers));
23	23	if ($ok) {
24	24	$emails->update_status_email($idemail, 'Sent');
25		- } else {
	25	+ }else {
26	26	$emails->update_status_email($idemail, 'Cannot Send');
27	27	}
28	28	}

		@@ -4,22 +4,22 @@
		block discarded – undo
4	4	//$general->logged_out_protect();
5	5	$sla_emails = $emails->get_email_sla_remainder();
6	6	foreach ($sla_emails as $sla_email) {
7		- $idemail = $sla_email['idemail'];
8		- $to = $sla_email['emailto'];
9		- $cc = substr($sla_email['emailcc'], 0, -2);
10		- $subject = $sla_email['emailsubject'];
11		- $message = $sla_email['message'];
	7	+ $idemail = $sla_email['idemail'];
	8	+ $to = $sla_email['emailto'];
	9	+ $cc = substr($sla_email['emailcc'], 0, -2);
	10	+ $subject = $sla_email['emailsubject'];
	11	+ $message = $sla_email['message'];
12	12
13		- $headers = [];
14		- $headers[] = 'MIME-Version: 1.0';
15		- $headers[] = 'Content-type: text/plain; charset=iso-8859-1';
16		- $headers[] = 'From: Helpdesk System <[email protected]>';
17		- $headers[] = "Cc:$cc";
18		- $headers[] = 'Bcc:';
19		- $headers[] = 'Reply-To: Helpdesk System <[email protected]>';
20		- $headers[] = 'X-Mailer: PHP/'.phpversion();
21		- echo $idemail.'<br>';
22		- /*
	13	+ $headers = [];
	14	+ $headers[] = 'MIME-Version: 1.0';
	15	+ $headers[] = 'Content-type: text/plain; charset=iso-8859-1';
	16	+ $headers[] = 'From: Helpdesk System <[email protected]>';
	17	+ $headers[] = "Cc:$cc";
	18	+ $headers[] = 'Bcc:';
	19	+ $headers[] = 'Reply-To: Helpdesk System <[email protected]>';
	20	+ $headers[] = 'X-Mailer: PHP/'.phpversion();
	21	+ echo $idemail.'<br>';
	22	+ /*
23	23	$ok = mail($to, $subject, $message, implode("\r\n", $headers));
24	24	if ($ok)
25	25	{ $emails->update_status_email($idemail,"Sent");

aepnat / simhelpdesk

Push — master ( ce6199...f8d49f )

Status

Category

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +34 added lines, -34 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +19 added lines, -19 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch