Inspection of "Apply fixes from StyleCI" - aepnat/simhelpdesk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

by Saepul

created 2018-12-01 15:04 UTC

Status

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -4,28 +4,28 @@  discard block
 block discarded – undo
 require 'core/init.php';
 $general->logged_out_protect();
 if (isset($_POST['submit'])) {
-    $projectname = $_POST['projectname'];
-    $idcustomer = $_POST['idcustomer'];
+	$projectname = $_POST['projectname'];
+	$idcustomer = $_POST['idcustomer'];
 
-    $deliverybegin = strtotime($_POST['deliverybegin']);
-    $deliveryend = strtotime($_POST['deliveryend']);
+	$deliverybegin = strtotime($_POST['deliverybegin']);
+	$deliveryend = strtotime($_POST['deliveryend']);
 
-    $installbegin = strtotime($_POST['installbegin']);
-    $installend = strtotime($_POST['installend']);
+	$installbegin = strtotime($_POST['installbegin']);
+	$installend = strtotime($_POST['installend']);
 
-    $uatbegin = strtotime($_POST['uatbegin']);
-    $uatend = strtotime($_POST['uatend']);
+	$uatbegin = strtotime($_POST['uatbegin']);
+	$uatend = strtotime($_POST['uatend']);
 
-    $billstartdate = strtotime($_POST['billstartdate']);
-    $billduedate = strtotime($_POST['billduedate']);
+	$billstartdate = strtotime($_POST['billstartdate']);
+	$billduedate = strtotime($_POST['billduedate']);
 
-    $warrantyperiod = $_POST['warrantyperiod'];
+	$warrantyperiod = $_POST['warrantyperiod'];
 
-    $contractstartdate = strtotime($_POST['contractstartdate']);
-    $contractperiod = $_POST['contractperiod'];
+	$contractstartdate = strtotime($_POST['contractstartdate']);
+	$contractperiod = $_POST['contractperiod'];
 
-    $projects->add_project($projectname, $idcustomer, $deliverybegin, $deliveryend, $installbegin, $installend, $uatbegin, $uatend, $billstartdate, $billduedate, $warrantyperiod, $contractstartdate, $contractperiod);
-    header('location: projectlist.php');
+	$projects->add_project($projectname, $idcustomer, $deliverybegin, $deliveryend, $installbegin, $installend, $uatbegin, $uatend, $billstartdate, $billduedate, $warrantyperiod, $contractstartdate, $contractperiod);
+	header('location: projectlist.php');
 }
 ?>
 <!DOCTYPE HTML>
@@ -75,13 +75,13 @@  discard block
 block discarded – undo
 			<td> Customer : </td>
 			<td> 
 			<?php
-                $customers = $customers->get_customers();
-                echo '<select name="idcustomer">';
-                foreach ($customers as $customerval) {
-                    echo '<option value='.$customerval['idcustomer'].'>'.$customerval['namacustomer'].'</option>';
-                }
-                echo '</select>';
-            ?>
+				$customers = $customers->get_customers();
+				echo '<select name="idcustomer">';
+				foreach ($customers as $customerval) {
+					echo '<option value='.$customerval['idcustomer'].'>'.$customerval['namacustomer'].'</option>';
+				}
+				echo '</select>';
+			?>
 			</td>
 		</tr>
 	</table><br/>
@@ -163,9 +163,9 @@  discard block
 block discarded – undo
 	</form>
 
 	<?php 
-    if (empty($errors) === false) {
-        echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
-    }
-    ?>
+	if (empty($errors) === false) {
+		echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
+	}
+	?>
 </body>
 </html>
\ No newline at end of file

Please login to merge, or discard this patch.

projectedit.php 1 patch

Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

@@ -6,25 +6,25 @@  discard block
 block discarded – undo
 $idcustomer = $project['idcustomer'];
 $cust = $customers->customer_data($idcustomer);
 if (isset($_POST['submit'])) {
-    $deliverybegin = strtotime($_POST['deliverybegin']);
-    $deliveryend = strtotime($_POST['deliveryend']);
+	$deliverybegin = strtotime($_POST['deliverybegin']);
+	$deliveryend = strtotime($_POST['deliveryend']);
 
-    $installbegin = strtotime($_POST['installbegin']);
-    $installend = strtotime($_POST['installend']);
+	$installbegin = strtotime($_POST['installbegin']);
+	$installend = strtotime($_POST['installend']);
 
-    $uatbegin = strtotime($_POST['uatbegin']);
-    $uatend = strtotime($_POST['uatend']);
+	$uatbegin = strtotime($_POST['uatbegin']);
+	$uatend = strtotime($_POST['uatend']);
 
-    $billstartdate = strtotime($_POST['billstartdate']);
-    $billduedate = strtotime($_POST['billduedate']);
+	$billstartdate = strtotime($_POST['billstartdate']);
+	$billduedate = strtotime($_POST['billduedate']);
 
-    $warrantyperiod = $_POST['warrantyperiod'];
+	$warrantyperiod = $_POST['warrantyperiod'];
 
-    $contractstartdate = strtotime($_POST['contractstartdate']);
-    $contractperiod = $_POST['contractperiod'];
+	$contractstartdate = strtotime($_POST['contractstartdate']);
+	$contractperiod = $_POST['contractperiod'];
 
-    $projects->update_project($projectid, $projectname, $idcustomer, $deliverybegin, $deliveryend, $installbegin, $installend, $uatbegin, $uatend, $billstartdate, $billduedate, $warrantyperiod, $contractstartdate, $contractperiod);
-    header('location: projectlist.php?');
+	$projects->update_project($projectid, $projectname, $idcustomer, $deliverybegin, $deliveryend, $installbegin, $installend, $uatbegin, $uatend, $billstartdate, $billduedate, $warrantyperiod, $contractstartdate, $contractperiod);
+	header('location: projectlist.php?');
 }
 ?>
 <!DOCTYPE HTML>
@@ -80,11 +80,11 @@  discard block
 block discarded – undo
 			<td> <select name="idcustomer">
 					<option value='<?php echo $project['idcustomer']; ?>' selected="selected"> <?php echo $cust['namacustomer']; ?> </option>
 				<?php
-                    $customers = $customers->get_customers();
-                    foreach ($customers as $customerval) {
-                        echo '<option value='.$customerval['idcustomer'].'>'.$customerval['namacustomer'].'</option>';
-                    }
-                ?>
+					$customers = $customers->get_customers();
+					foreach ($customers as $customerval) {
+						echo '<option value='.$customerval['idcustomer'].'>'.$customerval['namacustomer'].'</option>';
+					}
+				?>
 				</select></td>
 		</tr>
 	</table><br/>
@@ -163,9 +163,9 @@  discard block
 block discarded – undo
 	</form>
 
 	<?php 
-    if (empty($errors) === false) {
-        echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
-    }
-    ?>
+	if (empty($errors) === false) {
+		echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
+	}
+	?>
 </body>
 </html>
\ No newline at end of file

Please login to merge, or discard this patch.

hdnewsedit.php 1 patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -4,16 +4,16 @@  discard block
 block discarded – undo
 $id = $_GET['id'];
 $thenews = $hdnews->news_data($id);
 if (isset($_POST['submit'])) {
-    $newsdate = strtotime($_POST['newsdate']);
-    $title = $_POST['title'];
-    $detail = $_POST['detail'];
-    $user = $users->userdata($_SESSION['loginid']);
-    $createdby = ucwords(strtolower($user['fullname']));
-    $createdon = strtotime(now);
-    $expired = strtotime($_POST['expireddate']);
+	$newsdate = strtotime($_POST['newsdate']);
+	$title = $_POST['title'];
+	$detail = $_POST['detail'];
+	$user = $users->userdata($_SESSION['loginid']);
+	$createdby = ucwords(strtolower($user['fullname']));
+	$createdon = strtotime(now);
+	$expired = strtotime($_POST['expireddate']);
 
-    $hdnews->update_news($id, $newsdate, $title, $detail, $createdby, $createdon, $expired);
-    header('Location: hdnews.php');
+	$hdnews->update_news($id, $newsdate, $title, $detail, $createdby, $createdon, $expired);
+	header('Location: hdnews.php');
 }
 ?>
 <!DOCTYPE HTML>
@@ -91,9 +91,9 @@  discard block
 block discarded – undo
 	</form>
 
 	<?php 
-    if (empty($errors) === false) {
-        echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
-    }
-    ?>
+	if (empty($errors) === false) {
+		echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
+	}
+	?>
 </body>
 </html>
\ No newline at end of file

Please login to merge, or discard this patch.

getcustomer.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -12,21 +12,21 @@
 block discarded – undo
 $contractstartdate = date('d-M-Y', $project['contractstartdate']);
 $contractenddate = date('d-M-Y', strtotime($contractstartdate.' + '.$contractperiod.' months'));
 if ($warrantyperiod == '') {
-    $warrantyperiod = 0;
-    $warrantystartdate = 0;
-    $warrantyenddate = 0;
+	$warrantyperiod = 0;
+	$warrantystartdate = 0;
+	$warrantyenddate = 0;
 }
 if ($contractperiod == '') {
-    $contractperiod = 0;
-    $contractstartdate = 0;
-    $contractenddate = 0;
+	$contractperiod = 0;
+	$contractstartdate = 0;
+	$contractenddate = 0;
 }
 $data_customer = ['customerproduct'=> $customer['customerproduct'],
-    'warrantyperiod'               => $warrantyperiod,
-    'warrantystartdate'            => $warrantystartdate,
-    'warrantyenddate'              => $warrantyenddate,
-    'contractperiod'               => $contractperiod,
-    'contractstartdate'            => $contractstartdate,
-    'contractenddate'              => $contractenddate,
+	'warrantyperiod'               => $warrantyperiod,
+	'warrantystartdate'            => $warrantystartdate,
+	'warrantyenddate'              => $warrantyenddate,
+	'contractperiod'               => $contractperiod,
+	'contractstartdate'            => $contractstartdate,
+	'contractenddate'              => $contractenddate,
 ];
 echo json_encode($data_customer);

Please login to merge, or discard this patch.

navigator.php 1 patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -29,15 +29,15 @@
 block discarded – undo
 </ul>
 </div>
 <?php
-    if ($user['level'] == 'Manager' || $user['level'] == 'Admin') {
-        echo '<div id="leftmenu">
+	if ($user['level'] == 'Manager' || $user['level'] == 'Admin') {
+		echo '<div id="leftmenu">
 				<div id="headleftmenu">Helpdesk Statistic</div>
 					<ul>
 					<li><a href="pivot/hdpivot.php" target="contentFrame">Pivot Table</a></li>
 					<li><a href="statistic/chart.php" target="contentFrame">SLA Chart</a></li>
 					</ul>
 			 </div>';
-    }
+	}
 ?>
 </body>
 </html>

Please login to merge, or discard this patch.

slaedit.php 1 patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -3,17 +3,17 @@  discard block
 block discarded – undo
 $general->logged_out_protect();
 $user = $users->userdata($_SESSION['loginid']);
 if ($user['level'] != 'Admin') {
-    exit("You don't have permission to access this page!");
+	exit("You don't have permission to access this page!");
 }
 $slaid = $_GET['id'];
 $sla = $slas->sla_data($slaid);
 if (isset($_POST['submit'])) {
-    $namasla = $_POST['namasla'];
-    $responsetime = $_POST['responsetime'];
-    $resolutiontime = $_POST['resolutiontime'];
-    $slawarning = $_POST['slawarning'];
-    $slas->update_sla($slaid, $namasla, $responsetime, $resolutiontime, $slawarning);
-    header('location:slalist.php');
+	$namasla = $_POST['namasla'];
+	$responsetime = $_POST['responsetime'];
+	$resolutiontime = $_POST['resolutiontime'];
+	$slawarning = $_POST['slawarning'];
+	$slas->update_sla($slaid, $namasla, $responsetime, $resolutiontime, $slawarning);
+	header('location:slalist.php');
 }
 ?>
 <!DOCTYPE HTML>
@@ -92,9 +92,9 @@  discard block
 block discarded – undo
 	</fieldset>
 	</form>
 	<?php 
-    if (empty($errors) === false) {
-        echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
-    }
-    ?>
+	if (empty($errors) === false) {
+		echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
+	}
+	?>
 </body>
 </html>
\ No newline at end of file

Please login to merge, or discard this patch.

userlist.php 1 patch

Indentation +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -3,7 +3,7 @@  discard block
 block discarded – undo
 $general->logged_out_protect();
 $user = $users->userdata($_SESSION['loginid']);
 if ($user['level'] != 'Admin') {
-    exit("You don't have permission to access this page!");
+	exit("You don't have permission to access this page!");
 }
 $members = $users->get_users();
 $member_count = count($members);
@@ -61,22 +61,22 @@  discard block
 block discarded – undo
     </thead>
     <tbody>
 		<?php 
-        foreach ($members as $member) {
-            if ($member['confirmed'] == '1') {
-                $locked = 'No';
-            } else {
-                $locked = 'Yes';
-            }
-            echo '<tr><td><a href=useredit.php?id='.$member['id'].'>'.$member['username'].'</a></td>'.
-                 '<td>'.$member['level'].'</td>'.
-                 '<td>'.$member['fullname'].'</td>'.
-                 '<td>'.$member['email'].'</td>'.
-                 '<td>'.$member['Telp'].'</td>'.
-                 '<td>'.date('d-M-Y H:i', $member['time']).'</td>'.
-                 '<td>'.$locked.'</td>'.
-                 '<td><a href=userdel.php?id='.$member['id'].' onclick="return delete_confirm();">del</a></td></tr>';
-        }
-        ?>
+		foreach ($members as $member) {
+			if ($member['confirmed'] == '1') {
+				$locked = 'No';
+			} else {
+				$locked = 'Yes';
+			}
+			echo '<tr><td><a href=useredit.php?id='.$member['id'].'>'.$member['username'].'</a></td>'.
+				 '<td>'.$member['level'].'</td>'.
+				 '<td>'.$member['fullname'].'</td>'.
+				 '<td>'.$member['email'].'</td>'.
+				 '<td>'.$member['Telp'].'</td>'.
+				 '<td>'.date('d-M-Y H:i', $member['time']).'</td>'.
+				 '<td>'.$locked.'</td>'.
+				 '<td><a href=userdel.php?id='.$member['id'].' onclick="return delete_confirm();">del</a></td></tr>';
+		}
+		?>
     </tbody>
 	</table>
 	<p>&nbsp;</p>

Please login to merge, or discard this patch.

myticketbyresolver.php 1 patch

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -51,20 +51,20 @@
 block discarded – undo
     </thead>
     <tbody>
 		<?php 
-        foreach ($tickets as $ticket) {
-            $sla = $slas->sla_data($ticket['sla']);
-            $customer = $customers->customer_data($ticket['idcustomer']);
-            $user = $users->userdata($ticket['assignee']);
-            echo '<tr><td><a href=ticketedit.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
-                 '<td>'.$sla['namasla'].'</td>'.
-                 '<td>'.$customer['namacustomer'].'</td>'.
-                 '<td>'.date('d-M-Y', $ticket['reporteddate']).'</td>'.
-                 '<td>'.$ticket['reportedby'].'</td>'.
-                 '<td>'.$ticket['problemsummary'].'</td>'.
-                 '<td>'.$ticket['ticketstatus'].'</td>'.
-                 '<td>'.$user['fullname'].'</td></tr>';
-        }
-        ?>
+		foreach ($tickets as $ticket) {
+			$sla = $slas->sla_data($ticket['sla']);
+			$customer = $customers->customer_data($ticket['idcustomer']);
+			$user = $users->userdata($ticket['assignee']);
+			echo '<tr><td><a href=ticketedit.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
+				 '<td>'.$sla['namasla'].'</td>'.
+				 '<td>'.$customer['namacustomer'].'</td>'.
+				 '<td>'.date('d-M-Y', $ticket['reporteddate']).'</td>'.
+				 '<td>'.$ticket['reportedby'].'</td>'.
+				 '<td>'.$ticket['problemsummary'].'</td>'.
+				 '<td>'.$ticket['ticketstatus'].'</td>'.
+				 '<td>'.$user['fullname'].'</td></tr>';
+		}
+		?>
     </tbody>
 	</table>
 	<p>&nbsp;</p>

Please login to merge, or discard this patch.

ticketlistuser.php 1 patch

Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

@@ -4,12 +4,12 @@  discard block
 block discarded – undo
 $general->logged_out_protect();
 $user = $users->userdata($_SESSION['loginid']);
 if ($user['level'] == 'Admin' || $user['level'] == 'Manager') {
-    $akses = true;
+	$akses = true;
 } else {
-    $akses = false;
+	$akses = false;
 }
 if ($akses = false) {
-    exit("You don't have permission to access this page!");
+	exit("You don't have permission to access this page!");
 }
 $tickets = $tickets->get_opened_tickets();
 $tickets_count = count($tickets);
@@ -64,36 +64,36 @@  discard block
 block discarded – undo
     </thead>
     <tbody>
 		<?php 
-        $currenttime = time();
-        foreach ($tickets as $ticket) {
-            $sla = $slas->sla_data($ticket['sla']);
-            $documenteddate = $ticket['documenteddate'];
-            $resolutiontime = $sla['resolutiontime'];
-            $slawarning = $sla['slawarning'];
-            $slagoaltime = strtotime("+$resolutiontime hours", $documenteddate);
-            $slawarningtime = strtotime("+$slawarning hours", $documenteddate);
-            if ($currenttime > $slagoaltime) {
-                $slabgcolor = '#FF0000';
-                $slatxtcolor = '#ffffff';
-            } elseif ($currenttime >= $slawarningtime) {
-                $slabgcolor = '#FFFF00';
-                $slatxtcolor = '#000000';
-            } else {
-                $slabgcolor = '#00FF00';
-                $slatxtcolor = '#000000';
-            }
-            $customer = $customers->customer_data($ticket['idcustomer']);
-            $user = $users->userdata($ticket['assignee']);
-            echo '<tr><td><a href=ticketedituser.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
-                 '<td style="background-color:'.$slabgcolor.';color:'.$slatxtcolor.';">'.$sla['namasla'].'</td>'.
-                 '<td>'.$customer['namacustomer'].'</td>'.
-                 '<td>'.date('d-M-Y H:i', $ticket['reporteddate']).'</td>'.
-                 '<td>'.$ticket['reportedby'].'</td>'.
-                 '<td>'.$ticket['problemsummary'].'</td>'.
-                 '<td>'.$ticket['ticketstatus'].'</td>'.
-                 '<td>'.$user['fullname'].'</td></tr>';
-        }
-        ?>
+		$currenttime = time();
+		foreach ($tickets as $ticket) {
+			$sla = $slas->sla_data($ticket['sla']);
+			$documenteddate = $ticket['documenteddate'];
+			$resolutiontime = $sla['resolutiontime'];
+			$slawarning = $sla['slawarning'];
+			$slagoaltime = strtotime("+$resolutiontime hours", $documenteddate);
+			$slawarningtime = strtotime("+$slawarning hours", $documenteddate);
+			if ($currenttime > $slagoaltime) {
+				$slabgcolor = '#FF0000';
+				$slatxtcolor = '#ffffff';
+			} elseif ($currenttime >= $slawarningtime) {
+				$slabgcolor = '#FFFF00';
+				$slatxtcolor = '#000000';
+			} else {
+				$slabgcolor = '#00FF00';
+				$slatxtcolor = '#000000';
+			}
+			$customer = $customers->customer_data($ticket['idcustomer']);
+			$user = $users->userdata($ticket['assignee']);
+			echo '<tr><td><a href=ticketedituser.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
+				 '<td style="background-color:'.$slabgcolor.';color:'.$slatxtcolor.';">'.$sla['namasla'].'</td>'.
+				 '<td>'.$customer['namacustomer'].'</td>'.
+				 '<td>'.date('d-M-Y H:i', $ticket['reporteddate']).'</td>'.
+				 '<td>'.$ticket['reportedby'].'</td>'.
+				 '<td>'.$ticket['problemsummary'].'</td>'.
+				 '<td>'.$ticket['ticketstatus'].'</td>'.
+				 '<td>'.$user['fullname'].'</td></tr>';
+		}
+		?>
     </tbody>
 	</table>
 </body>

Please login to merge, or discard this patch.

		@@ -4,28 +4,28 @@ discard block
		block discarded – undo
4	4	require 'core/init.php';
5	5	$general->logged_out_protect();
6	6	if (isset($_POST['submit'])) {
7		- $projectname = $_POST['projectname'];
8		- $idcustomer = $_POST['idcustomer'];
	7	+ $projectname = $_POST['projectname'];
	8	+ $idcustomer = $_POST['idcustomer'];
9	9
10		- $deliverybegin = strtotime($_POST['deliverybegin']);
11		- $deliveryend = strtotime($_POST['deliveryend']);
	10	+ $deliverybegin = strtotime($_POST['deliverybegin']);
	11	+ $deliveryend = strtotime($_POST['deliveryend']);
12	12
13		- $installbegin = strtotime($_POST['installbegin']);
14		- $installend = strtotime($_POST['installend']);
	13	+ $installbegin = strtotime($_POST['installbegin']);
	14	+ $installend = strtotime($_POST['installend']);
15	15
16		- $uatbegin = strtotime($_POST['uatbegin']);
17		- $uatend = strtotime($_POST['uatend']);
	16	+ $uatbegin = strtotime($_POST['uatbegin']);
	17	+ $uatend = strtotime($_POST['uatend']);
18	18
19		- $billstartdate = strtotime($_POST['billstartdate']);
20		- $billduedate = strtotime($_POST['billduedate']);
	19	+ $billstartdate = strtotime($_POST['billstartdate']);
	20	+ $billduedate = strtotime($_POST['billduedate']);
21	21
22		- $warrantyperiod = $_POST['warrantyperiod'];
	22	+ $warrantyperiod = $_POST['warrantyperiod'];
23	23
24		- $contractstartdate = strtotime($_POST['contractstartdate']);
25		- $contractperiod = $_POST['contractperiod'];
	24	+ $contractstartdate = strtotime($_POST['contractstartdate']);
	25	+ $contractperiod = $_POST['contractperiod'];
26	26
27		- $projects->add_project($projectname, $idcustomer, $deliverybegin, $deliveryend, $installbegin, $installend, $uatbegin, $uatend, $billstartdate, $billduedate, $warrantyperiod, $contractstartdate, $contractperiod);
28		- header('location: projectlist.php');
	27	+ $projects->add_project($projectname, $idcustomer, $deliverybegin, $deliveryend, $installbegin, $installend, $uatbegin, $uatend, $billstartdate, $billduedate, $warrantyperiod, $contractstartdate, $contractperiod);
	28	+ header('location: projectlist.php');
29	29	}
30	30	?>
31	31	<!DOCTYPE HTML>
		@@ -75,13 +75,13 @@ discard block
		block discarded – undo
75	75	<td> Customer : </td>
76	76	<td>
77	77	<?php
78		- $customers = $customers->get_customers();
79		- echo '<select name="idcustomer">';
80		- foreach ($customers as $customerval) {
81		- echo '<option value='.$customerval['idcustomer'].'>'.$customerval['namacustomer'].'</option>';
82		- }
83		- echo '</select>';
84		- ?>
	78	+ $customers = $customers->get_customers();
	79	+ echo '<select name="idcustomer">';
	80	+ foreach ($customers as $customerval) {
	81	+ echo '<option value='.$customerval['idcustomer'].'>'.$customerval['namacustomer'].'</option>';
	82	+ }
	83	+ echo '</select>';
	84	+ ?>
85	85	</td>
86	86	</tr>
87	87	</table><br/>
		@@ -163,9 +163,9 @@ discard block
		block discarded – undo
163	163	</form>
164	164
165	165	<?php
166		- if (empty($errors) === false) {
167		- echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
168		- }
169		- ?>
	166	+ if (empty($errors) === false) {
	167	+ echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
	168	+ }
	169	+ ?>
170	170	</body>
171	171	</html>
172	172	\ No newline at end of file

		@@ -6,25 +6,25 @@ discard block
		block discarded – undo
6	6	$idcustomer = $project['idcustomer'];
7	7	$cust = $customers->customer_data($idcustomer);
8	8	if (isset($_POST['submit'])) {
9		- $deliverybegin = strtotime($_POST['deliverybegin']);
10		- $deliveryend = strtotime($_POST['deliveryend']);
	9	+ $deliverybegin = strtotime($_POST['deliverybegin']);
	10	+ $deliveryend = strtotime($_POST['deliveryend']);
11	11
12		- $installbegin = strtotime($_POST['installbegin']);
13		- $installend = strtotime($_POST['installend']);
	12	+ $installbegin = strtotime($_POST['installbegin']);
	13	+ $installend = strtotime($_POST['installend']);
14	14
15		- $uatbegin = strtotime($_POST['uatbegin']);
16		- $uatend = strtotime($_POST['uatend']);
	15	+ $uatbegin = strtotime($_POST['uatbegin']);
	16	+ $uatend = strtotime($_POST['uatend']);
17	17
18		- $billstartdate = strtotime($_POST['billstartdate']);
19		- $billduedate = strtotime($_POST['billduedate']);
	18	+ $billstartdate = strtotime($_POST['billstartdate']);
	19	+ $billduedate = strtotime($_POST['billduedate']);
20	20
21		- $warrantyperiod = $_POST['warrantyperiod'];
	21	+ $warrantyperiod = $_POST['warrantyperiod'];
22	22
23		- $contractstartdate = strtotime($_POST['contractstartdate']);
24		- $contractperiod = $_POST['contractperiod'];
	23	+ $contractstartdate = strtotime($_POST['contractstartdate']);
	24	+ $contractperiod = $_POST['contractperiod'];
25	25
26		- $projects->update_project($projectid, $projectname, $idcustomer, $deliverybegin, $deliveryend, $installbegin, $installend, $uatbegin, $uatend, $billstartdate, $billduedate, $warrantyperiod, $contractstartdate, $contractperiod);
27		- header('location: projectlist.php?');
	26	+ $projects->update_project($projectid, $projectname, $idcustomer, $deliverybegin, $deliveryend, $installbegin, $installend, $uatbegin, $uatend, $billstartdate, $billduedate, $warrantyperiod, $contractstartdate, $contractperiod);
	27	+ header('location: projectlist.php?');
28	28	}
29	29	?>
30	30	<!DOCTYPE HTML>
		@@ -80,11 +80,11 @@ discard block
		block discarded – undo
80	80	<td> <select name="idcustomer">
81	81	<option value='<?php echo $project['idcustomer']; ?>' selected="selected"> <?php echo $cust['namacustomer']; ?> </option>
82	82	<?php
83		- $customers = $customers->get_customers();
84		- foreach ($customers as $customerval) {
85		- echo '<option value='.$customerval['idcustomer'].'>'.$customerval['namacustomer'].'</option>';
86		- }
87		- ?>
	83	+ $customers = $customers->get_customers();
	84	+ foreach ($customers as $customerval) {
	85	+ echo '<option value='.$customerval['idcustomer'].'>'.$customerval['namacustomer'].'</option>';
	86	+ }
	87	+ ?>
88	88	</select></td>
89	89	</tr>
90	90	</table><br/>
		@@ -163,9 +163,9 @@ discard block
		block discarded – undo
163	163	</form>
164	164
165	165	<?php
166		- if (empty($errors) === false) {
167		- echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
168		- }
169		- ?>
	166	+ if (empty($errors) === false) {
	167	+ echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
	168	+ }
	169	+ ?>
170	170	</body>
171	171	</html>
172	172	\ No newline at end of file

		@@ -4,16 +4,16 @@ discard block
		block discarded – undo
4	4	$id = $_GET['id'];
5	5	$thenews = $hdnews->news_data($id);
6	6	if (isset($_POST['submit'])) {
7		- $newsdate = strtotime($_POST['newsdate']);
8		- $title = $_POST['title'];
9		- $detail = $_POST['detail'];
10		- $user = $users->userdata($_SESSION['loginid']);
11		- $createdby = ucwords(strtolower($user['fullname']));
12		- $createdon = strtotime(now);
13		- $expired = strtotime($_POST['expireddate']);
	7	+ $newsdate = strtotime($_POST['newsdate']);
	8	+ $title = $_POST['title'];
	9	+ $detail = $_POST['detail'];
	10	+ $user = $users->userdata($_SESSION['loginid']);
	11	+ $createdby = ucwords(strtolower($user['fullname']));
	12	+ $createdon = strtotime(now);
	13	+ $expired = strtotime($_POST['expireddate']);
14	14
15		- $hdnews->update_news($id, $newsdate, $title, $detail, $createdby, $createdon, $expired);
16		- header('Location: hdnews.php');
	15	+ $hdnews->update_news($id, $newsdate, $title, $detail, $createdby, $createdon, $expired);
	16	+ header('Location: hdnews.php');
17	17	}
18	18	?>
19	19	<!DOCTYPE HTML>
		@@ -91,9 +91,9 @@ discard block
		block discarded – undo
91	91	</form>
92	92
93	93	<?php
94		- if (empty($errors) === false) {
95		- echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
96		- }
97		- ?>
	94	+ if (empty($errors) === false) {
	95	+ echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
	96	+ }
	97	+ ?>
98	98	</body>
99	99	</html>
100	100	\ No newline at end of file

		@@ -12,21 +12,21 @@
		block discarded – undo
12	12	$contractstartdate = date('d-M-Y', $project['contractstartdate']);
13	13	$contractenddate = date('d-M-Y', strtotime($contractstartdate.' + '.$contractperiod.' months'));
14	14	if ($warrantyperiod == '') {
15		- $warrantyperiod = 0;
16		- $warrantystartdate = 0;
17		- $warrantyenddate = 0;
	15	+ $warrantyperiod = 0;
	16	+ $warrantystartdate = 0;
	17	+ $warrantyenddate = 0;
18	18	}
19	19	if ($contractperiod == '') {
20		- $contractperiod = 0;
21		- $contractstartdate = 0;
22		- $contractenddate = 0;
	20	+ $contractperiod = 0;
	21	+ $contractstartdate = 0;
	22	+ $contractenddate = 0;
23	23	}
24	24	$data_customer = ['customerproduct'=> $customer['customerproduct'],
25		- 'warrantyperiod' => $warrantyperiod,
26		- 'warrantystartdate' => $warrantystartdate,
27		- 'warrantyenddate' => $warrantyenddate,
28		- 'contractperiod' => $contractperiod,
29		- 'contractstartdate' => $contractstartdate,
30		- 'contractenddate' => $contractenddate,
	25	+ 'warrantyperiod' => $warrantyperiod,
	26	+ 'warrantystartdate' => $warrantystartdate,
	27	+ 'warrantyenddate' => $warrantyenddate,
	28	+ 'contractperiod' => $contractperiod,
	29	+ 'contractstartdate' => $contractstartdate,
	30	+ 'contractenddate' => $contractenddate,
31	31	];
32	32	echo json_encode($data_customer);

		@@ -29,15 +29,15 @@
		block discarded – undo
29	29	</ul>
30	30	</div>
31	31	<?php
32		- if ($user['level'] == 'Manager' \|\| $user['level'] == 'Admin') {
33		- echo '<div id="leftmenu">
	32	+ if ($user['level'] == 'Manager' \|\| $user['level'] == 'Admin') {
	33	+ echo '<div id="leftmenu">
34	34	<div id="headleftmenu">Helpdesk Statistic</div>
35	35	<ul>
36	36	<li><a href="pivot/hdpivot.php" target="contentFrame">Pivot Table</a></li>
37	37	<li><a href="statistic/chart.php" target="contentFrame">SLA Chart</a></li>
38	38	</ul>
39	39	</div>';
40		- }
	40	+ }
41	41	?>
42	42	</body>
43	43	</html>

		@@ -3,17 +3,17 @@ discard block
		block discarded – undo
3	3	$general->logged_out_protect();
4	4	$user = $users->userdata($_SESSION['loginid']);
5	5	if ($user['level'] != 'Admin') {
6		- exit("You don't have permission to access this page!");
	6	+ exit("You don't have permission to access this page!");
7	7	}
8	8	$slaid = $_GET['id'];
9	9	$sla = $slas->sla_data($slaid);
10	10	if (isset($_POST['submit'])) {
11		- $namasla = $_POST['namasla'];
12		- $responsetime = $_POST['responsetime'];
13		- $resolutiontime = $_POST['resolutiontime'];
14		- $slawarning = $_POST['slawarning'];
15		- $slas->update_sla($slaid, $namasla, $responsetime, $resolutiontime, $slawarning);
16		- header('location:slalist.php');
	11	+ $namasla = $_POST['namasla'];
	12	+ $responsetime = $_POST['responsetime'];
	13	+ $resolutiontime = $_POST['resolutiontime'];
	14	+ $slawarning = $_POST['slawarning'];
	15	+ $slas->update_sla($slaid, $namasla, $responsetime, $resolutiontime, $slawarning);
	16	+ header('location:slalist.php');
17	17	}
18	18	?>
19	19	<!DOCTYPE HTML>
		@@ -92,9 +92,9 @@ discard block
		block discarded – undo
92	92	</fieldset>
93	93	</form>
94	94	<?php
95		- if (empty($errors) === false) {
96		- echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
97		- }
98		- ?>
	95	+ if (empty($errors) === false) {
	96	+ echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
	97	+ }
	98	+ ?>
99	99	</body>
100	100	</html>
101	101	\ No newline at end of file

		@@ -3,7 +3,7 @@ discard block
		block discarded – undo
3	3	$general->logged_out_protect();
4	4	$user = $users->userdata($_SESSION['loginid']);
5	5	if ($user['level'] != 'Admin') {
6		- exit("You don't have permission to access this page!");
	6	+ exit("You don't have permission to access this page!");
7	7	}
8	8	$members = $users->get_users();
9	9	$member_count = count($members);
		@@ -61,22 +61,22 @@ discard block
		block discarded – undo
61	61	</thead>
62	62	<tbody>
63	63	<?php
64		- foreach ($members as $member) {
65		- if ($member['confirmed'] == '1') {
66		- $locked = 'No';
67		- } else {
68		- $locked = 'Yes';
69		- }
70		- echo '<tr><td><a href=useredit.php?id='.$member['id'].'>'.$member['username'].'</a></td>'.
71		- '<td>'.$member['level'].'</td>'.
72		- '<td>'.$member['fullname'].'</td>'.
73		- '<td>'.$member['email'].'</td>'.
74		- '<td>'.$member['Telp'].'</td>'.
75		- '<td>'.date('d-M-Y H:i', $member['time']).'</td>'.
76		- '<td>'.$locked.'</td>'.
77		- '<td><a href=userdel.php?id='.$member['id'].' onclick="return delete_confirm();">del</a></td></tr>';
78		- }
79		- ?>
	64	+ foreach ($members as $member) {
	65	+ if ($member['confirmed'] == '1') {
	66	+ $locked = 'No';
	67	+ } else {
	68	+ $locked = 'Yes';
	69	+ }
	70	+ echo '<tr><td><a href=useredit.php?id='.$member['id'].'>'.$member['username'].'</a></td>'.
	71	+ '<td>'.$member['level'].'</td>'.
	72	+ '<td>'.$member['fullname'].'</td>'.
	73	+ '<td>'.$member['email'].'</td>'.
	74	+ '<td>'.$member['Telp'].'</td>'.
	75	+ '<td>'.date('d-M-Y H:i', $member['time']).'</td>'.
	76	+ '<td>'.$locked.'</td>'.
	77	+ '<td><a href=userdel.php?id='.$member['id'].' onclick="return delete_confirm();">del</a></td></tr>';
	78	+ }
	79	+ ?>
80	80	</tbody>
81	81	</table>
82	82	<p> </p>

		@@ -51,20 +51,20 @@
		block discarded – undo
51	51	</thead>
52	52	<tbody>
53	53	<?php
54		- foreach ($tickets as $ticket) {
55		- $sla = $slas->sla_data($ticket['sla']);
56		- $customer = $customers->customer_data($ticket['idcustomer']);
57		- $user = $users->userdata($ticket['assignee']);
58		- echo '<tr><td><a href=ticketedit.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
59		- '<td>'.$sla['namasla'].'</td>'.
60		- '<td>'.$customer['namacustomer'].'</td>'.
61		- '<td>'.date('d-M-Y', $ticket['reporteddate']).'</td>'.
62		- '<td>'.$ticket['reportedby'].'</td>'.
63		- '<td>'.$ticket['problemsummary'].'</td>'.
64		- '<td>'.$ticket['ticketstatus'].'</td>'.
65		- '<td>'.$user['fullname'].'</td></tr>';
66		- }
67		- ?>
	54	+ foreach ($tickets as $ticket) {
	55	+ $sla = $slas->sla_data($ticket['sla']);
	56	+ $customer = $customers->customer_data($ticket['idcustomer']);
	57	+ $user = $users->userdata($ticket['assignee']);
	58	+ echo '<tr><td><a href=ticketedit.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
	59	+ '<td>'.$sla['namasla'].'</td>'.
	60	+ '<td>'.$customer['namacustomer'].'</td>'.
	61	+ '<td>'.date('d-M-Y', $ticket['reporteddate']).'</td>'.
	62	+ '<td>'.$ticket['reportedby'].'</td>'.
	63	+ '<td>'.$ticket['problemsummary'].'</td>'.
	64	+ '<td>'.$ticket['ticketstatus'].'</td>'.
	65	+ '<td>'.$user['fullname'].'</td></tr>';
	66	+ }
	67	+ ?>
68	68	</tbody>
69	69	</table>
70	70	<p> </p>

		@@ -4,12 +4,12 @@ discard block
		block discarded – undo
4	4	$general->logged_out_protect();
5	5	$user = $users->userdata($_SESSION['loginid']);
6	6	if ($user['level'] == 'Admin' \|\| $user['level'] == 'Manager') {
7		- $akses = true;
	7	+ $akses = true;
8	8	} else {
9		- $akses = false;
	9	+ $akses = false;
10	10	}
11	11	if ($akses = false) {
12		- exit("You don't have permission to access this page!");
	12	+ exit("You don't have permission to access this page!");
13	13	}
14	14	$tickets = $tickets->get_opened_tickets();
15	15	$tickets_count = count($tickets);
		@@ -64,36 +64,36 @@ discard block
		block discarded – undo
64	64	</thead>
65	65	<tbody>
66	66	<?php
67		- $currenttime = time();
68		- foreach ($tickets as $ticket) {
69		- $sla = $slas->sla_data($ticket['sla']);
70		- $documenteddate = $ticket['documenteddate'];
71		- $resolutiontime = $sla['resolutiontime'];
72		- $slawarning = $sla['slawarning'];
73		- $slagoaltime = strtotime("+$resolutiontime hours", $documenteddate);
74		- $slawarningtime = strtotime("+$slawarning hours", $documenteddate);
75		- if ($currenttime > $slagoaltime) {
76		- $slabgcolor = '#FF0000';
77		- $slatxtcolor = '#ffffff';
78		- } elseif ($currenttime >= $slawarningtime) {
79		- $slabgcolor = '#FFFF00';
80		- $slatxtcolor = '#000000';
81		- } else {
82		- $slabgcolor = '#00FF00';
83		- $slatxtcolor = '#000000';
84		- }
85		- $customer = $customers->customer_data($ticket['idcustomer']);
86		- $user = $users->userdata($ticket['assignee']);
87		- echo '<tr><td><a href=ticketedituser.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
88		- '<td style="background-color:'.$slabgcolor.';color:'.$slatxtcolor.';">'.$sla['namasla'].'</td>'.
89		- '<td>'.$customer['namacustomer'].'</td>'.
90		- '<td>'.date('d-M-Y H:i', $ticket['reporteddate']).'</td>'.
91		- '<td>'.$ticket['reportedby'].'</td>'.
92		- '<td>'.$ticket['problemsummary'].'</td>'.
93		- '<td>'.$ticket['ticketstatus'].'</td>'.
94		- '<td>'.$user['fullname'].'</td></tr>';
95		- }
96		- ?>
	67	+ $currenttime = time();
	68	+ foreach ($tickets as $ticket) {
	69	+ $sla = $slas->sla_data($ticket['sla']);
	70	+ $documenteddate = $ticket['documenteddate'];
	71	+ $resolutiontime = $sla['resolutiontime'];
	72	+ $slawarning = $sla['slawarning'];
	73	+ $slagoaltime = strtotime("+$resolutiontime hours", $documenteddate);
	74	+ $slawarningtime = strtotime("+$slawarning hours", $documenteddate);
	75	+ if ($currenttime > $slagoaltime) {
	76	+ $slabgcolor = '#FF0000';
	77	+ $slatxtcolor = '#ffffff';
	78	+ } elseif ($currenttime >= $slawarningtime) {
	79	+ $slabgcolor = '#FFFF00';
	80	+ $slatxtcolor = '#000000';
	81	+ } else {
	82	+ $slabgcolor = '#00FF00';
	83	+ $slatxtcolor = '#000000';
	84	+ }
	85	+ $customer = $customers->customer_data($ticket['idcustomer']);
	86	+ $user = $users->userdata($ticket['assignee']);
	87	+ echo '<tr><td><a href=ticketedituser.php?id='.$ticket['id'].'>'.$ticket['ticketnumber'].'</a></td>'.
	88	+ '<td style="background-color:'.$slabgcolor.';color:'.$slatxtcolor.';">'.$sla['namasla'].'</td>'.
	89	+ '<td>'.$customer['namacustomer'].'</td>'.
	90	+ '<td>'.date('d-M-Y H:i', $ticket['reporteddate']).'</td>'.
	91	+ '<td>'.$ticket['reportedby'].'</td>'.
	92	+ '<td>'.$ticket['problemsummary'].'</td>'.
	93	+ '<td>'.$ticket['ticketstatus'].'</td>'.
	94	+ '<td>'.$user['fullname'].'</td></tr>';
	95	+ }
	96	+ ?>
97	97	</tbody>
98	98	</table>
99	99	</body>

aepnat / simhelpdesk

Pull Request — master (#1)

Status

Category

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

Indentation +17 added lines, -17 removed lines patch added patch discarded remove patch

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch