Issues in hdnewsedit.php - All Issues - Inspection of "Apply fixes from StyleCI" - aepnat/simhelpdesk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

by Saepul

created 2018-12-01 15:04 UTC

hdnewsedit.php (1 issue)

Labels

Bug 1

Severity

Major 1

<?php 
require 'core/init.php';
$general->logged_out_protect();
$id = $_GET['id'];
$thenews = $hdnews->news_data($id);
if (isset($_POST['submit'])) {
    $newsdate = strtotime($_POST['newsdate']);
    $title = $_POST['title'];
    $detail = $_POST['detail'];
    $user = $users->userdata($_SESSION['loginid']);
    $createdby = ucwords(strtolower($user['fullname']));
    $createdon = strtotime(now);

    $expired = strtotime($_POST['expireddate']);

    $hdnews->update_news($id, $newsdate, $title, $detail, $createdby, $createdon, $expired);
    header('Location: hdnews.php');
}
?>
<!DOCTYPE HTML>
<html>
<head>
	<title>Add Helpdesk News</title>
	<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
	<style type="text/css">
		body{font-size:12px;background-image:url('images/corner.jpg');background-repeat:no-repeat;background-attachment:fixed;font-family: Arial, Helvetica, sans-serif;}
		.breadcrumb{font-size:12px;color:#0000A0;}
		.formtable {font-size:12px;color:#000000; background-color:#f0f0f0;padding:10px;width:600px;}
		.errormsg {font-size:10pt;color:#ff0000;text-align:left;}
	</style>
	<link rel="stylesheet" href="css/jquery-ui.css" />
	<script type="text/javascript" src="js/jquery.js"></script>
	<script src="js/jquery-ui.js"></script>
	<script type="text/javascript"> 
		$(document).ready(function(){
			$("#newsdate,#expireddate").datepicker
			({dateFormat:"dd-M-yy",changeMonth:true,changeYear:true,});
		});
	</script>
	<script type="text/javascript">
	function cekData()
	{	if (newsform.title.value == "")
		{	alert("Headline News must be filled!");
			newsform.title.focus();
			return false;
		}
		if (newsform.detail.value == "")
		{	alert("Detail News must be filled!");
			newsform.detail.focus();
			return false;
		}
		else
			return true;   
	}
	</script>
</head>
<body>	
	<div class="breadcrumb"> >> Admin >> Helpdesk News >> Update News</div>
	<hr/>
	<form name="newsform" method="post" action="" onsubmit="return cekData();">
	<fieldset style="display: inline-block;">
	<legend> Update Helpdesk News </legend>
	<table class="formtable">
		<tr align="left">
			<td> News Date </td><td> : </td>
			<td><input type="text" id="newsdate" name="newsdate" readonly="readonly" value="<?php echo date('d-M-Y', $thenews['newsdate']); ?>">
			</td>
		</tr>
		<tr align="left">
			<td> Headline News</td><td> : </td>
			<td> <input type='text' size='70' name='title' maxlength="70" value="<?php echo $thenews['title']; ?>"> </td>
		</tr>
		<tr align="left">
			<td> News Detail </td><td> : </td>
			<td> <textarea name="detail" rows="3" cols="50"><?php echo $thenews['detail']; ?></textarea> </td>
		</tr>
		<tr align="left">
			<td> News Expired Date</td><td> : </td>
			<td><input type="text" id="expireddate" name="expireddate" readonly="readonly" value="<?php echo date('d-M-Y', $thenews['expired']); ?>">
			</td>
		</tr>
		<tr align="left">
			<td> </td>
			<td> </td>
			<td> <br/>
				<input type='submit' name='submit' value=' Update '>  &nbsp;&nbsp;&nbsp;
				<input type='reset' name='reset' value=' Reset '> 
			</td>
		</tr>
	</table>
	</fieldset>
	</form>

	<?php 
    if (empty($errors) === false) {
        echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
    }
    ?>
</body>
</html>

1			<?php
2			require 'core/init.php';
3			$general->logged_out_protect();
4			$id = $_GET['id'];
5			$thenews = $hdnews->news_data($id);
6			if (isset($_POST['submit'])) {
7			$newsdate = strtotime($_POST['newsdate']);
8			$title = $_POST['title'];
9			$detail = $_POST['detail'];
10			$user = $users->userdata($_SESSION['loginid']);
11			$createdby = ucwords(strtolower($user['fullname']));
12			$createdon = strtotime(now);
			0 ignored issues – show Bug introduced 2018-12-01 14:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `now` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
13			$expired = strtotime($_POST['expireddate']);
14
15			$hdnews->update_news($id, $newsdate, $title, $detail, $createdby, $createdon, $expired);
16			header('Location: hdnews.php');
17			}
18			?>
19			<!DOCTYPE HTML>
20			<html>
21			<head>
22			<title>Add Helpdesk News</title>
23			<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
24			<style type="text/css">
25			body{font-size:12px;background-image:url('images/corner.jpg');background-repeat:no-repeat;background-attachment:fixed;font-family: Arial, Helvetica, sans-serif;}
26			.breadcrumb{font-size:12px;color:#0000A0;}
27			.formtable {font-size:12px;color:#000000; background-color:#f0f0f0;padding:10px;width:600px;}
28			.errormsg {font-size:10pt;color:#ff0000;text-align:left;}
29			</style>
30			<link rel="stylesheet" href="css/jquery-ui.css" />
31			<script type="text/javascript" src="js/jquery.js"></script>
32			<script src="js/jquery-ui.js"></script>
33			<script type="text/javascript">
34			$(document).ready(function(){
35			$("#newsdate,#expireddate").datepicker
36			({dateFormat:"dd-M-yy",changeMonth:true,changeYear:true,});
37			});
38			</script>
39			<script type="text/javascript">
40			function cekData()
41			{ if (newsform.title.value == "")
42			{ alert("Headline News must be filled!");
43			newsform.title.focus();
44			return false;
45			}
46			if (newsform.detail.value == "")
47			{ alert("Detail News must be filled!");
48			newsform.detail.focus();
49			return false;
50			}
51			else
52			return true;
53			}
54			</script>
55			</head>
56			<body>
57			<div class="breadcrumb"> >> Admin >> Helpdesk News >> Update News</div>
58			<hr/>
59			<form name="newsform" method="post" action="" onsubmit="return cekData();">
60			<fieldset style="display: inline-block;">
61			<legend> Update Helpdesk News </legend>
62			<table class="formtable">
63			<tr align="left">
64			<td> News Date </td><td> : </td>
65			<td><input type="text" id="newsdate" name="newsdate" readonly="readonly" value="<?php echo date('d-M-Y', $thenews['newsdate']); ?>">
66			</td>
67			</tr>
68			<tr align="left">
69			<td> Headline News</td><td> : </td>
70			<td> <input type='text' size='70' name='title' maxlength="70" value="<?php echo $thenews['title']; ?>"> </td>
71			</tr>
72			<tr align="left">
73			<td> News Detail </td><td> : </td>
74			<td> <textarea name="detail" rows="3" cols="50"><?php echo $thenews['detail']; ?></textarea> </td>
75			</tr>
76			<tr align="left">
77			<td> News Expired Date</td><td> : </td>
78			<td><input type="text" id="expireddate" name="expireddate" readonly="readonly" value="<?php echo date('d-M-Y', $thenews['expired']); ?>">
79			</td>
80			</tr>
81			<tr align="left">
82			<td> </td>
83			<td> </td>
84			<td> <br/>
85			<input type='submit' name='submit' value=' Update '>
86			<input type='reset' name='reset' value=' Reset '>
87			</td>
88			</tr>
89			</table>
90			</fieldset>
91			</form>
92
93			<?php
94			if (empty($errors) === false) {
95			echo '<p class=errormsg>'.implode('</p><p class=errormsg>', $errors).'</p>';
96			}
97			?>
98			</body>
99			</html>

aepnat / simhelpdesk

Pull Request — master (#1)

hdnewsedit.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like