Issues in ticketedituser.php - All Issues - Inspection of "remove email classes" - aepnat/simhelpdesk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f8d49f...a1d922 )

by Saepul

created 2018-12-01 23:48 UTC

ticketedituser.php (1 issue)

Labels

Bug 1

Severity

Major 1

<?php 
require 'core/init.php';
$general->logged_out_protect();
$changeby = $_SESSION['loginid'];
$user = $users->userdata($_SESSION['loginid']);
$id = $_GET['id'];
$ticket = $tickets->ticket_data($id);
if ($ticket['ticketstatus'] == 'Closed') {
    header("Location: ticketread.php?id=$id");
    exit();
}
if (isset($_POST['submit'])) {
    $sla = $_POST['sla'];
    $reporteddate = $_POST['reporteddate'];
    $reportedmonth = $_POST['reportedmonth'];
    $reportedyear = $_POST['reportedyear'];
    $datetimeStr = $reportedyear.'-'.$reportedmonth.'-'.$reporteddate;
    $reporteddate = strtotime($datetimeStr);

    $reportedby = $_POST['reportedby'];
    $telp = $_POST['telp'];
    $email = $_POST['email'];
    $problemsummary = $_POST['problemsummary'];
    $problemdetail = $_POST['problemdetail'];
    $assignee = $_POST['idassignee'];
    $ticketstatus = $_POST['ticketstatus'];
    $resolution = $_POST['resolution'];
    $pendingby = $_POST['pendingby'];
    $pendingdate = $_POST['pendingdate'];
    $resolvedby = $_POST['resolvedby'];
    $resolveddate = $_POST['resolveddate'];
    $closedby = $_POST['closedby'];
    $closeddate = $_POST['closeddate'];
    $changes = 'Re-assigned the ticket.';
    if ($ticketstatus == 'Pending') {
        $pendingby = $user['username'];
        $pendingdate = strtotime(now);

        $changes = 'Change Status to Pending.';
    }
    if ($ticketstatus == 'Resolved') {
        $resolvedby = $user['username'];
        $resolveddate = strtotime(now);
        $changes = 'Change Status to Resolved.';
    }
    if ($ticketstatus == 'Closed') {
        $closedby = $user['username'];
        $closeddate = strtotime(now);
        $changes = 'Change Status to Closed.';
    }
    $tickets->update_ticket($id, $sla, $reporteddate, $reportedby, $telp, $email, $problemsummary, $problemdetail, $ticketstatus, $assignee, $assigneddate, $pendingby, $pendingdate, $resolution, $resolvedby, $resolveddate, $closedby, $closeddate);
    $tickets->log_tickets($id, $sla, $reporteddate, $reportedby, $telp, $email, $problemsummary, $problemdetail, $ticketstatus, $assignee, $assigneddate, $pendingby, $pendingdate, $resolution, $resolvedby, $resolveddate, $closedby, $closeddate, $changes, $changeby);
    header('Location: ticketlistuser.php');
}
?>
<!DOCTYPE HTML>
<html>
<head>
	<title>Update Ticket</title>
	<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
	<style type="text/css">
		body{background-image:url('images/corner.jpg');background-repeat:no-repeat;background-attachment:fixed;font-family: Arial, Helvetica, sans-serif;}
		.breadcrumb{font-size:12px;color:#0000A0;}
		.formtable {text-align:left; font-size:12px;color:#000000; background-color:#f0f0f0;padding:10px;width:600px; }
		.errormsg {font-size:10pt;color:#ff0000;text-align:left;}
	</style>
	<script type="text/javascript" src="js/jquery.js"></script>
	<script type="text/javascript">
	function cekData()
	{	if (ticketform.resolution.value == "")
		{	alert("Resolution must be filled!");
			ticketform.resolution.focus();
			return false;
		}
		if (ticketform.ticketstatus.value == "Closed")
		{	if(ticketform.oldticketstatus.value != "Resolved")
			{	alert("You must set status to resolved before closed!");
				ticketform.ticketstatus.focus();
				return false;
			}
		}
		else
			return true;
	}
	</script>
</head>
<body>	
	<div class="breadcrumb"> >> Home >> Update Ticket</div>
	<hr/>
	<form name="ticketform" method="post" action="" onsubmit="return cekData();">
	<fieldset style="display: inline-block;">
	<?php echo '<legend> Ticket No: '.$ticket['ticketnumber'].'</legend>'; ?>
	<div class="breadcrumb">*) Field Required</div> 
	<br/>
	<table class="formtable">
		<tr>
			<td width="120">Ticket No:</td><td> : </td>	
			<td><?php echo $ticket['ticketnumber']; ?>
			<input type="hidden" size='20' name='ticketnumber' value="<?php echo $ticket['ticketnumber']; ?>">
			</td>
		</tr>
		<tr>
			<td> Reported Date</td><td> : </td>
			<td><?php echo date('d-M-Y H:i', $ticket['reporteddate']); ?>
			<input type="hidden" name="reporteddate" value="<?php echo $ticket['reporteddate']; ?>"></td>
		</tr>
		<tr>
			<td> Reported By </td><td> : </td>
			<td><?php echo $ticket['reportedby']; ?>
			<input type='hidden' name="reportedby" value="<?php echo $ticket['reportedby']; ?>"> </td>
		</tr>
		<tr>
			<td> Urgency (SLA)</td><td> : </td>
			<td><?php $sladata = $slas->sla_data($ticket['sla']); echo $sladata['namasla']; ?>
				<input type='hidden' name='sla' value="<?php echo $ticket['sla']; ?>"> </td>
				
		</tr>
		<tr>
			<td> Problem Summary </td><td> : </td>
			<td> <?php echo $ticket['problemsummary']; ?>
			<input type="hidden" name="problemsummary" value="<?php echo $ticket['problemsummary']; ?>"> </td>
		</tr>
		<tr valign="top">
			<td> Problem Detail </td><td> : </td>
			<td> <?php echo nl2br($ticket['problemdetail']); ?> </td>
		</tr>
	</table>
	<br/>
	<table class="formtable">
		<tr>
			<td width="120"> Assign to </td><td> : </td>
			<td> <?php $userassignee = $users->userdata($ticket['assignee']); echo $userassignee['fullname']; ?>
			<input type='hidden' name='idassignee' value='<?php echo $ticket['assignee']; ?>'> </td>
		</tr>
		<tr>
			<td> Status* </td><td> : </td>
			<td> <input type="hidden" name="oldticketstatus" value="<?php echo $ticket['ticketstatus']; ?>"> 
			<select name="ticketstatus">
				<?php
                    echo '<option value='.$ticket['ticketstatus'].' selected="selected">'.$ticket['ticketstatus'].'</option>';
                ?>
				<option value="Assigned"> Assigned </option>
				<option value="Resolved"> Resolved </option>
				<option value="Pending"> Pending </option>
				<option value="Closed"> Closed </option>
			</select> 
			</td>
		</tr>
		<tr valign="top">
			<td> Resolution* </td><td> : </td>
			<td> <textarea name="resolution" rows="3" cols="38"><?php echo $ticket['resolution']; ?></textarea> </td>
		</tr>
		<tr>
			<td> </td><td> </td>
			<td> <input type="hidden" name="pendingby" value="<?php echo $ticket['pendingby']; ?>"> 
				 <input type="hidden" name="pendingdate" value="<?php echo $ticket['pendingdate']; ?>"> 
				 <input type="hidden" name="resolvedby" value="<?php echo $ticket['resolvedby']; ?>"> 
				 <input type="hidden" name="resolveddate" value="<?php echo $ticket['resolveddate']; ?>"> 
				 <input type="hidden" name="closedby" value="<?php echo $ticket['closedby']; ?>"> 
				 <input type="hidden" name="closeddate" value="<?php echo $ticket['closeddate']; ?>"> 
			</td>
		</tr>
		<tr>
			<td> </td> <td> </td>
			<td> 
				<input type='submit' name='submit' value=' Submit '>  &nbsp;&nbsp;&nbsp;
				<input type='reset' name='reset' value=' Reset '> 
			</td>
		</tr>
	</table>
	</fieldset>
	</form>
	<br/>
	<fieldset style="display: inline-block;">
	<legend> Ticket Audit Trail</legend>
	<table class="formtable">
	<tr bgcolor="#e0e0e0" ><td width="150">Updated On</td><td width="150">Updated By</td><td>Description</td></tr>
	<?php
        $list_log_tickets = $tickets->get_audit_trail($id);
        foreach ($list_log_tickets as $log_ticket) {
            $changed_by = $users->userdata($log_ticket['changeby']);
            echo '<tr><td>'.date('d-M-Y H:i:s', $log_ticket['changedate']).'</td>'.
                 '<td>'.$changed_by['fullname'].'</td>'.
                 '<td>'.$log_ticket['changes'].'</td></tr>';
        }
    ?>
	</table>
	</fieldset>
	<br/><br/>
</body>
</html>

1			<?php
2			require 'core/init.php';
3			$general->logged_out_protect();
4			$changeby = $_SESSION['loginid'];
5			$user = $users->userdata($_SESSION['loginid']);
6			$id = $_GET['id'];
7			$ticket = $tickets->ticket_data($id);
8			if ($ticket['ticketstatus'] == 'Closed') {
9			header("Location: ticketread.php?id=$id");
10			exit();
11			}
12			if (isset($_POST['submit'])) {
13			$sla = $_POST['sla'];
14			$reporteddate = $_POST['reporteddate'];
15			$reportedmonth = $_POST['reportedmonth'];
16			$reportedyear = $_POST['reportedyear'];
17			$datetimeStr = $reportedyear.'-'.$reportedmonth.'-'.$reporteddate;
18			$reporteddate = strtotime($datetimeStr);
19
20			$reportedby = $_POST['reportedby'];
21			$telp = $_POST['telp'];
22			$email = $_POST['email'];
23			$problemsummary = $_POST['problemsummary'];
24			$problemdetail = $_POST['problemdetail'];
25			$assignee = $_POST['idassignee'];
26			$ticketstatus = $_POST['ticketstatus'];
27			$resolution = $_POST['resolution'];
28			$pendingby = $_POST['pendingby'];
29			$pendingdate = $_POST['pendingdate'];
30			$resolvedby = $_POST['resolvedby'];
31			$resolveddate = $_POST['resolveddate'];
32			$closedby = $_POST['closedby'];
33			$closeddate = $_POST['closeddate'];
34			$changes = 'Re-assigned the ticket.';
35			if ($ticketstatus == 'Pending') {
36			$pendingby = $user['username'];
37			$pendingdate = strtotime(now);
			0 ignored issues – show Bug introduced 2018-12-01 14:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `now` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
38			$changes = 'Change Status to Pending.';
39			}
40			if ($ticketstatus == 'Resolved') {
41			$resolvedby = $user['username'];
42			$resolveddate = strtotime(now);
43			$changes = 'Change Status to Resolved.';
44			}
45			if ($ticketstatus == 'Closed') {
46			$closedby = $user['username'];
47			$closeddate = strtotime(now);
48			$changes = 'Change Status to Closed.';
49			}
50			$tickets->update_ticket($id, $sla, $reporteddate, $reportedby, $telp, $email, $problemsummary, $problemdetail, $ticketstatus, $assignee, $assigneddate, $pendingby, $pendingdate, $resolution, $resolvedby, $resolveddate, $closedby, $closeddate);
51			$tickets->log_tickets($id, $sla, $reporteddate, $reportedby, $telp, $email, $problemsummary, $problemdetail, $ticketstatus, $assignee, $assigneddate, $pendingby, $pendingdate, $resolution, $resolvedby, $resolveddate, $closedby, $closeddate, $changes, $changeby);
52			header('Location: ticketlistuser.php');
53			}
54			?>
55			<!DOCTYPE HTML>
56			<html>
57			<head>
58			<title>Update Ticket</title>
59			<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
60			<style type="text/css">
61			body{background-image:url('images/corner.jpg');background-repeat:no-repeat;background-attachment:fixed;font-family: Arial, Helvetica, sans-serif;}
62			.breadcrumb{font-size:12px;color:#0000A0;}
63			.formtable {text-align:left; font-size:12px;color:#000000; background-color:#f0f0f0;padding:10px;width:600px; }
64			.errormsg {font-size:10pt;color:#ff0000;text-align:left;}
65			</style>
66			<script type="text/javascript" src="js/jquery.js"></script>
67			<script type="text/javascript">
68			function cekData()
69			{ if (ticketform.resolution.value == "")
70			{ alert("Resolution must be filled!");
71			ticketform.resolution.focus();
72			return false;
73			}
74			if (ticketform.ticketstatus.value == "Closed")
75			{ if(ticketform.oldticketstatus.value != "Resolved")
76			{ alert("You must set status to resolved before closed!");
77			ticketform.ticketstatus.focus();
78			return false;
79			}
80			}
81			else
82			return true;
83			}
84			</script>
85			</head>
86			<body>
87			<div class="breadcrumb"> >> Home >> Update Ticket</div>
88			<hr/>
89			<form name="ticketform" method="post" action="" onsubmit="return cekData();">
90			<fieldset style="display: inline-block;">
91			<?php echo '<legend> Ticket No: '.$ticket['ticketnumber'].'</legend>'; ?>
92			<div class="breadcrumb">*) Field Required</div>
93			<br/>
94			<table class="formtable">
95			<tr>
96			<td width="120">Ticket No:</td><td> : </td>
97			<td><?php echo $ticket['ticketnumber']; ?>
98			<input type="hidden" size='20' name='ticketnumber' value="<?php echo $ticket['ticketnumber']; ?>">
99			</td>
100			</tr>
101			<tr>
102			<td> Reported Date</td><td> : </td>
103			<td><?php echo date('d-M-Y H:i', $ticket['reporteddate']); ?>
104			<input type="hidden" name="reporteddate" value="<?php echo $ticket['reporteddate']; ?>"></td>
105			</tr>
106			<tr>
107			<td> Reported By </td><td> : </td>
108			<td><?php echo $ticket['reportedby']; ?>
109			<input type='hidden' name="reportedby" value="<?php echo $ticket['reportedby']; ?>"> </td>
110			</tr>
111			<tr>
112			<td> Urgency (SLA)</td><td> : </td>
113			<td><?php $sladata = $slas->sla_data($ticket['sla']); echo $sladata['namasla']; ?>
114			<input type='hidden' name='sla' value="<?php echo $ticket['sla']; ?>"> </td>
115
116			</tr>
117			<tr>
118			<td> Problem Summary </td><td> : </td>
119			<td> <?php echo $ticket['problemsummary']; ?>
120			<input type="hidden" name="problemsummary" value="<?php echo $ticket['problemsummary']; ?>"> </td>
121			</tr>
122			<tr valign="top">
123			<td> Problem Detail </td><td> : </td>
124			<td> <?php echo nl2br($ticket['problemdetail']); ?> </td>
125			</tr>
126			</table>
127			<br/>
128			<table class="formtable">
129			<tr>
130			<td width="120"> Assign to </td><td> : </td>
131			<td> <?php $userassignee = $users->userdata($ticket['assignee']); echo $userassignee['fullname']; ?>
132			<input type='hidden' name='idassignee' value='<?php echo $ticket['assignee']; ?>'> </td>
133			</tr>
134			<tr>
135			<td> Status* </td><td> : </td>
136			<td> <input type="hidden" name="oldticketstatus" value="<?php echo $ticket['ticketstatus']; ?>">
137			<select name="ticketstatus">
138			<?php
139			echo '<option value='.$ticket['ticketstatus'].' selected="selected">'.$ticket['ticketstatus'].'</option>';
140			?>
141			<option value="Assigned"> Assigned </option>
142			<option value="Resolved"> Resolved </option>
143			<option value="Pending"> Pending </option>
144			<option value="Closed"> Closed </option>
145			</select>
146			</td>
147			</tr>
148			<tr valign="top">
149			<td> Resolution* </td><td> : </td>
150			<td> <textarea name="resolution" rows="3" cols="38"><?php echo $ticket['resolution']; ?></textarea> </td>
151			</tr>
152			<tr>
153			<td> </td><td> </td>
154			<td> <input type="hidden" name="pendingby" value="<?php echo $ticket['pendingby']; ?>">
155			<input type="hidden" name="pendingdate" value="<?php echo $ticket['pendingdate']; ?>">
156			<input type="hidden" name="resolvedby" value="<?php echo $ticket['resolvedby']; ?>">
157			<input type="hidden" name="resolveddate" value="<?php echo $ticket['resolveddate']; ?>">
158			<input type="hidden" name="closedby" value="<?php echo $ticket['closedby']; ?>">
159			<input type="hidden" name="closeddate" value="<?php echo $ticket['closeddate']; ?>">
160			</td>
161			</tr>
162			<tr>
163			<td> </td> <td> </td>
164			<td>
165			<input type='submit' name='submit' value=' Submit '>
166			<input type='reset' name='reset' value=' Reset '>
167			</td>
168			</tr>
169			</table>
170			</fieldset>
171			</form>
172			<br/>
173			<fieldset style="display: inline-block;">
174			<legend> Ticket Audit Trail</legend>
175			<table class="formtable">
176			<tr bgcolor="#e0e0e0" ><td width="150">Updated On</td><td width="150">Updated By</td><td>Description</td></tr>
177			<?php
178			$list_log_tickets = $tickets->get_audit_trail($id);
179			foreach ($list_log_tickets as $log_ticket) {
180			$changed_by = $users->userdata($log_ticket['changeby']);
181			echo '<tr><td>'.date('d-M-Y H:i:s', $log_ticket['changedate']).'</td>'.
182			'<td>'.$changed_by['fullname'].'</td>'.
183			'<td>'.$log_ticket['changes'].'</td></tr>';
184			}
185			?>
186			</table>
187			</fieldset>
188			<br/><br/>
189			</body>
190			</html>

aepnat / simhelpdesk

Push — master ( f8d49f...a1d922 )

ticketedituser.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like