Issues in ticketedituser.php - All Issues - Inspection of "field comment" - aepnat/simhelpdesk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3cc6ff...1680cc )

by Saepul

created 2018-12-06 14:35 UTC

ticketedituser.php (1 issue)

Labels

Bug 1

Severity

Major 1

<?php 
require 'core/init.php';
$general->logged_out_protect();
$changeby = $_SESSION['loginid'];
$user = $users->userdata($_SESSION['loginid']);
$id = $_GET['id'];
$ticket = $tickets->ticket_data($id);
if ($ticket['ticketstatus'] == 'Closed') {
    header("Location: ticketread.php?id=$id");
    exit();
}
if (isset($_POST['submit'])) {
    $sla = $_POST['sla'];
    $reporteddate = $_POST['reporteddate'];
    $reportedmonth = $_POST['reportedmonth'];
    $reportedyear = $_POST['reportedyear'];
    $datetimeStr = $reportedyear.'-'.$reportedmonth.'-'.$reporteddate;
    $reporteddate = strtotime($datetimeStr);

    $reportedby = $_POST['reportedby'];
    $telp = $_POST['telp'];
    $email = $_POST['email'];
    $problemsummary = $_POST['problemsummary'];
    $problemdetail = $_POST['problemdetail'];
    $assignee = $_POST['idassignee'];
    $ticketstatus = $_POST['ticketstatus'];
    $resolution = $_POST['resolution'];
    $comment = $_POST['comment'];
    $processby = $_POST['processby'];
    $processdate = $_POST['processdate'];
    $pendingby = $_POST['pendingby'];
    $pendingdate = $_POST['pendingdate'];
    $resolvedby = $_POST['resolvedby'];
    $resolveddate = $_POST['resolveddate'];
    $closedby = $_POST['closedby'];
    $closeddate = $_POST['closeddate'];
	$changes = 'Re-assigned the ticket.';
	if ($ticketstatus == 'Process') {
		$processby = $user['username'];
		$processdate = strtotime(now);

		$changes = 'Change Status to Process';
	}
    if ($ticketstatus == 'Pending') {
        $pendingby = $user['username'];
        $pendingdate = strtotime(now);
        $changes = 'Change Status to Pending.';
    }
    if ($ticketstatus == 'Resolved') {
        $resolvedby = $user['username'];
        $resolveddate = strtotime(now);
        $changes = 'Change Status to Resolved.';
    }
    if ($ticketstatus == 'Closed') {
        $closedby = $user['username'];
        $closeddate = strtotime(now);
        $changes = 'Change Status to Closed.';
    }
    $tickets->update_ticket($id, $sla, $reporteddate, $reportedby, $telp, $email, $problemsummary, $problemdetail, $ticketstatus, $assignee, $assigneddate, $pendingby, $pendingdate, $resolution, $resolvedby, $resolveddate, $closedby, $closeddate, $processby, $processdate, $comment);
    $tickets->log_tickets($id, $sla, $reporteddate, $reportedby, $telp, $email, $problemsummary, $problemdetail, $ticketstatus, $assignee, $assigneddate, $pendingby, $pendingdate, $resolution, $resolvedby, $resolveddate, $closedby, $closeddate, $changes, $changeby, $processby, $processdate, $comment);
    header('Location: ticketlistuser.php');
}
?>
<!DOCTYPE HTML>
<html>
<head>
	<title>Update Ticket</title>
	<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
	<link rel="stylesheet" href="css/style.css" />
	<style type="text/css">
		body{background-image:url('images/corner.jpg');background-repeat:no-repeat;background-attachment:fixed;font-family: Arial, Helvetica, sans-serif;}
		.breadcrumb{font-size:12px;color:#0000A0;}
		.formtable {text-align:left; font-size:12px;color:#000000; background-color:#f0f0f0;padding:10px;width:600px; }
		.errormsg {font-size:10pt;color:#ff0000;text-align:left;}
	</style>
	<script type="text/javascript" src="js/jquery.js"></script>
	<script type="text/javascript">
	function cekData()
	{	if (ticketform.resolution.value == "")
		{	alert("Resolution must be filled!");
			ticketform.resolution.focus();
			return false;
		}
		if (ticketform.ticketstatus.value == "Closed")
		{	if(ticketform.oldticketstatus.value != "Resolved")
			{	alert("You must set status to resolved before closed!");
				ticketform.ticketstatus.focus();
				return false;
			}
		}
		else
			return true;
	}
	</script>
</head>
<body>	
	<div class="breadcrumb"> >> Home >> Update Ticket</div>
	<hr/>
	<form name="ticketform" method="post" action="" onsubmit="return cekData();">
	<fieldset style="display: inline-block;">
	<?php echo '<legend> Ticket No: '.$ticket['ticketnumber'].'</legend>'; ?>
	<div class="breadcrumb">*) Field Required</div> 
	<br/>
	<table class="formtable">
		<tr>
			<td width="120">Ticket No:</td><td> : </td>	
			<td><?php echo $ticket['ticketnumber']; ?>
			<input type="hidden" size='20' name='ticketnumber' value="<?php echo $ticket['ticketnumber']; ?>">
			</td>
		</tr>
		<tr>
			<td> Reported Date</td><td> : </td>
			<td><?php echo date('d-M-Y H:i', $ticket['reporteddate']); ?>
			<input type="hidden" name="reporteddate" value="<?php echo $ticket['reporteddate']; ?>"></td>
		</tr>
		<tr>
			<td> Reported By </td><td> : </td>
			<td><?php echo $ticket['reportedby']; ?>
			<input type='hidden' name="reportedby" value="<?php echo $ticket['reportedby']; ?>"> </td>
		</tr>
		<tr>
			<td> Urgency (SLA)</td><td> : </td>
			<td><?php $sladata = $slas->sla_data($ticket['sla']); echo $sladata['namasla']; ?>
				<input type='hidden' name='sla' value="<?php echo $ticket['sla']; ?>"> </td>
				
		</tr>
		<tr>
			<td> Problem Summary </td><td> : </td>
			<td> <?php echo $ticket['problemsummary']; ?>
			<input type="hidden" name="problemsummary" value="<?php echo $ticket['problemsummary']; ?>"> </td>
		</tr>
		<tr valign="top">
			<td> Problem Detail </td><td> : </td>
			<td> <?php echo nl2br($ticket['problemdetail']); ?> </td>
			<input type="hidden" name="problemdetail" value="<?php echo $ticket['problemdetail']; ?>"> </td>
		</tr>
	</table>
	<br/>
	<table class="formtable">
		<tr>
			<td width="120"> Assign to </td><td> : </td>
			<td> <?php $userassignee = $users->userdata($ticket['assignee']); echo $userassignee['fullname']; ?>
			<input type='hidden' name='idassignee' value='<?php echo $ticket['assignee']; ?>'> </td>
		</tr>
		<tr>
			<td> Status* </td><td> : </td>
			<td> <input type="hidden" name="oldticketstatus" value="<?php echo $ticket['ticketstatus']; ?>"> 
			<select name="ticketstatus">
				<?php
                    echo '<option value='.$ticket['ticketstatus'].' selected="selected">'.$ticket['ticketstatus'].'</option>';
                ?>
				<option value="Assigned"> Assigned </option>
				<option value="Resolved"> Resolved </option>
				<option value="Pending"> Pending </option>
				<option value="Closed"> Closed </option>
			</select> 
			</td>
		</tr>
		<tr valign="top">
			<td> Resolution* </td><td> : </td>
			<td> <textarea name="resolution" rows="3" cols="38" <?php echo ($user['level'] == 'User') ? 'readonly="readonly"' : '';?>><?php echo $ticket['resolution']; ?></textarea> </td>
		</tr>
		<tr valign="top">
			<td> Comment* </td><td> : </td>
			<td> <textarea name="comment" rows="3" cols="38" <?php echo ($user['level'] != 'User') ? 'readonly="readonly"' : '';?>><?php echo $ticket['comment']; ?></textarea> </td>
		</tr>
		<tr>
			<td> </td><td> </td>
			<td> <input type="hidden" name="pendingby" value="<?php echo $ticket['pendingby']; ?>"> 
				 <input type="hidden" name="pendingdate" value="<?php echo $ticket['pendingdate']; ?>"> 
				 <input type="hidden" name="resolvedby" value="<?php echo $ticket['resolvedby']; ?>"> 
				 <input type="hidden" name="resolveddate" value="<?php echo $ticket['resolveddate']; ?>"> 
				 <input type="hidden" name="closedby" value="<?php echo $ticket['closedby']; ?>"> 
				 <input type="hidden" name="closeddate" value="<?php echo $ticket['closeddate']; ?>"> 
			</td>
		</tr>
		<tr>
			<td> </td> <td> </td>
			<td> 
				<input type='submit' name='submit' value=' Submit '>  &nbsp;&nbsp;&nbsp;
				<input type='reset' name='reset' value=' Reset '> 
			</td>
		</tr>
	</table>
	</fieldset>
	</form>
	<br/>
	<fieldset style="display: inline-block;">
	<legend> Ticket Audit Trail</legend>
	<table class="formtable">
	<tr bgcolor="#e0e0e0" ><td width="150">Updated On</td><td width="150">Updated By</td><td>Description</td></tr>
	<?php
        $list_log_tickets = $tickets->get_audit_trail($id);
        foreach ($list_log_tickets as $log_ticket) {
            $changed_by = $users->userdata($log_ticket['changeby']);
            echo '<tr><td>'.date('d-M-Y H:i:s', $log_ticket['changedate']).'</td>'.
                 '<td>'.$changed_by['fullname'].'</td>'.
                 '<td>'.$log_ticket['changes'].'</td></tr>';
        }
    ?>
	</table>
	</fieldset>
	<br/><br/>
</body>
</html>

1			<?php
2			require 'core/init.php';
3			$general->logged_out_protect();
4			$changeby = $_SESSION['loginid'];
5			$user = $users->userdata($_SESSION['loginid']);
6			$id = $_GET['id'];
7			$ticket = $tickets->ticket_data($id);
8			if ($ticket['ticketstatus'] == 'Closed') {
9			header("Location: ticketread.php?id=$id");
10			exit();
11			}
12			if (isset($_POST['submit'])) {
13			$sla = $_POST['sla'];
14			$reporteddate = $_POST['reporteddate'];
15			$reportedmonth = $_POST['reportedmonth'];
16			$reportedyear = $_POST['reportedyear'];
17			$datetimeStr = $reportedyear.'-'.$reportedmonth.'-'.$reporteddate;
18			$reporteddate = strtotime($datetimeStr);
19
20			$reportedby = $_POST['reportedby'];
21			$telp = $_POST['telp'];
22			$email = $_POST['email'];
23			$problemsummary = $_POST['problemsummary'];
24			$problemdetail = $_POST['problemdetail'];
25			$assignee = $_POST['idassignee'];
26			$ticketstatus = $_POST['ticketstatus'];
27			$resolution = $_POST['resolution'];
28			$comment = $_POST['comment'];
29			$processby = $_POST['processby'];
30			$processdate = $_POST['processdate'];
31			$pendingby = $_POST['pendingby'];
32			$pendingdate = $_POST['pendingdate'];
33			$resolvedby = $_POST['resolvedby'];
34			$resolveddate = $_POST['resolveddate'];
35			$closedby = $_POST['closedby'];
36			$closeddate = $_POST['closeddate'];
37			$changes = 'Re-assigned the ticket.';
38			if ($ticketstatus == 'Process') {
39			$processby = $user['username'];
40			$processdate = strtotime(now);
			0 ignored issues – show Bug introduced 2018-12-01 14:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `now` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
41			$changes = 'Change Status to Process';
42			}
43			if ($ticketstatus == 'Pending') {
44			$pendingby = $user['username'];
45			$pendingdate = strtotime(now);
46			$changes = 'Change Status to Pending.';
47			}
48			if ($ticketstatus == 'Resolved') {
49			$resolvedby = $user['username'];
50			$resolveddate = strtotime(now);
51			$changes = 'Change Status to Resolved.';
52			}
53			if ($ticketstatus == 'Closed') {
54			$closedby = $user['username'];
55			$closeddate = strtotime(now);
56			$changes = 'Change Status to Closed.';
57			}
58			$tickets->update_ticket($id, $sla, $reporteddate, $reportedby, $telp, $email, $problemsummary, $problemdetail, $ticketstatus, $assignee, $assigneddate, $pendingby, $pendingdate, $resolution, $resolvedby, $resolveddate, $closedby, $closeddate, $processby, $processdate, $comment);
59			$tickets->log_tickets($id, $sla, $reporteddate, $reportedby, $telp, $email, $problemsummary, $problemdetail, $ticketstatus, $assignee, $assigneddate, $pendingby, $pendingdate, $resolution, $resolvedby, $resolveddate, $closedby, $closeddate, $changes, $changeby, $processby, $processdate, $comment);
60			header('Location: ticketlistuser.php');
61			}
62			?>
63			<!DOCTYPE HTML>
64			<html>
65			<head>
66			<title>Update Ticket</title>
67			<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
68			<link rel="stylesheet" href="css/style.css" />
69			<style type="text/css">
70			body{background-image:url('images/corner.jpg');background-repeat:no-repeat;background-attachment:fixed;font-family: Arial, Helvetica, sans-serif;}
71			.breadcrumb{font-size:12px;color:#0000A0;}
72			.formtable {text-align:left; font-size:12px;color:#000000; background-color:#f0f0f0;padding:10px;width:600px; }
73			.errormsg {font-size:10pt;color:#ff0000;text-align:left;}
74			</style>
75			<script type="text/javascript" src="js/jquery.js"></script>
76			<script type="text/javascript">
77			function cekData()
78			{ if (ticketform.resolution.value == "")
79			{ alert("Resolution must be filled!");
80			ticketform.resolution.focus();
81			return false;
82			}
83			if (ticketform.ticketstatus.value == "Closed")
84			{ if(ticketform.oldticketstatus.value != "Resolved")
85			{ alert("You must set status to resolved before closed!");
86			ticketform.ticketstatus.focus();
87			return false;
88			}
89			}
90			else
91			return true;
92			}
93			</script>
94			</head>
95			<body>
96			<div class="breadcrumb"> >> Home >> Update Ticket</div>
97			<hr/>
98			<form name="ticketform" method="post" action="" onsubmit="return cekData();">
99			<fieldset style="display: inline-block;">
100			<?php echo '<legend> Ticket No: '.$ticket['ticketnumber'].'</legend>'; ?>
101			<div class="breadcrumb">*) Field Required</div>
102			<br/>
103			<table class="formtable">
104			<tr>
105			<td width="120">Ticket No:</td><td> : </td>
106			<td><?php echo $ticket['ticketnumber']; ?>
107			<input type="hidden" size='20' name='ticketnumber' value="<?php echo $ticket['ticketnumber']; ?>">
108			</td>
109			</tr>
110			<tr>
111			<td> Reported Date</td><td> : </td>
112			<td><?php echo date('d-M-Y H:i', $ticket['reporteddate']); ?>
113			<input type="hidden" name="reporteddate" value="<?php echo $ticket['reporteddate']; ?>"></td>
114			</tr>
115			<tr>
116			<td> Reported By </td><td> : </td>
117			<td><?php echo $ticket['reportedby']; ?>
118			<input type='hidden' name="reportedby" value="<?php echo $ticket['reportedby']; ?>"> </td>
119			</tr>
120			<tr>
121			<td> Urgency (SLA)</td><td> : </td>
122			<td><?php $sladata = $slas->sla_data($ticket['sla']); echo $sladata['namasla']; ?>
123			<input type='hidden' name='sla' value="<?php echo $ticket['sla']; ?>"> </td>
124
125			</tr>
126			<tr>
127			<td> Problem Summary </td><td> : </td>
128			<td> <?php echo $ticket['problemsummary']; ?>
129			<input type="hidden" name="problemsummary" value="<?php echo $ticket['problemsummary']; ?>"> </td>
130			</tr>
131			<tr valign="top">
132			<td> Problem Detail </td><td> : </td>
133			<td> <?php echo nl2br($ticket['problemdetail']); ?> </td>
134			<input type="hidden" name="problemdetail" value="<?php echo $ticket['problemdetail']; ?>"> </td>
135			</tr>
136			</table>
137			<br/>
138			<table class="formtable">
139			<tr>
140			<td width="120"> Assign to </td><td> : </td>
141			<td> <?php $userassignee = $users->userdata($ticket['assignee']); echo $userassignee['fullname']; ?>
142			<input type='hidden' name='idassignee' value='<?php echo $ticket['assignee']; ?>'> </td>
143			</tr>
144			<tr>
145			<td> Status* </td><td> : </td>
146			<td> <input type="hidden" name="oldticketstatus" value="<?php echo $ticket['ticketstatus']; ?>">
147			<select name="ticketstatus">
148			<?php
149			echo '<option value='.$ticket['ticketstatus'].' selected="selected">'.$ticket['ticketstatus'].'</option>';
150			?>
151			<option value="Assigned"> Assigned </option>
152			<option value="Resolved"> Resolved </option>
153			<option value="Pending"> Pending </option>
154			<option value="Closed"> Closed </option>
155			</select>
156			</td>
157			</tr>
158			<tr valign="top">
159			<td> Resolution* </td><td> : </td>
160			<td> <textarea name="resolution" rows="3" cols="38" <?php echo ($user['level'] == 'User') ? 'readonly="readonly"' : '';?>><?php echo $ticket['resolution']; ?></textarea> </td>
161			</tr>
162			<tr valign="top">
163			<td> Comment* </td><td> : </td>
164			<td> <textarea name="comment" rows="3" cols="38" <?php echo ($user['level'] != 'User') ? 'readonly="readonly"' : '';?>><?php echo $ticket['comment']; ?></textarea> </td>
165			</tr>
166			<tr>
167			<td> </td><td> </td>
168			<td> <input type="hidden" name="pendingby" value="<?php echo $ticket['pendingby']; ?>">
169			<input type="hidden" name="pendingdate" value="<?php echo $ticket['pendingdate']; ?>">
170			<input type="hidden" name="resolvedby" value="<?php echo $ticket['resolvedby']; ?>">
171			<input type="hidden" name="resolveddate" value="<?php echo $ticket['resolveddate']; ?>">
172			<input type="hidden" name="closedby" value="<?php echo $ticket['closedby']; ?>">
173			<input type="hidden" name="closeddate" value="<?php echo $ticket['closeddate']; ?>">
174			</td>
175			</tr>
176			<tr>
177			<td> </td> <td> </td>
178			<td>
179			<input type='submit' name='submit' value=' Submit '>
180			<input type='reset' name='reset' value=' Reset '>
181			</td>
182			</tr>
183			</table>
184			</fieldset>
185			</form>
186			<br/>
187			<fieldset style="display: inline-block;">
188			<legend> Ticket Audit Trail</legend>
189			<table class="formtable">
190			<tr bgcolor="#e0e0e0" ><td width="150">Updated On</td><td width="150">Updated By</td><td>Description</td></tr>
191			<?php
192			$list_log_tickets = $tickets->get_audit_trail($id);
193			foreach ($list_log_tickets as $log_ticket) {
194			$changed_by = $users->userdata($log_ticket['changeby']);
195			echo '<tr><td>'.date('d-M-Y H:i:s', $log_ticket['changedate']).'</td>'.
196			'<td>'.$changed_by['fullname'].'</td>'.
197			'<td>'.$log_ticket['changes'].'</td></tr>';
198			}
199			?>
200			</table>
201			</fieldset>
202			<br/><br/>
203			</body>
204			</html>

aepnat / simhelpdesk

Push — master ( 3cc6ff...1680cc )

ticketedituser.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like