advancedhosters\hipanel\tests\acceptance\module\finance\manager\GroupingTariffPlansCest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	64
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	ensureThatICanCreateTariffPlan()	14	14	1
A	ensureThatICanSeeTariffPlan()	9	9	1
A	ensureThatICanUpdateTariffPlan()	13	13	1
A	ensureThatICanDeleteTariffPlan()	5	5	1
A	ensureThatIDontSeeTariffPlan()	6	6	1

<?php

namespace advancedhosters\hipanel\tests\acceptance\module\finance\manager;

use hipanel\modules\finance\tests\_support\Page\plan\CreateGrouping as Create;
use hipanel\modules\finance\tests\_support\Page\plan\View;
use hipanel\modules\finance\tests\_support\Page\plan\UpdateGrouping as Update;
use hipanel\modules\finance\tests\_support\Page\plan\Delete;
use hipanel\modules\finance\tests\_support\Page\plan\Index;
use hipanel\tests\_support\Step\Acceptance\Manager;

class GroupingTariffPlansCest

This class seems to be duplicated in your project.

{
    /**
     * @var string
     */
    private $id;

    /**
     * @var array
     */
    private $fields;

    public function ensureThatICanCreateTariffPlan(Manager $I)
    {
        $this->fields = [
            'name' => uniqid(),
            'type' => 'Template',
            'client' => 'hipanel_test_manager',
            'currency' => 'USD',
            'note' => 'test note',
        ];
        $plan = new Create($I, $this->fields);
        $plan->seeFields();
        $this->id = $plan->createPlan();

The property $id was declared of type string, but $plan->createPlan() is of type integer. Maybe add a type cast?

        $this->ensureThatICanSeeTariffPlan($I);
    }

    private function ensureThatICanSeeTariffPlan(Manager $I)
    {
        $plan = new View($I, $this->fields, $this->id);
        $plan->visitPlan();
        $plan->seePlan();
        $search = new Index($I);
        $search->ensurePageWorks();
        $search->ensurePlanCanBeFound($this->fields['name']);
    }

    public function ensureThatICanUpdateTariffPlan(Manager $I)
    {
        $this->fields = [
            'name' => uniqid(),
            'type' => 'Server',
            'client' => 'hipanel_test_manager',
            'currency' => 'EUR',
            'note' => 'new_test_note',
        ];
        $plan = new Update($I, $this->fields);
        $this->id = $plan->updatePlan($this->id);

The property $id was declared of type string, but $plan->updatePlan($this->id) is of type integer. Maybe add a type cast?

        $this->ensureThatICanSeeTariffPlan($I);
    }

    public function ensureThatICanDeleteTariffPlan(Manager $I)
    {
        (new Delete($I, null, $this->id))->deletePlan();
        $this->ensureThatIDontSeeTariffPlan($I);
    }

    private function ensureThatIDontSeeTariffPlan(Manager $I)
    {
        $search = new Index($I);
        $search->ensurePageWorks();
        $search->ensurePlanNotFound($this->fields['name']);
    }
}