UserRepository::getUserEntityByUserCredentials() - Code Metrics - Inspection of "Add permissions to members with scopes (via Groups..." - advanced-learning/silverstripe-oauth2-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3a6bc2...bdf328 )

by Conrad

created 2018-02-12 01:02 UTC

UserRepository::getUserEntityByUserCredentials() A

↳ Parent: UserRepository

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	14
rs	9.4285
cc	2
eloc	8
nc	2
nop	4

<?php

namespace AdvancedLearning\Oauth2Server\Repositories;


use AdvancedLearning\Oauth2Server\Entities\UserEntity;
use League\OAuth2\Server\Entities\ClientEntityInterface;
use League\OAuth2\Server\Repositories\UserRepositoryInterface;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\ORM\ValidationResult;
use SilverStripe\Security\Member;
use SilverStripe\Security\MemberAuthenticator\MemberAuthenticator;

class UserRepository implements UserRepositoryInterface
{
    /**
     * {@inheritdoc}
     */
    public function getUserEntityByUserCredentials(
        $username,
        $password,
        $grantType,
        ClientEntityInterface $clientEntity
    ) {
        $member = Member::get()->filter(['Email' => $username])->first();
        /**
         * @var ValidationResult $result
         */
        $result = Injector::inst()->get(MemberAuthenticator::class)->checkPassword($member, $password);

        return $result->isValid() ? new UserEntity($member) : null;
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Gets a UserEntity by their identifier (Member->Email).
     *
     * @param string $userIdentifier
     * @return UserEntity
     */
    public function getUserEntityByIdentifier(string $userIdentifier): UserEntity
    {
        return new UserEntity(Member::get()->filter(['Email' => $userIdentifier])->first());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

}


1			<?php
2
3			namespace AdvancedLearning\Oauth2Server\Repositories;
4
5
6			use AdvancedLearning\Oauth2Server\Entities\UserEntity;
7			use League\OAuth2\Server\Entities\ClientEntityInterface;
8			use League\OAuth2\Server\Repositories\UserRepositoryInterface;
9			use SilverStripe\Core\Injector\Injector;
10			use SilverStripe\ORM\ValidationResult;
11			use SilverStripe\Security\Member;
12			use SilverStripe\Security\MemberAuthenticator\MemberAuthenticator;
13
14			class UserRepository implements UserRepositoryInterface
15			{
16			/**
17			* {@inheritdoc}
18			*/
19			public function getUserEntityByUserCredentials(
20			$username,
21			$password,
22			$grantType,
23			ClientEntityInterface $clientEntity
24			) {
25			$member = Member::get()->filter(['Email' => $username])->first();
26			/**
27			* @var ValidationResult $result
28			*/
29			$result = Injector::inst()->get(MemberAuthenticator::class)->checkPassword($member, $password);
30
31			return $result->isValid() ? new UserEntity($member) : null;
			0 ignored issues – show Documentation introduced 2017-11-13 19:28 UTC by Report Bug Copy Issue Report `$member` is of type `object<SilverStripe\ORM\DataObject>\|null`, but the function expects a `object<SilverStripe\Security\Member>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32			}
33
34			/**
35			* Gets a UserEntity by their identifier (Member->Email).
36			*
37			* @param string $userIdentifier
38			* @return UserEntity
39			*/
40			public function getUserEntityByIdentifier(string $userIdentifier): UserEntity
41			{
42			return new UserEntity(Member::get()->filter(['Email' => $userIdentifier])->first());
			0 ignored issues – show Documentation introduced 2018-02-12 01:04 UTC by Report Bug Copy Issue Report `\SilverStripe\Security\M...erIdentifier))->first()` is of type `object<SilverStripe\ORM\DataObject>\|null`, but the function expects a `object<SilverStripe\Security\Member>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
43			}
44
45			}
46

advanced-learning / silverstripe-oauth2-server

Push — master ( 3a6bc2...bdf328 )

UserRepository::getUserEntityByUserCredentials() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like