GroupScopesTest::setUp() - Code Metrics - Inspection of "Update tests" - advanced-learning/silverstripe-oauth2-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 7e4f27...ed015a )

by Conrad

created 2018-05-21 04:53 UTC

GroupScopesTest::setUp() A

↳ Parent: GroupScopesTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	0

<?php
/**
 * Created by PhpStorm.
 * User: conrad
 * Date: 21/05/18
 * Time: 4:10 PM
 */

namespace AdvancedLearning\Oauth2Server\Tests;


use AdvancedLearning\Oauth2Server\Entities\UserEntity;
use AdvancedLearning\Oauth2Server\Extensions\GroupExtension;
use AdvancedLearning\Oauth2Server\Services\ScopeService;
use SilverStripe\Core\Config\Config;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Security\Group;
use SilverStripe\Security\Member;

class GroupScopesTest extends SapphireTest
{
    protected static $fixture_file = 'OAuthFixture.yml';

    public function setUp()
    {
        // add GroupExtension for scopes
        Config::forClass(Group::class)->merge('extensions', [GroupExtension::class]);

        return parent::setUp(); // TODO: Change the autogenerated stub
    }

    public function testServiceScopes()

    {
        $obj = $this->objFromFixture(Member::class, 'member1');

        $service = new ScopeService();

        $this->assertTrue($service->hasScope('scope1', $obj), 'Member should have the scope via groups');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertFalse($service->hasScope('scope2', $obj), 'Member should not have scope2');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testEntityScopes()

    {
        $member = $this->objFromFixture(Member::class, 'member1');

        $entity = new UserEntity($member);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertTrue($entity->hasScope('scope1'), 'Member should have scope1');
        $this->assertFalse($entity->hasScope('scope2'), 'Member should not have scope2');
    }

}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: conrad
5		* Date: 21/05/18
6		* Time: 4:10 PM
7		*/
8
9		namespace AdvancedLearning\Oauth2Server\Tests;
10
11
12		use AdvancedLearning\Oauth2Server\Entities\UserEntity;
13		use AdvancedLearning\Oauth2Server\Extensions\GroupExtension;
14		use AdvancedLearning\Oauth2Server\Services\ScopeService;
15		use SilverStripe\Core\Config\Config;
16		use SilverStripe\Dev\SapphireTest;
17		use SilverStripe\Security\Group;
18		use SilverStripe\Security\Member;
19
20		class GroupScopesTest extends SapphireTest
21		{
22		protected static $fixture_file = 'OAuthFixture.yml';
23
24		public function setUp()
25		{
26		// add GroupExtension for scopes
27		Config::forClass(Group::class)->merge('extensions', [GroupExtension::class]);
28
29		return parent::setUp(); // TODO: Change the autogenerated stub
30		}
31
32	View Code Duplication	public function testServiceScopes()
		0 ignored issues – show Duplication introduced 2018-05-21 04:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		$obj = $this->objFromFixture(Member::class, 'member1');
35
36		$service = new ScopeService();
37
38		$this->assertTrue($service->hasScope('scope1', $obj), 'Member should have the scope via groups');
		0 ignored issues – show Documentation introduced 2018-05-21 04:55 UTC by Report Bug Copy Issue Report `$obj` is of type `object<SilverStripe\ORM\DataObject>\|null`, but the function expects a `object<SilverStripe\Security\Member>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39		$this->assertFalse($service->hasScope('scope2', $obj), 'Member should not have scope2');
		0 ignored issues – show Documentation introduced 2018-05-21 04:55 UTC by Report Bug Copy Issue Report `$obj` is of type `object<SilverStripe\ORM\DataObject>\|null`, but the function expects a `object<SilverStripe\Security\Member>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
40		}
41
42	View Code Duplication	public function testEntityScopes()
		0 ignored issues – show Duplication introduced 2018-05-21 04:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		$member = $this->objFromFixture(Member::class, 'member1');
45
46		$entity = new UserEntity($member);
		0 ignored issues – show Documentation introduced 2017-11-13 21:37 UTC by Report Bug Copy Issue Report `$member` is of type `object<SilverStripe\ORM\DataObject>\|null`, but the function expects a `object<SilverStripe\Security\Member>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
47
48		$this->assertTrue($entity->hasScope('scope1'), 'Member should have scope1');
49		$this->assertFalse($entity->hasScope('scope2'), 'Member should not have scope2');
50		}
51
52		}

advanced-learning / silverstripe-oauth2-server

Push — master ( 7e4f27...ed015a )

GroupScopesTest::setUp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like