Issues in AccessTokenRepository.php - New Issues - Inspection of "GraphQL integration" - advanced-learning/silverstripe-oauth2-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8763c1...14778d )

by Conrad

created 2017-11-20 01:50 UTC

src/Repositories/AccessTokenRepository.php (1 issue)

Showing only issues like (Show All)

Check for undocumented magic property with write access

Documentation Minor

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace AdvancedLearning\Oauth2Server\Repositories;

use AdvancedLearning\Oauth2Server\Entities\AccessTokenEntity as AccessTokenEntity;
use AdvancedLearning\Oauth2Server\Models\AccessToken;
use League\OAuth2\Server\Entities\AccessTokenEntityInterface;
use League\OAuth2\Server\Entities\ClientEntityInterface;
use League\OAuth2\Server\Repositories\AccessTokenRepositoryInterface;

class AccessTokenRepository implements AccessTokenRepositoryInterface
{
    /**
     * {@inheritdoc}
     */
    public function persistNewAccessToken(AccessTokenEntityInterface $accessTokenEntity)
    {
        $newToken = AccessToken::create();

        $newToken->Identifier = $accessTokenEntity->getIdentifier();
        $newToken->Name = $accessTokenEntity->getClient()->getName();
        $newToken->User = $accessTokenEntity->getUserIdentifier();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $newToken->ExpiryDateTime = $accessTokenEntity->getExpiryDateTime()->format('Y-m-d H:i');

        // turn scopes into space separated string
        $newToken->Scopes = '';
        $separator = '';
        foreach ($accessTokenEntity->getScopes() as $scope) {
            $newToken->Scopes .= $separator . $scope->getIdentifier();
            $separator = ' ';
        }

        $newToken->write();

        return $newToken;
    }

    /**
     * {@inheritdoc}
     */
    public function getNewToken(ClientEntityInterface $clientEntity, array $scopes, $userIdentifier = null)
    {
        return new AccessTokenEntity($userIdentifier, $scopes);
    }

    /**
     * {@inheritdoc}
     */
    public function revokeAccessToken($tokenId)
    {
        if ($token = $this->findToken($tokenId)) {
            $token->Revoked = true;
            $token->write();
        }
    }

    /**
     * {@inheritdoc}
     */
    public function isAccessTokenRevoked($tokenId): bool
    {
        $token = $this->findToken($tokenId);

        // return true if there is no matching token
        return empty($token) || $token->Revoked;
    }

    /**
     * Find the Token for passed id.
     *
     * @param string $tokenId The id of the token.
     *
     * @return AccessToken|null
     */
    public function findToken(string $tokenId): ?AccessToken
    {
        return AccessToken::get()->filter(['Identifier' => $tokenId])->first();
    }
}


1			<?php
2
3			namespace AdvancedLearning\Oauth2Server\Repositories;
4
5			use AdvancedLearning\Oauth2Server\Entities\AccessTokenEntity as AccessTokenEntity;
6			use AdvancedLearning\Oauth2Server\Models\AccessToken;
7			use League\OAuth2\Server\Entities\AccessTokenEntityInterface;
8			use League\OAuth2\Server\Entities\ClientEntityInterface;
9			use League\OAuth2\Server\Repositories\AccessTokenRepositoryInterface;
10
11			class AccessTokenRepository implements AccessTokenRepositoryInterface
12			{
13			/**
14			* {@inheritdoc}
15			*/
16			public function persistNewAccessToken(AccessTokenEntityInterface $accessTokenEntity)
17			{
18			$newToken = AccessToken::create();
19
20			$newToken->Identifier = $accessTokenEntity->getIdentifier();
21			$newToken->Name = $accessTokenEntity->getClient()->getName();
22			$newToken->User = $accessTokenEntity->getUserIdentifier();
			0 ignored issues – show Documentation introduced 2017-11-20 01:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `User` does not exist on `object<AdvancedLearning\...ver\Models\AccessToken>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
23			$newToken->ExpiryDateTime = $accessTokenEntity->getExpiryDateTime()->format('Y-m-d H:i');
24
25			// turn scopes into space separated string
26			$newToken->Scopes = '';
27			$separator = '';
28			foreach ($accessTokenEntity->getScopes() as $scope) {
29			$newToken->Scopes .= $separator . $scope->getIdentifier();
30			$separator = ' ';
31			}
32
33			$newToken->write();
34
35			return $newToken;
36			}
37
38			/**
39			* {@inheritdoc}
40			*/
41			public function getNewToken(ClientEntityInterface $clientEntity, array $scopes, $userIdentifier = null)
42			{
43			return new AccessTokenEntity($userIdentifier, $scopes);
44			}
45
46			/**
47			* {@inheritdoc}
48			*/
49			public function revokeAccessToken($tokenId)
50			{
51			if ($token = $this->findToken($tokenId)) {
52			$token->Revoked = true;
53			$token->write();
54			}
55			}
56
57			/**
58			* {@inheritdoc}
59			*/
60			public function isAccessTokenRevoked($tokenId): bool
61			{
62			$token = $this->findToken($tokenId);
63
64			// return true if there is no matching token
65			return empty($token) \|\| $token->Revoked;
66			}
67
68			/**
69			* Find the Token for passed id.
70			*
71			* @param string $tokenId The id of the token.
72			*
73			* @return AccessToken\|null
74			*/
75			public function findToken(string $tokenId): ?AccessToken
76			{
77			return AccessToken::get()->filter(['Identifier' => $tokenId])->first();
78			}
79			}
80

advanced-learning / silverstripe-oauth2-server

Push — master ( 8763c1...14778d )

src/Repositories/AccessTokenRepository.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like