ValidatorTest::testErrors() - Code Metrics - Inspection of "Add message test" - advanced-learning/input-validator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 988d81...745db2 )

by Conrad

created 2017-11-22 03:17 UTC

ValidatorTest::testErrors() B

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	27
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	27
rs	8.8571
c	0
b	0
f	0
cc	2
eloc	18
nc	2
nop	0

<?php


use AdvancedLearning\InputValidator\Exceptions\InputValidationException;
use AdvancedLearning\InputValidator\InputValidator;
use Respect\Validation\Validator as v;

/**
 * Test validator
 */
class ValidatorTest extends PHPUnit_Framework_TestCase
namespace YourVendor;

class YourClass { }
{
    public function setUp()
    {
        parent::setUp();
    }

    public function testErrors()
    {
        $data = [
            'FirstName' => '',
            'LastName' => '',
            'DateOfBirth' => '2017-09-20'
        ];

        $validator = new TestInputValidator();
        $validator->setMessages([
            'notBlank' => 'Please enter a value'
        ]);

        try {
            $validator->valid($data);
        } catch (InputValidationException $e) {
            $errors = $e->getMessages();
        }

        $this->assertEquals(4, count($errors), 'There should be four errors');
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $this->assertNotEmpty($errors['FirstName'], 'FirstName should be in validation errors');
        $this->assertEquals(
            $errors['FirstName'][0],
            'Please enter a value',
            'Not blank message should have been updated'
        );
    }
}

class TestInputValidator extends InputValidator
namespace YourVendor;

class YourClass { }
{

    /**
     * @inheritdoc
     */
    public function getRules()
    {
        return [
            'FirstName' => v::notBlank()->setName('First Name'),
            'LastName' => v::notBlank()->setName('Last Name'),
            'NHI' => v::notBlank()->setName('NHI'),
            'DateOfBirth' => v::date('Y-m-d')
                ->notEmpty()
                ->between('1900-01-01', (new \DateTime('2017-08-01'))->format('Y-m-d'))
                ->setName('Date of Birth')
        ];
    }
}


1			<?php
			0 ignored issues – show Coding Style introduced 2017-11-22 03:07 UTC by Report Bug Copy Issue Report End of line character is invalid; expected "\n" but found "\r\n" Loading history...
2
3			use AdvancedLearning\InputValidator\Exceptions\InputValidationException;
4			use AdvancedLearning\InputValidator\InputValidator;
5			use Respect\Validation\Validator as v;
6
7			/**
8			* Test validator
9			*/
10			class ValidatorTest extends PHPUnit_Framework_TestCase
			0 ignored issues – show Coding Style Compatibility introduced 2017-11-22 03:07 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12			public function setUp()
13			{
14			parent::setUp();
15			}
16
17			public function testErrors()
18			{
19			$data = [
20			'FirstName' => '',
21			'LastName' => '',
22			'DateOfBirth' => '2017-09-20'
23			];
24
25			$validator = new TestInputValidator();
26			$validator->setMessages([
27			'notBlank' => 'Please enter a value'
28			]);
29
30			try {
31			$validator->valid($data);
32			} catch (InputValidationException $e) {
33			$errors = $e->getMessages();
34			}
35
36			$this->assertEquals(4, count($errors), 'There should be four errors');
			0 ignored issues – show Bug introduced 2017-11-22 03:07 UTC by Report Bug Copy Issue Report The variable `$errors` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
37			$this->assertNotEmpty($errors['FirstName'], 'FirstName should be in validation errors');
38			$this->assertEquals(
39			$errors['FirstName'][0],
40			'Please enter a value',
41			'Not blank message should have been updated'
42			);
43			}
44			}
45
46			class TestInputValidator extends InputValidator
			0 ignored issues – show Coding Style Compatibility introduced 2017-11-22 03:07 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2017-11-22 03:07 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
47			{
48
49			/**
50			* @inheritdoc
51			*/
52			public function getRules()
53			{
54			return [
55			'FirstName' => v::notBlank()->setName('First Name'),
56			'LastName' => v::notBlank()->setName('Last Name'),
57			'NHI' => v::notBlank()->setName('NHI'),
58			'DateOfBirth' => v::date('Y-m-d')
59			->notEmpty()
60			->between('1900-01-01', (new \DateTime('2017-08-01'))->format('Y-m-d'))
61			->setName('Date of Birth')
62			];
63			}
64			}
65

advanced-learning / input-validator

Push — master ( 988d81...745db2 )

ValidatorTest::testErrors() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like