adumitru68 / QueryBuilder

src/Traits/Limit.php

<?php
/**
 * Created by PhpStorm.
 * Author: Adrian Dumitru
 * Date: 4/22/2017 11:40 PM
 */

namespace Qpdb\QueryBuilder\Traits;


use Qpdb\QueryBuilder\Dependencies\QueryException;
use Qpdb\QueryBuilder\Dependencies\QueryHelper;
use Qpdb\QueryBuilder\Dependencies\QueryStructure;

/**
 * Trait Limit
 * @package Qpdb\QueryBuilder\Traits
 * @property QueryStructure $queryStructure
 */
trait Limit
{

	/**
	 * @param int $limit
	 * @param null $offset

Are you sure the doc-type for parameter $offset is correct as it would always require null to be passed?

	 * @return $this
	 * @throws QueryException
	 */
	public function limit( $limit, $offset = null )
	{
		$limit = trim( $limit );

		if ( !QueryHelper::isInteger( $limit ) )
			throw new QueryException( 'Invalid Limit value', QueryException::QUERY_ERROR_INVALID_LIMIT );

		$limit = $this->queryStructure->bindParam('lim', (int)$limit);

		if ( is_null( $offset ) ) {

The condition is_null($offset) is always true.

			$this->queryStructure->setElement( QueryStructure::LIMIT, $limit );

			return $this;
		}

		$offset = trim( $offset );

		if ( !QueryHelper::isInteger( $offset ) )
			throw new QueryException( 'Invalid Limit offset', QueryException::QUERY_ERROR_INVALID_LIMIT_OFFSET );

		$offset = $this->queryStructure->bindParam('ofs', (int)$offset);

		$this->queryStructure->setElement( QueryStructure::LIMIT, $offset . ', ' . $limit );

		return $this;
	}

	private function getLimitSyntax()
	{
		if ( !$this->queryStructure->getElement( QueryStructure::LIMIT ) )
			return '';

		return 'LIMIT ' . $this->queryStructure->getElement( QueryStructure::LIMIT );
	}

}