Issues in AbstractConsultaApi.php (master) - Issues in master - adrianolaselva/fipeapi - Measure and Improve Code Quality continuously with Scrutinizer

Issues (11)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/FipeApi/AbstractConsultaApi.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace FipeApi;

use Curl\Curl;
use FipeApi\Constants\FipeApiParameter;
use FipeApi\Interfaces\IConsultaApi;

/**
 * Class AbstractConsultaApi
 * @package FipeApi
 */
abstract class AbstractConsultaApi implements IConsultaApi
{

    /**
     * @var Client
     */
    protected $client;

    /**
     * @var Curl
     */
    protected $_curl;

    /**
     * @var string
     */
    protected $tipo;

    /**
     * AbstractConsultaApi constructor.
     * @param $tipo
     * @param Client|null $client
     */
    public function __construct($tipo, Client $client = null)
    {

        $this->_curl = new Curl();
        $this->tipo = $tipo;

        if(is_null($client))
        {
            $this->client = new Client();
        }else{
            $this->client = $client;
        }

    }

    /**
     * @return array
     * @throws \Exception
     */
    public function getMarcas()

    {
        try{
            $this->_curl->get(sprintf("%s/%s/marcas.json",
                $this->client->getParameter(FipeApiParameter::FIPE_API_HOST),
                $this->tipo)
            );
            return $this->getResponse();
        }catch(\Exception $ex){
            var_dump($ex);

            throw new \Exception($ex->getMessage());
        }
    }

    /**
     * @param integer $fabricante
     *
     * @return array
     * @throws \Exception
     */
    public function getVeiculos($fabricante)

    {
        try{
            $this->_curl->get(sprintf("%s/%s/veiculos/%s.json",
                    $this->client->getParameter(FipeApiParameter::FIPE_API_HOST),
                    $this->tipo,
                    $fabricante)
            );
            return $this->getResponse();
        }catch(\Exception $ex){
            throw new \Exception($ex->getMessage());
        }
    }

    /**
     * @param integer $fabricante
     * @param integer $veiculo
     *
     * @return array
     * @throws \Exception
     */
    public function getModelos($fabricante, $veiculo)

    {
        try{
            $this->_curl->get(sprintf("%s/%s/veiculo/%s/%s.json",
                    $this->client->getParameter(FipeApiParameter::FIPE_API_HOST),
                    $this->tipo,
                    $fabricante,
                    $veiculo)
            );
            return $this->getResponse();
        }catch(\Exception $ex){
            throw new \Exception($ex->getMessage());
        }
    }

    public function getDetalhes($fabricante, $veiculo, $fipeCodigo)

    {
        try{
            $this->_curl->get(sprintf("%s/%s/veiculo/%s/%s/%s.json",
                    $this->client->getParameter(FipeApiParameter::FIPE_API_HOST),
                    $this->tipo,
                    $fabricante,
                    $veiculo,
                    $fipeCodigo)
            );
            return $this->getResponse();
        }catch(\Exception $ex){
            throw new \Exception($ex->getMessage());
        }
    }

    /**
     * @return array
     */
    protected function getResponse()
    {
        return [
            'http' => [
                'httpStatusCode' => $this->_curl->httpStatusCode,
                'httpErrorMessage' => $this->_curl->httpErrorMessage
            ],
            'data' => json_decode($this->_curl->rawResponse, true)
        ];
    }

}

1		<?php
2
3		namespace FipeApi;
4
5		use Curl\Curl;
6		use FipeApi\Constants\FipeApiParameter;
7		use FipeApi\Interfaces\IConsultaApi;
8
9		/**
10		* Class AbstractConsultaApi
11		* @package FipeApi
12		*/
13		abstract class AbstractConsultaApi implements IConsultaApi
14		{
15
16		/**
17		* @var Client
18		*/
19		protected $client;
20
21		/**
22		* @var Curl
23		*/
24		protected $_curl;
25
26		/**
27		* @var string
28		*/
29		protected $tipo;
30
31		/**
32		* AbstractConsultaApi constructor.
33		* @param $tipo
34		* @param Client\|null $client
35		*/
36		public function __construct($tipo, Client $client = null)
37		{
38
39		$this->_curl = new Curl();
40		$this->tipo = $tipo;
41
42		if(is_null($client))
43		{
44		$this->client = new Client();
45		}else{
46		$this->client = $client;
47		}
48
49		}
50
51		/**
52		* @return array
53		* @throws \Exception
54		*/
55	View Code Duplication	public function getMarcas()
		0 ignored issues – show Duplication introduced 2016-09-08 12:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		{
57		try{
58		$this->_curl->get(sprintf("%s/%s/marcas.json",
59		$this->client->getParameter(FipeApiParameter::FIPE_API_HOST),
60		$this->tipo)
61		);
62		return $this->getResponse();
63		}catch(\Exception $ex){
64		var_dump($ex);
		0 ignored issues – show Security Debugging Code introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `var_dump($ex);` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
65		throw new \Exception($ex->getMessage());
66		}
67		}
68
69		/**
70		* @param integer $fabricante
71		*
72		* @return array
73		* @throws \Exception
74		*/
75	View Code Duplication	public function getVeiculos($fabricante)
		0 ignored issues – show Duplication introduced 2016-09-08 12:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
76		{
77		try{
78		$this->_curl->get(sprintf("%s/%s/veiculos/%s.json",
79		$this->client->getParameter(FipeApiParameter::FIPE_API_HOST),
80		$this->tipo,
81		$fabricante)
82		);
83		return $this->getResponse();
84		}catch(\Exception $ex){
85		throw new \Exception($ex->getMessage());
86		}
87		}
88
89		/**
90		* @param integer $fabricante
91		* @param integer $veiculo
92		*
93		* @return array
94		* @throws \Exception
95		*/
96	View Code Duplication	public function getModelos($fabricante, $veiculo)
		0 ignored issues – show Duplication introduced 2016-08-18 10:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
97		{
98		try{
99		$this->_curl->get(sprintf("%s/%s/veiculo/%s/%s.json",
100		$this->client->getParameter(FipeApiParameter::FIPE_API_HOST),
101		$this->tipo,
102		$fabricante,
103		$veiculo)
104		);
105		return $this->getResponse();
106		}catch(\Exception $ex){
107		throw new \Exception($ex->getMessage());
108		}
109		}
110
111	View Code Duplication	public function getDetalhes($fabricante, $veiculo, $fipeCodigo)
		0 ignored issues – show Duplication introduced 2016-08-18 10:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
112		{
113		try{
114		$this->_curl->get(sprintf("%s/%s/veiculo/%s/%s/%s.json",
115		$this->client->getParameter(FipeApiParameter::FIPE_API_HOST),
116		$this->tipo,
117		$fabricante,
118		$veiculo,
119		$fipeCodigo)
120		);
121		return $this->getResponse();
122		}catch(\Exception $ex){
123		throw new \Exception($ex->getMessage());
124		}
125		}
126
127		/**
128		* @return array
129		*/
130		protected function getResponse()
131		{
132		return [
133		'http' => [
134		'httpStatusCode' => $this->_curl->httpStatusCode,
135		'httpErrorMessage' => $this->_curl->httpErrorMessage
136		],
137		'data' => json_decode($this->_curl->rawResponse, true)
138		];
139		}
140
141		}

adrianolaselva / fipeapi

Issues (11)

Security Analysis no request data

src/FipeApi/AbstractConsultaApi.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like