ConsultaApiFactory::getInstance() - Code Metrics - Inspection of "Adição de pattern factory" - adrianolaselva/fipeapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 614fcd...4d4354 )

by Adriano

created 2016-09-21 23:21 UTC

ConsultaApiFactory::getInstance() A

↳ Parent: ConsultaApiFactory

Complexity

Conditions	4
Paths	4

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.2
c	0
b	0
f	0
cc	4
eloc	6
nc	4
nop	1

<?php

namespace FipeApi\Factories;

use FipeApi\Api\ConsultaMotoApi;
use FipeApi\Constants\Tipo;

/**
 * Class ConsultaApiFactory
 *
 * @package FipeApi
 */
class ConsultaApiFactory
{
    /**
     * @param $tipo
     * @return ConsultaMotoApi
     * @throws \Exception
     */
    public static function getInstance($tipo)
    {

        switch($tipo)
        {
            case Tipo::MOTOS: return new ConsultaMotoApi();
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case Tipo::CAMINHOES: return new ConsultaMotoApi();
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case Tipo::CARROS: return new ConsultaMotoApi();
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
        }

        throw new \Exception("Tipo {$tipo} não definido");
    }
}

1			<?php
2
3			namespace FipeApi\Factories;
4
5			use FipeApi\Api\ConsultaMotoApi;
6			use FipeApi\Constants\Tipo;
7
8			/**
9			* Class ConsultaApiFactory
10			*
11			* @package FipeApi
12			*/
13			class ConsultaApiFactory
14			{
15			/**
16			* @param $tipo
17			* @return ConsultaMotoApi
18			* @throws \Exception
19			*/
20			public static function getInstance($tipo)
21			{
22
23			switch($tipo)
24			{
25			case Tipo::MOTOS: return new ConsultaMotoApi();
			0 ignored issues – show Coding Style introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
26			case Tipo::CAMINHOES: return new ConsultaMotoApi();
			0 ignored issues – show Coding Style introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
27			case Tipo::CARROS: return new ConsultaMotoApi();
			0 ignored issues – show Coding Style introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
28			}
29
30			throw new \Exception("Tipo {$tipo} não definido");
31			}
32			}

adrianolaselva / fipeapi

Push — master ( 614fcd...4d4354 )

ConsultaApiFactory::getInstance() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like