ConsultaApiFactory - Code Metrics - adrianolaselva/fipeapi - Measure and Improve Code Quality continuously with Scrutinizer

ConsultaApiFactory A
last analyzed 2016-10-21 14:21 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	4
lcom	0
cbo	3
dl	0
loc	20
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getInstance()	0	12	4

<?php

namespace FipeApi\Factories;

use FipeApi\Api\ConsultaCaminhaoApi;
use FipeApi\Api\ConsultaCarroApi;
use FipeApi\Api\ConsultaMotoApi;
use FipeApi\Constants\Tipo;

/**
 * Class ConsultaApiFactory
 *
 * @package FipeApi
 */
class ConsultaApiFactory
{
    /**
     * @param $tipo
     * @return ConsultaMotoApi
     * @throws \Exception
     */
    public static function getInstance($tipo)
    {

        switch($tipo)
        {
            case Tipo::MOTOS: return new ConsultaMotoApi();
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case Tipo::CAMINHOES: return new ConsultaCaminhaoApi();
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case Tipo::CARROS: return new ConsultaCarroApi();
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
        }

        throw new \Exception("Tipo {$tipo} não definido");
    }
}

1			<?php
2
3			namespace FipeApi\Factories;
4
5			use FipeApi\Api\ConsultaCaminhaoApi;
6			use FipeApi\Api\ConsultaCarroApi;
7			use FipeApi\Api\ConsultaMotoApi;
8			use FipeApi\Constants\Tipo;
9
10			/**
11			* Class ConsultaApiFactory
12			*
13			* @package FipeApi
14			*/
15			class ConsultaApiFactory
16			{
17			/**
18			* @param $tipo
19			* @return ConsultaMotoApi
20			* @throws \Exception
21			*/
22			public static function getInstance($tipo)
23			{
24
25			switch($tipo)
26			{
27			case Tipo::MOTOS: return new ConsultaMotoApi();
			0 ignored issues – show Coding Style introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
28			case Tipo::CAMINHOES: return new ConsultaCaminhaoApi();
			0 ignored issues – show Coding Style introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
29			case Tipo::CARROS: return new ConsultaCarroApi();
			0 ignored issues – show Coding Style introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-09-21 23:24 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
30			}
31
32			throw new \Exception("Tipo {$tipo} não definido");
33			}
34			}

adrianolaselva / fipeapi

ConsultaApiFactory A last analyzed 2016-10-21 14:21 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like

ConsultaApiFactory A
last analyzed 2016-10-21 14:21 UTC