Inspection of "Adição de tratamento para RequestException" - adrianolaselva/controlpay-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9537bc...5cf1f6 )

by Adriano

created 2016-10-31 14:25 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -67,7 +67,7 @@
 block discarded – undo
     public function setPedidos($pedidos)
     {
         foreach ($pedidos as $pedido)
-            $this->pedidos[] = SerializerHelper::denormalize($pedido, Pedido::class);
+            $this->pedidos[ ] = SerializerHelper::denormalize($pedido, Pedido::class);
 
         return $this;
     }

Please login to merge, or discard this patch.

src/Integracao/ControlPay/Factory/AuthenticationFactory.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -21,24 +21,24 @@
 block discarded – undo
      */
     public static function getInstance(array $params, Client $client = null)
     {
-        if(!isset($params[ControlPayParameterConst::CONTROLPAY_OAUTH_TYPE]))
+        if (!isset($params[ ControlPayParameterConst::CONTROLPAY_OAUTH_TYPE ]))
             throw new \Exception("Tipo de autenticação não especificado");
 
-        switch ($params[ControlPayParameterConst::CONTROLPAY_OAUTH_TYPE])
+        switch ($params[ ControlPayParameterConst::CONTROLPAY_OAUTH_TYPE ])
         {
             case BasicAuthentication::class:
                 return new BasicAuthentication(
-                    isset($params[ControlPayParameterConst::CONTROLPAY_USER]) ?$params[ControlPayParameterConst::CONTROLPAY_USER] : null,
-                    isset($params[ControlPayParameterConst::CONTROLPAY_PWD]) ?$params[ControlPayParameterConst::CONTROLPAY_PWD] : null,
-                    isset($params[ControlPayParameterConst::CONTROLPAY_KEY]) ?$params[ControlPayParameterConst::CONTROLPAY_KEY] : null
+                    isset($params[ ControlPayParameterConst::CONTROLPAY_USER ]) ? $params[ ControlPayParameterConst::CONTROLPAY_USER ] : null,
+                    isset($params[ ControlPayParameterConst::CONTROLPAY_PWD ]) ? $params[ ControlPayParameterConst::CONTROLPAY_PWD ] : null,
+                    isset($params[ ControlPayParameterConst::CONTROLPAY_KEY ]) ? $params[ ControlPayParameterConst::CONTROLPAY_KEY ] : null
                 );
                 break;
             case KeyQueryStringAuthentication::class:
                 return new KeyQueryStringAuthentication(
-                    isset($params[ControlPayParameterConst::CONTROLPAY_USER]) ?$params[ControlPayParameterConst::CONTROLPAY_USER] : null,
-                    isset($params[ControlPayParameterConst::CONTROLPAY_PWD]) ?$params[ControlPayParameterConst::CONTROLPAY_PWD] : null,
-                    isset($params[ControlPayParameterConst::CONTROLPAY_KEY]) ?$params[ControlPayParameterConst::CONTROLPAY_KEY] : null,
-                    isset($params[ControlPayParameterConst::CONTROLPAY_DEFAULT_PESSOA_ID]) ?$params[ControlPayParameterConst::CONTROLPAY_DEFAULT_PESSOA_ID] : null,
+                    isset($params[ ControlPayParameterConst::CONTROLPAY_USER ]) ? $params[ ControlPayParameterConst::CONTROLPAY_USER ] : null,
+                    isset($params[ ControlPayParameterConst::CONTROLPAY_PWD ]) ? $params[ ControlPayParameterConst::CONTROLPAY_PWD ] : null,
+                    isset($params[ ControlPayParameterConst::CONTROLPAY_KEY ]) ? $params[ ControlPayParameterConst::CONTROLPAY_KEY ] : null,
+                    isset($params[ ControlPayParameterConst::CONTROLPAY_DEFAULT_PESSOA_ID ]) ? $params[ ControlPayParameterConst::CONTROLPAY_DEFAULT_PESSOA_ID ] : null,
                     $client
                 );
                 break;

Please login to merge, or discard this patch.

src/Integracao/ControlPay/Contracts/Pedido/GetByFiltrosResponse.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -67,7 +67,7 @@
 block discarded – undo
     public function setPedidos($pedidos)
     {
         foreach ($pedidos as $pedido)
-            $this->pedidos[] = SerializerHelper::denormalize($pedido, Pedido::class);
+            $this->pedidos[ ] = SerializerHelper::denormalize($pedido, Pedido::class);
 
         return $this;
     }

Please login to merge, or discard this patch.

src/Integracao/ControlPay/Contracts/Pedido/InserirResponse.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@
 block discarded – undo
     {
         $this->pedido = $pedido;
 
-        if(is_array($this->pedido))
+        if (is_array($this->pedido))
             $this->pedido = SerializerHelper::denormalize($this->pedido, Pedido::class);
 
         return $this;

Please login to merge, or discard this patch.

src/Integracao/ControlPay/Contracts/Pedido/GetByIdResponse.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@
 block discarded – undo
     {
         $this->pedido = $pedido;
 
-        if(is_array($this->pedido))
+        if (is_array($this->pedido))
             $this->pedido = SerializerHelper::denormalize($this->pedido, Pedido::class);
 
         return $this;

Please login to merge, or discard this patch.

ControlPay/Contracts/Pedido/GetByPessoaIdByReferenciaResponse.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -67,7 +67,7 @@
 block discarded – undo
     public function setPedidos($pedidos)
     {
         foreach ($pedidos as $pedido)
-            $this->pedidos[] = SerializerHelper::denormalize($pedido, Pedido::class);
+            $this->pedidos[ ] = SerializerHelper::denormalize($pedido, Pedido::class);
 
         return $this;
     }

Please login to merge, or discard this patch.

src/Integracao/ControlPay/API/ProdutoApi.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -30,8 +30,8 @@  discard block
 block discarded – undo
      */
     public function getByAtivosByPessoaId($pessoaId)
     {
-        try{
-            $this->response = $this->_httpClient->get(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->get(__FUNCTION__, [
                 'query' => $this->addQueryAdditionalParameters([
                     'pessoaId' => $pessoaId
                 ])
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $this->requestException($ex);
-        }catch (\Exception $ex){
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }

Please login to merge, or discard this patch.

src/Integracao/ControlPay/API/IntencaoVendaApi.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -31,8 +31,8 @@  discard block
 block discarded – undo
      */
     public function getByFiltros(Contracts\IntencaoVenda\GetByFiltrosRequest $getByFiltrosRequest)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'body' => json_encode($getByFiltrosRequest),
             ]);
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $this->requestException($ex);
-        }catch (\Exception $ex){
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }
@@ -54,8 +54,8 @@  discard block
 block discarded – undo
      */
     public function getByFiltrosAsync(Contracts\IntencaoVenda\GetByFiltrosRequest $getByFiltrosRequest)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'body' => json_encode($getByFiltrosRequest),
             ]);
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $this->requestException($ex);
-        }catch (\Exception $ex){
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }
@@ -77,8 +77,8 @@  discard block
 block discarded – undo
      */
     public function getById($intencaoVendaId)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'query' => $this->addQueryAdditionalParameters([
                     'intencaoVendaId' => $intencaoVendaId
                 ])
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $this->requestException($ex);
-        }catch (\Exception $ex){
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }

Please login to merge, or discard this patch.

src/Integracao/ControlPay/API/TerminalApi.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -30,8 +30,8 @@  discard block
 block discarded – undo
      */
     public function getByPessoaId($pessoaId)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'query' => $this->addQueryAdditionalParameters([
                     'pessoaId' => $pessoaId
                 ])
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $this->requestException($ex);
-        }catch (\Exception $ex){
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
      */
     public function getById($terminalId)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'query' => $this->addQueryAdditionalParameters([
                     'terminalId' => $terminalId
                 ])
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $this->requestException($ex);
-        }catch (\Exception $ex){
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }
@@ -80,8 +80,8 @@  discard block
 block discarded – undo
      */
     public function insert(Contracts\Terminal\InsertRequest $insertRequest)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'body' => json_encode($insertRequest)
             ]);
 
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $this->requestException($ex);
-        }catch (\Exception $ex){
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }

Please login to merge, or discard this patch.

		@@ -67,7 +67,7 @@
		block discarded – undo
67	67	public function setPedidos($pedidos)
68	68	{
69	69	foreach ($pedidos as $pedido)
70		- $this->pedidos[] = SerializerHelper::denormalize($pedido, Pedido::class);
	70	+ $this->pedidos[ ] = SerializerHelper::denormalize($pedido, Pedido::class);
71	71
72	72	return $this;
73	73	}

		@@ -21,24 +21,24 @@
		block discarded – undo
21	21	*/
22	22	public static function getInstance(array $params, Client $client = null)
23	23	{
24		- if(!isset($params[ControlPayParameterConst::CONTROLPAY_OAUTH_TYPE]))
	24	+ if (!isset($params[ ControlPayParameterConst::CONTROLPAY_OAUTH_TYPE ]))
25	25	throw new \Exception("Tipo de autenticação não especificado");
26	26
27		- switch ($params[ControlPayParameterConst::CONTROLPAY_OAUTH_TYPE])
	27	+ switch ($params[ ControlPayParameterConst::CONTROLPAY_OAUTH_TYPE ])
28	28	{
29	29	case BasicAuthentication::class:
30	30	return new BasicAuthentication(
31		- isset($params[ControlPayParameterConst::CONTROLPAY_USER]) ?$params[ControlPayParameterConst::CONTROLPAY_USER] : null,
32		- isset($params[ControlPayParameterConst::CONTROLPAY_PWD]) ?$params[ControlPayParameterConst::CONTROLPAY_PWD] : null,
33		- isset($params[ControlPayParameterConst::CONTROLPAY_KEY]) ?$params[ControlPayParameterConst::CONTROLPAY_KEY] : null
	31	+ isset($params[ ControlPayParameterConst::CONTROLPAY_USER ]) ? $params[ ControlPayParameterConst::CONTROLPAY_USER ] : null,
	32	+ isset($params[ ControlPayParameterConst::CONTROLPAY_PWD ]) ? $params[ ControlPayParameterConst::CONTROLPAY_PWD ] : null,
	33	+ isset($params[ ControlPayParameterConst::CONTROLPAY_KEY ]) ? $params[ ControlPayParameterConst::CONTROLPAY_KEY ] : null
34	34	);
35	35	break;
36	36	case KeyQueryStringAuthentication::class:
37	37	return new KeyQueryStringAuthentication(
38		- isset($params[ControlPayParameterConst::CONTROLPAY_USER]) ?$params[ControlPayParameterConst::CONTROLPAY_USER] : null,
39		- isset($params[ControlPayParameterConst::CONTROLPAY_PWD]) ?$params[ControlPayParameterConst::CONTROLPAY_PWD] : null,
40		- isset($params[ControlPayParameterConst::CONTROLPAY_KEY]) ?$params[ControlPayParameterConst::CONTROLPAY_KEY] : null,
41		- isset($params[ControlPayParameterConst::CONTROLPAY_DEFAULT_PESSOA_ID]) ?$params[ControlPayParameterConst::CONTROLPAY_DEFAULT_PESSOA_ID] : null,
	38	+ isset($params[ ControlPayParameterConst::CONTROLPAY_USER ]) ? $params[ ControlPayParameterConst::CONTROLPAY_USER ] : null,
	39	+ isset($params[ ControlPayParameterConst::CONTROLPAY_PWD ]) ? $params[ ControlPayParameterConst::CONTROLPAY_PWD ] : null,
	40	+ isset($params[ ControlPayParameterConst::CONTROLPAY_KEY ]) ? $params[ ControlPayParameterConst::CONTROLPAY_KEY ] : null,
	41	+ isset($params[ ControlPayParameterConst::CONTROLPAY_DEFAULT_PESSOA_ID ]) ? $params[ ControlPayParameterConst::CONTROLPAY_DEFAULT_PESSOA_ID ] : null,
42	42	$client
43	43	);
44	44	break;

		@@ -63,7 +63,7 @@
		block discarded – undo
63	63	{
64	64	$this->pedido = $pedido;
65	65
66		- if(is_array($this->pedido))
	66	+ if (is_array($this->pedido))
67	67	$this->pedido = SerializerHelper::denormalize($this->pedido, Pedido::class);
68	68
69	69	return $this;

		@@ -30,8 +30,8 @@ discard block
		block discarded – undo
30	30	*/
31	31	public function getByAtivosByPessoaId($pessoaId)
32	32	{
33		- try{
34		- $this->response = $this->_httpClient->get(__FUNCTION__,[
	33	+ try {
	34	+ $this->response = $this->_httpClient->get(__FUNCTION__, [
35	35	'query' => $this->addQueryAdditionalParameters([
36	36	'pessoaId' => $pessoaId
37	37	])
		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43	);
44	44	}catch (RequestException $ex) {
45	45	$this->requestException($ex);
46		- }catch (\Exception $ex){
	46	+ }catch (\Exception $ex) {
47	47	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
48	48	}
49	49	}

		@@ -31,8 +31,8 @@ discard block
		block discarded – undo
31	31	*/
32	32	public function getByFiltros(Contracts\IntencaoVenda\GetByFiltrosRequest $getByFiltrosRequest)
33	33	{
34		- try{
35		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	34	+ try {
	35	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
36	36	'body' => json_encode($getByFiltrosRequest),
37	37	]);
38	38
		@@ -42,7 +42,7 @@ discard block
		block discarded – undo
42	42	);
43	43	}catch (RequestException $ex) {
44	44	$this->requestException($ex);
45		- }catch (\Exception $ex){
	45	+ }catch (\Exception $ex) {
46	46	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
47	47	}
48	48	}
		@@ -54,8 +54,8 @@ discard block
		block discarded – undo
54	54	*/
55	55	public function getByFiltrosAsync(Contracts\IntencaoVenda\GetByFiltrosRequest $getByFiltrosRequest)
56	56	{
57		- try{
58		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	57	+ try {
	58	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
59	59	'body' => json_encode($getByFiltrosRequest),
60	60	]);
61	61
		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65	);
66	66	}catch (RequestException $ex) {
67	67	$this->requestException($ex);
68		- }catch (\Exception $ex){
	68	+ }catch (\Exception $ex) {
69	69	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
70	70	}
71	71	}
		@@ -77,8 +77,8 @@ discard block
		block discarded – undo
77	77	*/
78	78	public function getById($intencaoVendaId)
79	79	{
80		- try{
81		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	80	+ try {
	81	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
82	82	'query' => $this->addQueryAdditionalParameters([
83	83	'intencaoVendaId' => $intencaoVendaId
84	84	])
		@@ -90,7 +90,7 @@ discard block
		block discarded – undo
90	90	);
91	91	}catch (RequestException $ex) {
92	92	$this->requestException($ex);
93		- }catch (\Exception $ex){
	93	+ }catch (\Exception $ex) {
94	94	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
95	95	}
96	96	}

		@@ -30,8 +30,8 @@ discard block
		block discarded – undo
30	30	*/
31	31	public function getByPessoaId($pessoaId)
32	32	{
33		- try{
34		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	33	+ try {
	34	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
35	35	'query' => $this->addQueryAdditionalParameters([
36	36	'pessoaId' => $pessoaId
37	37	])
		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43	);
44	44	}catch (RequestException $ex) {
45	45	$this->requestException($ex);
46		- }catch (\Exception $ex){
	46	+ }catch (\Exception $ex) {
47	47	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
48	48	}
49	49	}
		@@ -55,8 +55,8 @@ discard block
		block discarded – undo
55	55	*/
56	56	public function getById($terminalId)
57	57	{
58		- try{
59		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	58	+ try {
	59	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
60	60	'query' => $this->addQueryAdditionalParameters([
61	61	'terminalId' => $terminalId
62	62	])
		@@ -68,7 +68,7 @@ discard block
		block discarded – undo
68	68	);
69	69	}catch (RequestException $ex) {
70	70	$this->requestException($ex);
71		- }catch (\Exception $ex){
	71	+ }catch (\Exception $ex) {
72	72	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
73	73	}
74	74	}
		@@ -80,8 +80,8 @@ discard block
		block discarded – undo
80	80	*/
81	81	public function insert(Contracts\Terminal\InsertRequest $insertRequest)
82	82	{
83		- try{
84		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	83	+ try {
	84	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
85	85	'body' => json_encode($insertRequest)
86	86	]);
87	87
		@@ -91,7 +91,7 @@ discard block
		block discarded – undo
91	91	);
92	92	}catch (RequestException $ex) {
93	93	$this->requestException($ex);
94		- }catch (\Exception $ex){
	94	+ }catch (\Exception $ex) {
95	95	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
96	96	}
97	97	}

adrianolaselva / controlpay-sdk

Push — master ( 9537bc...5cf1f6 )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch