PedidoApi - Code Metrics - Inspection of "Integração com principais apis de pedido, criação..." - adrianolaselva/controlpay-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ac28ba...d1c608 )

by Adriano

created 2016-10-28 15:00 UTC

PedidoApi A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	181
Duplicated Lines	61.88 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
wmc	21
lcom	1
cbo	5
dl	112
loc	181
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	insert()	7	28	5
A	getByFiltros()	19	19	3
A	getByPessoaIdByReferencia()	22	22	3
A	getPedidosByPessoaId()	22	22	3
A	cancelar()	21	21	3
A	getById()	21	21	3

How to fix Duplicated Code

<?php

namespace Integracao\ControlPay\API;

use GuzzleHttp\Exception\RequestException;
use Integracao\ControlPay\AbstractAPI;
use Integracao\ControlPay\Client;
use Integracao\ControlPay\Constants\ControlPayParameterConst;
use Integracao\ControlPay\Contracts\Pedido;
use Integracao\ControlPay\Helpers\SerializerHelper;

/**
 * Class PedidoApi
 * @package Integracao\ControlPay\API
 */
class PedidoApi extends AbstractAPI
{
    /**
     * PedidoApi constructor.
     */
    public function __construct(Client $client)
    {
        parent::__construct('pedido', $client);
    }

    /**
     * @param Pedido\InserirRequest $inserirRequest
     * @return Pedido\InserirResponse
     * @throws \Exception
     */
    public function insert(Pedido\InserirRequest $inserirRequest)
    {
        try{

            foreach ($inserirRequest->getProdutosPedido() as $key => $produto)

            {
                if(empty($produto->getId()))
                    $inserirRequest->getProdutosPedido()[$key]->setId(
                        $this->_client->getParameter(ControlPayParameterConst::CONTROLPAY_DEFAULT_PRODUTO_ID)
                    );
            }

            $this->response = $this->_httpClient->post(__FUNCTION__,[
                'body' => json_encode($inserirRequest),
            ]);

            return SerializerHelper::denormalize(
                $this->response->json(),
                Pedido\InserirResponse::class
            );
        }catch (RequestException $ex) {
            $this->response = $ex->getResponse();
            $responseBody = $ex->getResponse()->json();
            throw new \Exception($responseBody['message']);
        }catch (\Exception $ex){
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
        }
    }

    /**
     * @param Pedido\GetByFiltrosRequest $getByFiltrosRequest
     * @return Pedido\GetByFiltrosResponse
     * @throws \Exception
     */
    public function getByFiltros(Pedido\GetByFiltrosRequest $getByFiltrosRequest)

    {
        try{
            $this->response = $this->_httpClient->post(__FUNCTION__,[
                'body' => json_encode($getByFiltrosRequest),
            ]);

            return SerializerHelper::denormalize(
                $this->response->json(),
                Pedido\GetByFiltrosResponse::class
            );
        }catch (RequestException $ex) {
            $this->response = $ex->getResponse();
            $responseBody = $ex->getResponse()->json();
            throw new \Exception($responseBody['message']);
        }catch (\Exception $ex){
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
        }
    }

    /**
     * @param $pessoaId
     * @param $pedidoReferencia
     * @return Pedido\GetByPessoaIdByReferenciaResponse
     * @throws \Exception
     */
    public function getByPessoaIdByReferencia($pessoaId, $pedidoReferencia)

    {
        try{
            $this->response = $this->_httpClient->post(__FUNCTION__,[
                'query' => $this->addQueryAdditionalParameters([
                    'pessoaId' => $pessoaId,
                    'pedidoReferencia' => $pedidoReferencia
                ])
            ]);

            return SerializerHelper::denormalize(
                $this->response->json(),
                Pedido\GetByPessoaIdByReferenciaResponse::class
            );
        }catch (RequestException $ex) {
            $this->response = $ex->getResponse();
            $responseBody = $ex->getResponse()->json();
            throw new \Exception($responseBody['message']);
        }catch (\Exception $ex){
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
        }
    }

    /**
     * @param $pessoaVendedorId
     * @param $pedidoId
     * @return Pedido\GetByPessoaIdByReferenciaResponse
     * @throws \Exception
     */
    public function getPedidosByPessoaId($pessoaVendedorId, $pedidoId)

    {
        try{
            $this->response = $this->_httpClient->post(__FUNCTION__,[
                'query' => $this->addQueryAdditionalParameters([
                    'pessoaVendedorId' => $pessoaVendedorId,
                    'pedidoId' => $pedidoId
                ])
            ]);

            return SerializerHelper::denormalize(
                $this->response->json(),
                Pedido\GetByPessoaIdByReferenciaResponse::class
            );
        }catch (RequestException $ex) {
            $this->response = $ex->getResponse();
            $responseBody = $ex->getResponse()->json();
            throw new \Exception($responseBody['message']);
        }catch (\Exception $ex){
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
        }
    }

    /**
     * @param $pedidoId
     * @return Pedido\CancelarResponse
     * @throws \Exception
     */
    public function cancelar($pedidoId)

    {
        try{
            $this->response = $this->_httpClient->post(__FUNCTION__,[
                'query' => $this->addQueryAdditionalParameters([
                    'pedidoId' => $pedidoId
                ])
            ]);

            return SerializerHelper::denormalize(
                $this->response->json(),
                Pedido\CancelarResponse::class
            );
        }catch (RequestException $ex) {
            $this->response = $ex->getResponse();
            $responseBody = $ex->getResponse()->json();
            throw new \Exception($responseBody['message']);
        }catch (\Exception $ex){
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
        }
    }

    /**
     * @param integer $pedidoId
     * @return Pedido\GetByIdResponse
     * @throws \Exception
     */
    public function getById($pedidoId)

    {
        try{
            $this->response = $this->_httpClient->post(__FUNCTION__,[
                'query' => $this->addQueryAdditionalParameters([
                    'pedidoId' => $pedidoId
                ])
            ]);

            return SerializerHelper::denormalize(
                $this->response->json(),
                Pedido\GetByIdResponse::class
            );
        }catch (RequestException $ex) {
            $this->response = $ex->getResponse();
            $responseBody = $ex->getResponse()->json();
            throw new \Exception($responseBody['message']);
        }catch (\Exception $ex){
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
        }
    }
}

1		<?php
2
3		namespace Integracao\ControlPay\API;
4
5		use GuzzleHttp\Exception\RequestException;
6		use Integracao\ControlPay\AbstractAPI;
7		use Integracao\ControlPay\Client;
8		use Integracao\ControlPay\Constants\ControlPayParameterConst;
9		use Integracao\ControlPay\Contracts\Pedido;
10		use Integracao\ControlPay\Helpers\SerializerHelper;
11
12		/**
13		* Class PedidoApi
14		* @package Integracao\ControlPay\API
15		*/
16		class PedidoApi extends AbstractAPI
17		{
18		/**
19		* PedidoApi constructor.
20		*/
21		public function __construct(Client $client)
22		{
23		parent::__construct('pedido', $client);
24		}
25
26		/**
27		* @param Pedido\InserirRequest $inserirRequest
28		* @return Pedido\InserirResponse
29		* @throws \Exception
30		*/
31		public function insert(Pedido\InserirRequest $inserirRequest)
32		{
33		try{
34
35	View Code Duplication	foreach ($inserirRequest->getProdutosPedido() as $key => $produto)
		0 ignored issues – show Bug introduced 2016-10-28 15:04 UTC by Report Bug Copy Issue Report The expression `$inserirRequest->getProdutosPedido()` of type `object<Integracao\ControlPay\Model\Produto>` is not traversable. Loading history... Duplication introduced 2016-10-28 15:04 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		if(empty($produto->getId()))
38		$inserirRequest->getProdutosPedido()[$key]->setId(
39		$this->_client->getParameter(ControlPayParameterConst::CONTROLPAY_DEFAULT_PRODUTO_ID)
40		);
41		}
42
43		$this->response = $this->_httpClient->post(__FUNCTION__,[
44		'body' => json_encode($inserirRequest),
45		]);
46
47		return SerializerHelper::denormalize(
48		$this->response->json(),
49		Pedido\InserirResponse::class
50		);
51		}catch (RequestException $ex) {
52		$this->response = $ex->getResponse();
53		$responseBody = $ex->getResponse()->json();
54		throw new \Exception($responseBody['message']);
55		}catch (\Exception $ex){
56		throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
57		}
58		}
59
60		/**
61		* @param Pedido\GetByFiltrosRequest $getByFiltrosRequest
62		* @return Pedido\GetByFiltrosResponse
63		* @throws \Exception
64		*/
65	View Code Duplication	public function getByFiltros(Pedido\GetByFiltrosRequest $getByFiltrosRequest)
		0 ignored issues – show Duplication introduced 2016-10-28 15:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		{
67		try{
68		$this->response = $this->_httpClient->post(__FUNCTION__,[
69		'body' => json_encode($getByFiltrosRequest),
70		]);
71
72		return SerializerHelper::denormalize(
73		$this->response->json(),
74		Pedido\GetByFiltrosResponse::class
75		);
76		}catch (RequestException $ex) {
77		$this->response = $ex->getResponse();
78		$responseBody = $ex->getResponse()->json();
79		throw new \Exception($responseBody['message']);
80		}catch (\Exception $ex){
81		throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
82		}
83		}
84
85		/**
86		* @param $pessoaId
87		* @param $pedidoReferencia
88		* @return Pedido\GetByPessoaIdByReferenciaResponse
89		* @throws \Exception
90		*/
91	View Code Duplication	public function getByPessoaIdByReferencia($pessoaId, $pedidoReferencia)
		0 ignored issues – show Duplication introduced 2016-10-28 15:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
92		{
93		try{
94		$this->response = $this->_httpClient->post(__FUNCTION__,[
95		'query' => $this->addQueryAdditionalParameters([
96		'pessoaId' => $pessoaId,
97		'pedidoReferencia' => $pedidoReferencia
98		])
99		]);
100
101		return SerializerHelper::denormalize(
102		$this->response->json(),
103		Pedido\GetByPessoaIdByReferenciaResponse::class
104		);
105		}catch (RequestException $ex) {
106		$this->response = $ex->getResponse();
107		$responseBody = $ex->getResponse()->json();
108		throw new \Exception($responseBody['message']);
109		}catch (\Exception $ex){
110		throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
111		}
112		}
113
114		/**
115		* @param $pessoaVendedorId
116		* @param $pedidoId
117		* @return Pedido\GetByPessoaIdByReferenciaResponse
118		* @throws \Exception
119		*/
120	View Code Duplication	public function getPedidosByPessoaId($pessoaVendedorId, $pedidoId)
		0 ignored issues – show Duplication introduced 2016-10-28 15:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121		{
122		try{
123		$this->response = $this->_httpClient->post(__FUNCTION__,[
124		'query' => $this->addQueryAdditionalParameters([
125		'pessoaVendedorId' => $pessoaVendedorId,
126		'pedidoId' => $pedidoId
127		])
128		]);
129
130		return SerializerHelper::denormalize(
131		$this->response->json(),
132		Pedido\GetByPessoaIdByReferenciaResponse::class
133		);
134		}catch (RequestException $ex) {
135		$this->response = $ex->getResponse();
136		$responseBody = $ex->getResponse()->json();
137		throw new \Exception($responseBody['message']);
138		}catch (\Exception $ex){
139		throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
140		}
141		}
142
143		/**
144		* @param $pedidoId
145		* @return Pedido\CancelarResponse
146		* @throws \Exception
147		*/
148	View Code Duplication	public function cancelar($pedidoId)
		0 ignored issues – show Duplication introduced 2016-10-28 15:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
149		{
150		try{
151		$this->response = $this->_httpClient->post(__FUNCTION__,[
152		'query' => $this->addQueryAdditionalParameters([
153		'pedidoId' => $pedidoId
154		])
155		]);
156
157		return SerializerHelper::denormalize(
158		$this->response->json(),
159		Pedido\CancelarResponse::class
160		);
161		}catch (RequestException $ex) {
162		$this->response = $ex->getResponse();
163		$responseBody = $ex->getResponse()->json();
164		throw new \Exception($responseBody['message']);
165		}catch (\Exception $ex){
166		throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
167		}
168		}
169
170		/**
171		* @param integer $pedidoId
172		* @return Pedido\GetByIdResponse
173		* @throws \Exception
174		*/
175	View Code Duplication	public function getById($pedidoId)
		0 ignored issues – show Duplication introduced 2016-10-28 15:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
176		{
177		try{
178		$this->response = $this->_httpClient->post(__FUNCTION__,[
179		'query' => $this->addQueryAdditionalParameters([
180		'pedidoId' => $pedidoId
181		])
182		]);
183
184		return SerializerHelper::denormalize(
185		$this->response->json(),
186		Pedido\GetByIdResponse::class
187		);
188		}catch (RequestException $ex) {
189		$this->response = $ex->getResponse();
190		$responseBody = $ex->getResponse()->json();
191		throw new \Exception($responseBody['message']);
192		}catch (\Exception $ex){
193		throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
194		}
195		}
196		}

adrianolaselva / controlpay-sdk

Push — master ( ac28ba...d1c608 )

PedidoApi A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like