GetByIdResponse - Code Metrics - adrianolaselva/controlpay-sdk - Measure and Improve Code Quality continuously with Scrutinizer

GetByIdResponse A
last analyzed 2018-10-20 16:54 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	64
Duplicated Lines	100 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

Metric	Value
wmc	7
lcom	2
cbo	1
dl	64
loc	64
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	3	3	1
A	getData()	4	4	1
A	setData()	9	9	2
A	getTerminal()	4	4	1
A	setTerminal()	9	9	2

How to fix Duplicated Code

<?php

namespace Integracao\ControlPay\Contracts\Terminal;

use Integracao\ControlPay\Helpers\SerializerHelper;
use Integracao\ControlPay\Model\Produto;
use Integracao\ControlPay\Model\Terminal;

/**
 * Class GetByIdResponse
 * @package Integracao\ControlPay\Contracts\Produto
 */
class GetByIdResponse

{
    /**
     * @var \DateTime
     */
    private $data;

    /**
     * @var Terminal
     */
    private $terminal;

    /**
     * GetByIdResponse constructor.
     */
    public function __construct()
    {
    }

    /**
     * @return \DateTime
     */
    public function getData()
    {
        return $this->data;
    }

    /**
     * @param \DateTime $data
     * @return GetByIdResponse
     */
    public function setData($data)
    {
        $this->data = \DateTime::createFromFormat('d/m/Y H:i:s.u', $data);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        if(!$this->data)
            $this->data = \DateTime::createFromFormat('d/m/Y H:i:s', $data);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        return $this;
    }

    /**
     * @return Terminal
     */
    public function getTerminal()
    {
        return $this->terminal;
    }

    /**
     * @param Terminal $terminal
     * @return GetByIdResponse
     */
    public function setTerminal($terminal)
    {
        $this->terminal = $terminal;

        if(is_array($this->terminal))
            $this->terminal = SerializerHelper::denormalize($this->terminal, Terminal::class);

        return $this;
    }

}

1		<?php
2
3		namespace Integracao\ControlPay\Contracts\Terminal;
4
5		use Integracao\ControlPay\Helpers\SerializerHelper;
6		use Integracao\ControlPay\Model\Produto;
7		use Integracao\ControlPay\Model\Terminal;
8
9		/**
10		* Class GetByIdResponse
11		* @package Integracao\ControlPay\Contracts\Produto
12		*/
13	View Code Duplication	class GetByIdResponse
		0 ignored issues – show Duplication introduced 2016-10-21 14:30 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		{
15		/**
16		* @var \DateTime
17		*/
18		private $data;
19
20		/**
21		* @var Terminal
22		*/
23		private $terminal;
24
25		/**
26		* GetByIdResponse constructor.
27		*/
28		public function __construct()
29		{
30		}
31
32		/**
33		* @return \DateTime
34		*/
35		public function getData()
36		{
37		return $this->data;
38		}
39
40		/**
41		* @param \DateTime $data
42		* @return GetByIdResponse
43		*/
44		public function setData($data)
45		{
46		$this->data = \DateTime::createFromFormat('d/m/Y H:i:s.u', $data);
		0 ignored issues – show Documentation Bug introduced 2016-10-21 14:30 UTC by Report Bug Copy Issue Report It seems like `\DateTime::createFromFor...'d/m/Y H:i:s.u', $data)` can also be of type `false`. However, the property `$data` is declared as type `object<DateTime>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
47
48		if(!$this->data)
49		$this->data = \DateTime::createFromFormat('d/m/Y H:i:s', $data);
		0 ignored issues – show Documentation Bug introduced 2016-10-21 14:30 UTC by Report Bug Copy Issue Report It seems like `\DateTime::createFromFormat('d/m/Y H:i:s', $data)` can also be of type `false`. However, the property `$data` is declared as type `object<DateTime>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
50
51		return $this;
52		}
53
54		/**
55		* @return Terminal
56		*/
57		public function getTerminal()
58		{
59		return $this->terminal;
60		}
61
62		/**
63		* @param Terminal $terminal
64		* @return GetByIdResponse
65		*/
66		public function setTerminal($terminal)
67		{
68		$this->terminal = $terminal;
69
70		if(is_array($this->terminal))
71		$this->terminal = SerializerHelper::denormalize($this->terminal, Terminal::class);
72
73		return $this;
74		}
75
76		}

adrianolaselva / controlpay-sdk

GetByIdResponse A last analyzed 2018-10-20 16:54 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

GetByIdResponse A
last analyzed 2018-10-20 16:54 UTC