ValidatesForm::proposeColumnRules() - Code Metrics - Inspection of "fix nullable validator" - adminarchitect/core - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 61197e...5bf490 )

by Terzi

created 2019-07-31 14:26 UTC

ValidatesForm::proposeColumnRules() C

↳ Parent: ValidatesForm

Complexity

Conditions	12
Paths	121

Size

Total Lines	48
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	156

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
cc	12
eloc	25
c	3
b	1
f	0
nc	121
nop	2
dl	0
loc	48
ccs	0
cts	22
cp	0
crap	156
rs	6.7916

How to fix Complexity

<?php

namespace Terranet\Administrator\Traits\Module;

use Doctrine\DBAL\Schema\Column;
use Illuminate\Validation\Rule;
filter:
    dependency_paths: ["lib/*"]
use Terranet\Administrator\Architect;
use Terranet\Rankable\Rankable;
filter:
    dependency_paths: ["lib/*"]
use function admin\db\scheme;

trait ValidatesForm
{
    /**
     * Define validation rules.
     */
    public function rules()
    {
        return $this->scaffoldRules();
    }

    /**
     * Build a list of supposed validators based on columns and indexes information.
     *
     * @return array
     */
    protected function scaffoldRules()
    {
        $rules = [];

        $eloquent = $this->model();
        $eloquent = $this->model();
        $table = $eloquent->getTable();

        foreach (scheme()->columns($table) as $column) {
            $name = $column->getName();
            // skip Primary Key
            if ($name === $eloquent->getKeyName()) {
                continue;
            }

            // skip rankable field
            if ($eloquent instanceof Rankable && $name === $eloquent->getRankableColumn()) {
                continue;
            }

            if (!empty($columnRules = $this->proposeColumnRules($eloquent, $column))) {
                $rules[$name] = implode('|', $columnRules);
            }
        }

        return $rules;
    }

    /**
     * Build a list of validators for a column.
     *
     * @param        $eloquent
     * @param  Column  $column
     * @return array
     */
    protected function proposeColumnRules($eloquent, Column $column)
    {
        $rules = [];

        if ('password' === $column->getName()) {
            return ['nullable', 'min:6'];
        }

        if ((($this->fillable($column->getName(), $eloquent) || $this->isForeignKey($column, $eloquent))
            && $column->getNotnull())) {
            // make required rule first
            array_unshift($rules, 'required');
        }

        if ($this->isUnique($column, $eloquent)) {
            $rules[] = 'unique';
        }

        if ('BooleanType' === ($classname = class_basename($column->getType()))) {
            $rules[] = 'numeric';
            $rules[] = 'boolean';

            if (app()->runningUnitTests()) {
            if (/** @scrutinizer ignore-call */ app()->runningUnitTests()) {
                $rules = array_diff($rules, ['required']);
            }
        }

        if (\in_array($classname, ['IntegerType', 'DecimalType'], true)) {
            $rules[] = 'numeric';

            if (false === $column->getNotnull()) {
                $rules[] = 'nullable';
            }

            if ($column->getUnsigned()) {
                $rules[] = 'unsigned';
            }
        }

        if ($this->isForeignKey($column, $eloquent)) {
            $rules[] = 'foreign';
        }

        return array_map(function ($rule) use ($column, $eloquent) {
            $method = 'make'.ucfirst($rule).'Rule';

            return \call_user_func_array([$this, $method], [$column, $eloquent]);
        }, $rules);
    }

    /**
     * Check if column fillable.
     *
     * @param            $column
     * @param            $eloquent
     * @return bool
     */
    protected function fillable($column, $eloquent)
    {
        return \in_array($column, $eloquent->getFillable(), true);
    }

    /**
     * Check if column is a part of foreign keys.
     *
     * @param $column
     * @param $eloquent
     * @return bool
     */
    protected function isForeignKey($column, $eloquent)
    {
        foreach ($foreign = scheme()->foreignKeys($eloquent->getTable()) as $foreign) {

            if (\in_array($column->getName(), $foreign->getLocalColumns(), true)) {
                return $foreign;
            }
        }

        return false;
    }

    /**
     * @param  Column  $column
     * @param        $eloquent
     * @return array
     */
    protected function isUnique(Column $column, $eloquent)
    {
        foreach (scheme()->indexes($eloquent->getTable()) as $indexName => $index) {
            if (\in_array($column->getName(), $index->getColumns(), true) && $index->isUnique()) {
                return true;
            }
        }

        return false;
    }

    /**
     * Make required rule.
     *
     * @param  Column  $column
     * @param        $eloquent
     * @return string
     */
    protected function makeRequiredRule(Column $column, $eloquent)
    {
        return 'required';
    }

    /**
     * Make numeric rule.
     *
     * @param  Column  $column
     * @param        $eloquent
     * @return array
     */
    protected function makeNumericRule(Column $column, $eloquent)
    {
        return $column->getScale() ? 'numeric' : 'integer';
    }

    /**
     * Make unsigned rule.
     *
     * @param  Column  $column
     * @param        $eloquent
     * @return array
     */
    protected function makeUnsignedRule(Column $column, $eloquent)
    {
        return 'min:0';
    }

    /**
     * @param  Column  $column
     * @param $eloquent
     * @return Rule
     * @throws \ReflectionException
     */
    protected function makeBooleanRule(Column $column, $eloquent)
    {
        $values = [0, 1];
        if (Architect::castedEnumType($eloquent, $column->getName())) {
            $values = array_keys(Architect::castedEnumValues($eloquent, $column->getName()));
        }

        return Rule::in($values);
    }

    /**
     * Parse foreign keys for column presence.
     *
     * @param  Column  $column
     * @param        $eloquent
     * @return array
     */
    protected function makeForeignRule(Column $column, $eloquent)
    {
        $foreign = $this->isForeignKey($column, $eloquent);
        $foreignTable = $foreign->getForeignTableName();
        $foreignKey = head($foreign->getForeignColumns());

        return "exists:{$foreignTable},{$foreignKey}";
    }

    /**
     * @param $column
     * @param $eloquent
     * @return string
     */
    protected function makeUniqueRule($column, $eloquent)
    {
        if (\is_object($key = $this->routeParam('id')) && method_exists($key, 'getKey')) {
            $key = $key->getKey();
        }

        return "unique:{$eloquent->getTable()},{$column->getName()}".($key ? ",{$key}" : '');
    }

    /**
     * @param $column
     * @param $eloquent
     * @return string
     */
    protected function makeNullableRule($column, $eloquent)
    {
        return 'nullable';
    }

    /**
     * @param $name
     * @param  null  $default

     * @return mixed
     */
    protected function routeParam($name, $default = null)
    {
        return \Route::current()->parameter($name, $default);
    }
}


adminarchitect / core

Push — master ( 61197e...5bf490 )

ValidatesForm::proposeColumnRules() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like