Terranet\Administrator\Traits\Actions\Skeleton

Complexity

Total Complexity

13

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	4
Bugs	1	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	renderBtn()	0	9	2
A	name()	0	5	2
A	translationKey()	0	9	2
A	action()	0	3	1
A	render()	0	9	2
A	type()	0	3	1
A	entityKey()	0	3	2
A	icon()	0	3	1

<?php

namespace Terranet\Administrator\Traits\Actions;

use Illuminate\Database\Eloquent\Model as Eloquent;

The type Illuminate\Database\Eloquent\Model was not found. Maybe you did not declare it correctly or list all dependencies?

trait Skeleton
{
    /**
     * @return string
     */
    public function type(): string
    {
        return 'primary';
    }

    /**
     * Render action button.
     *
     * @param  Eloquent  $entity
     * @return string
     */
    public function render(Eloquent $entity = null)
    {
        $action = app('scaffold.module')->url().'-'.$this->action($entity);

The function app was not found. Maybe you did not declare it correctly or list all dependencies?

        $icon = ($i = $this->icon($entity)) ? "<i class=\"fa {$i}\"></i>" : '';

        return
            <<<OUTPUT
<a data-scaffold-action="{$action}" data-scaffold-key="{$this->entityKey($entity)}" href="{$this->route($entity)}" {$this->attributes($entity)}>

It seems like $entity can also be of type Illuminate\Database\Eloquent\Model; however, parameter $entity of Terranet\Administrator\Traits\Actions\Skeleton::entityKey() does only seem to accept null, maybe add an additional type check?

It seems like route() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like attributes() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    {$icon}<span>{$this->name($entity)}</span>
</a>
OUTPUT;
    }

    /**
     * Render action button.
     *
     * @param  Eloquent  $entity
     * @return string
     */
    public function renderBtn(Eloquent $entity = null)
    {
        $action = app('scaffold.module')->url().'-'.$this->action($entity);

The function app was not found. Maybe you did not declare it correctly or list all dependencies?

        $icon = ($i = $this->icon($entity)) ? "<i class=\"fa {$i}\"></i>" : '';

        return
            <<<OUTPUT
<a class="btn btn-{$this->type()}" data-scaffold-action="{$action}" data-scaffold-key="{$this->entityKey($entity)}" href="{$this->route($entity)}" {$this->attributes($entity)}>

It seems like $entity can also be of type Illuminate\Database\Eloquent\Model; however, parameter $entity of Terranet\Administrator\Traits\Actions\Skeleton::entityKey() does only seem to accept null, maybe add an additional type check?

    {$icon}<span>{$this->name($entity)}</span>
</a>
OUTPUT;
    }

    /**
     * @param  Eloquent  $entity
     * @return string
     */
    protected function action(Eloquent $entity = null)

The parameter $entity is not used and could be removed.

    {
        return snake_case(class_basename($this));

The function snake_case() has been deprecated: Str::snake() should be used directly instead. Will be removed in Laravel 5.9.

    }

    /**
     * Action name.
     *
     * @param  Eloquent  $entity
     * @return string
     */
    protected function name(Eloquent $entity = null)

The parameter $entity is not used and could be removed.

    {
        return app('translator')->has($key = $this->translationKey())

The function app was not found. Maybe you did not declare it correctly or list all dependencies?

            ? trans($key)

The function trans was not found. Maybe you did not declare it correctly or list all dependencies?

            : title_case(str_replace('_', ' ', snake_case(class_basename($this))));

The function snake_case() has been deprecated: Str::snake() should be used directly instead. Will be removed in Laravel 5.9.

The function title_case() has been deprecated: Str::title() should be used directly instead. Will be removed in Laravel 5.9.

    }

    /**
     * @param  Eloquent  $entity
     * @return string
     */
    protected function icon(Eloquent $entity = null)

The parameter $entity is not used and could be removed.

    {
        return 'fa-circle-thin';
    }

    /**
     * @return string
     */
    protected function translationKey(): string
    {
        $key = sprintf('administrator::actions.%s.%s', app('scaffold.module')->url(), snake_case(class_basename($this)));

The function app was not found. Maybe you did not declare it correctly or list all dependencies?

The function snake_case() has been deprecated: Str::snake() should be used directly instead. Will be removed in Laravel 5.9.

        if (!app('translator')->has($key)) {
            $key = sprintf('administrator::actions.global.%s', snake_case(class_basename($this)));

The function snake_case() has been deprecated: Str::snake() should be used directly instead. Will be removed in Laravel 5.9.

        }

        return $key;
    }

    /**
     * @param  null  $entity

Are you sure the doc-type for parameter $entity is correct as it would always require null to be passed?

     * @return string
     */
    protected function entityKey($entity = null): string
    {
        return $entity ? $entity->getKey() : 'empty';

$entity is of type null, thus it always evaluated to false.

    }
}