EnumDetector::detect() - Code Metrics - Inspection of "Improve Grid's type detection" - adminarchitect/core - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( b480ce...8fe18f )

by Terzi

created 2018-11-16 08:06 UTC

EnumDetector::detect() A

↳ Parent: EnumDetector

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	3
dl	0
loc	9
rs	10
c	0
b	0
f	0

<?php

namespace Terranet\Administrator\Field\Detectors;

use function admin\db\connection;
use function admin\db\enum_values;
use function admin\db\translated_values;
use Doctrine\DBAL\Schema\Column;
use Doctrine\DBAL\Types\StringType;
use Illuminate\Database\Eloquent\Model;
use Terranet\Administrator\Field\Enum;
use Terranet\Administrator\Field\Link;

class EnumDetector extends AbstractDetector
{
    /** @var array */
    protected $values = [];

    /**
     * @param string $column
     * @param Model $model
     * @return mixed
     */
    protected function enumValues(string $column, Model $model)
    {
        return $this->values = enum_values($model->getTable(), $column);
    }

    /**
     * Authorize execution.
     *
     * @param string $column
     * @param Column $metadata
     * @param Model $model
     *
     * @return bool
     */
    protected function authorize(string $column, Column $metadata, Model $model): bool
    {
        return connection('mysql') && !$metadata->getLength() && !empty($this->enumValues($column, $model));
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
    }

    /**
     * Detect field class.
     *
     * @param string $column
     * @param Column $metadata
     * @param Model $model
     *
     * @return mixed
     */
    protected function detect(string $column, Column $metadata, Model $model)
    {
        $values = translated_values($this->values, app('scaffold.module')->url(), $column);
        $values = translated_values($this->values, app('scaffold.module')->/** @scrutinizer ignore-call */ url(), $column);

        if (!$metadata->getNotNull()) {
            $values = ['' => '----'] + $values;
        }

        return Enum::make($column, $column)->setOptions($values);
    }
}

adminarchitect / core

Push — master ( b480ce...8fe18f )

EnumDetector::detect() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like