Terranet\Administrator\Traits\Module\HasColumns

Complexity

Total Complexity

13

Size/Duplication

Total Lines	94
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	collectColumns()	0	44	9
A	columns()	0	3	1
A	scaffoldColumns()	0	4	1
A	widgets()	0	3	1
A	viewColumns()	0	3	1

<?php

namespace Terranet\Administrator\Traits\Module;

use Illuminate\Database\Eloquent\Model;
use Terranet\Administrator\Collection\Group;
use Terranet\Administrator\Collection\Mutable as MutableCollection;
use Terranet\Administrator\Dashboard\Manager;
use Terranet\Administrator\Decorators\Grid as GridDecorator;
use Terranet\Administrator\Form\Collection\Mutable;
use Terranet\Translatable\Translatable;

trait HasColumns
{
    /**
     * Fetch scaffold columns.
     *
     * @return MutableCollection
     */
    public function columns()
    {
        return $this->scaffoldColumns();
    }

    /**
     * Define the list of attributes visible on View model page.
     *
     * @param Model $model
     *
     * @return Mutable
     */
    public function viewColumns()
    {
        return $this->scaffoldColumns();
    }

    /**
     * Scaffold columns.
     *
     * @return MutableCollection
     */
    protected function scaffoldColumns()
    {
        return $this->collectColumns(
            $this->model()

It seems like model() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        );
    }

    /**
     * @param Manager $dashboard
     * @return Manager
     */
    public function widgets(Manager $dashboard): Manager
    {
        return $dashboard;
    }

    /**
     * @param $model
     *
     * @return MutableCollection
     */
    protected function collectColumns(Model $model = null)
    {
        if (!$model) {
            return new MutableCollection([]);
        }

        $pk = $model->getKeyName();

        $fillable = array_merge(
            \is_array($pk) ? $pk : [$pk],

The condition is_array($pk) is always false.

            $model->getFillable()
        );
        $hidden = $model->getHidden();

        if ($model instanceof Translatable && method_exists($model, 'getTranslatedAttributes')) {
            $fillable = array_merge($fillable, $model->getTranslatedAttributes());

It seems like $model->getTranslatedAttributes() can also be of type Illuminate\Database\Eloquent\Builder; however, parameter $array2 of array_merge() does only seem to accept array|null, maybe add an additional type check?

            $hidden = array_merge($hidden, $model->getTranslationModel()->getHidden());
        }

        $fillable = array_unique(array_diff($fillable, $hidden));

        /**
         * Create collection.
         */
        $elements = new MutableCollection($fillable);

        if (property_exists($this, 'includeDateColumns') && $this->includeDateColumns && \count($dates = $model->getDates())) {
            // allow setting specific timestamp: created_at
            if (\is_string($this->includeDateColumns)) {
                $dates = array_intersect($dates, [$this->includeDateColumns]);

                $elements = $elements->merge($dates);
            } else {
                // add timestamps group
                $elements->group('dates', function (Group $group) use ($dates) {
                    $group->merge($dates);

                    return $group;
                });
            }
        }

        return $elements->build(
            new GridDecorator($model)
        );
    }
}