Reader - Code Metrics - Inspection of "47 hidden prompt" - adhocore/php-cli - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#48)

by Jitendra

created 2019-09-07 03:37 UTC

Reader A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes	4
Bugs	0	Features	4

Metric	Value
eloc	12
c	4
b	0
f	4
dl	0
loc	50
rs	10
wmc	7

3 Methods

Rating	Name	Size	Complexity
A	read()	9	4
A	readHidden()	9	1
A	__construct()	3	2

<?php

/*
 * This file is part of the PHP-CLI package.
 *
 * (c) Jitendra Adhikari <[email protected]>
 *     <https://github.com/adhocore>
 *
 * Licensed under MIT license.
 */

namespace Ahc\Cli\Input;

/**
 * Cli Reader.
 *
 * @author  Jitendra Adhikari <[email protected]>
 * @license MIT
 *
 * @link    https://github.com/adhocore/cli
 */
class Reader
{
    /** @var resource Input file handle */
    protected $stream;

    /**
     * Constructor.
     *
     * @param string|null $path Read path. Defaults to STDIN.
     */
    public function __construct(string $path = null)
    {
        $this->stream = $path ? \fopen($path, 'r') : \STDIN;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * Read a line from configured stream (or terminal).
     *
     * @param mixed         $default The default value.
     * @param callable|null $fn      The validator/sanitizer callback.
     *
     * @return mixed
     */
    public function read($default = null, callable $fn = null)
    {
        $in = \rtrim(\fgets($this->stream), "\r\n");

        if ('' === $in && null !== $default) {
            return $default;
        }

        return $fn ? $fn($in) : $in;
    }

    /**
     * Read a line from configured stream (or terminal) but don't echo it back.
     *
     * @param callable|null $fn The validator/sanitizer callback.
     *
     * @return mixed
     */
    public function readHidden($default = null, callable $fn = null)
    {
        \shell_exec('stty -echo');
        $in = $this->read($default, $fn);
        \shell_exec('stty echo');

        echo \PHP_EOL;

        return $in;
    }
}


1			<?php
2
3			/*
4			* This file is part of the PHP-CLI package.
5			*
6			* (c) Jitendra Adhikari <[email protected]>
7			* <https://github.com/adhocore>
8			*
9			* Licensed under MIT license.
10			*/
11
12			namespace Ahc\Cli\Input;
13
14			/**
15			* Cli Reader.
16			*
17			* @author Jitendra Adhikari <[email protected]>
18			* @license MIT
19			*
20			* @link https://github.com/adhocore/cli
21			*/
22			class Reader
23			{
24			/** @var resource Input file handle */
25			protected $stream;
26
27			/**
28			* Constructor.
29			*
30			* @param string\|null $path Read path. Defaults to STDIN.
31			*/
32			public function __construct(string $path = null)
33			{
34			$this->stream = $path ? \fopen($path, 'r') : \STDIN;
			0 ignored issues – show Documentation Bug introduced 2018-07-21 23:25 UTC by Report Bug Copy Issue Report It seems like `$path ? fopen($path, 'r') : STDIN` can also be of type `false`. However, the property `$stream` is declared as type `resource`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
35			}
36
37			/**
38			* Read a line from configured stream (or terminal).
39			*
40			* @param mixed $default The default value.
41			* @param callable\|null $fn The validator/sanitizer callback.
42			*
43			* @return mixed
44			*/
45			public function read($default = null, callable $fn = null)
46			{
47			$in = \rtrim(\fgets($this->stream), "\r\n");
48
49			if ('' === $in && null !== $default) {
50			return $default;
51			}
52
53			return $fn ? $fn($in) : $in;
54			}
55
56			/**
57			* Read a line from configured stream (or terminal) but don't echo it back.
58			*
59			* @param callable\|null $fn The validator/sanitizer callback.
60			*
61			* @return mixed
62			*/
63			public function readHidden($default = null, callable $fn = null)
64			{
65			\shell_exec('stty -echo');
66			$in = $this->read($default, $fn);
67			\shell_exec('stty echo');
68
69			echo \PHP_EOL;
70
71			return $in;
72			}
73			}
74

adhocore / php-cli

Pull Request — master (#48)

Reader A

Complexity

Size/Duplication

Importance

3 Methods

Duplication Side-by-Side

Filter issues like