CollisionHandler::mergeJson() - Code Metrics - Inspection of "Develop" - adhocore/phint - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#13)

by Jitendra

created 2018-07-22 03:59 UTC

CollisionHandler::mergeJson() A

↳ Parent: CollisionHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	2
dl	0
loc	7
rs	10
c	0
b	0
f	0

<?php

namespace Ahc\Phint\Generator;

use Ahc\Phint\Util\Arr;
use Ahc\Phint\Util\Path;

class CollisionHandler implements CollisionHandlerInterface
{
    public function __construct(Path $pathUtil = null)
    {
        $this->pathUtil = $pathUtil ?: new Path;

    }

    /**
     * {@inheritdoc}
     */
    public function handle(string $targetFile, string $newContent, array $parameters = null)
    {
        switch ($this->pathUtil->getExtension($targetFile)) {
            case 'json':
                $this->mergeJson($targetFile, $newContent);
                break;

            case 'md':
                $this->appendFile($targetFile, "\n---\n" . $newContent);
                break;
        }
    }

    protected function mergeJson(string $targetFile, string $newContent)
    {
        $oldJson = $this->pathUtil->readAsJson($targetFile);
        $newJson = \json_decode($newContent, true);
        $merged  = Arr::mergeRecursive($oldJson, $newJson);

        $this->pathUtil->writeFile($targetFile, $merged);
    }

    protected function appendFile(string $targetFile, string $newContent)
    {
        $this->pathUtil->writeFile($targetFile, $newContent, \FILE_APPEND);
    }
}


1			<?php
2
3			namespace Ahc\Phint\Generator;
4
5			use Ahc\Phint\Util\Arr;
6			use Ahc\Phint\Util\Path;
7
8			class CollisionHandler implements CollisionHandlerInterface
9			{
10			public function __construct(Path $pathUtil = null)
11			{
12			$this->pathUtil = $pathUtil ?: new Path;
			0 ignored issues – show Bug Best Practice introduced 2017-10-29 10:46 UTC by Report Bug Copy Issue Report The property `pathUtil` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
13			}
14
15			/**
16			* {@inheritdoc}
17			*/
18			public function handle(string $targetFile, string $newContent, array $parameters = null)
19			{
20			switch ($this->pathUtil->getExtension($targetFile)) {
21			case 'json':
22			$this->mergeJson($targetFile, $newContent);
23			break;
24
25			case 'md':
26			$this->appendFile($targetFile, "\n---\n" . $newContent);
27			break;
28			}
29			}
30
31			protected function mergeJson(string $targetFile, string $newContent)
32			{
33			$oldJson = $this->pathUtil->readAsJson($targetFile);
34			$newJson = \json_decode($newContent, true);
35			$merged = Arr::mergeRecursive($oldJson, $newJson);
36
37			$this->pathUtil->writeFile($targetFile, $merged);
38			}
39
40			protected function appendFile(string $targetFile, string $newContent)
41			{
42			$this->pathUtil->writeFile($targetFile, $newContent, \FILE_APPEND);
43			}
44			}
45

adhocore / phint

Pull Request — master (#13)

CollisionHandler::mergeJson() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like