Factory::isGlobalHelp() - Code Metrics - Inspection of "Cli args parser and tasks manager" - adhocore/phalcon-ext - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#32)

by Jitendra

created 2018-07-05 00:35 UTC

Factory::isGlobalHelp() A

↳ Parent: Factory

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	3
nc	4
nop	1

<?php

namespace PhalconExt\Cli\Middleware;

use Ahc\Cli\Input\Command;
filter:
    dependency_paths: ["lib/*"]
use Phalcon\Cli\Console;
filter:
    dependency_paths: ["lib/*"]
use Phalcon\Cli\Task;
filter:
    dependency_paths: ["lib/*"]
use PhalconExt\Di\ProvidesDi;

/**
 * Factory middleware that injects Parser instance and responses to `--help` or `--version`.
 */
class Factory
{
    use ProvidesDi;

    public function before(Console $console)
    {
        $argv    = $console->argv();
        $app     = $console->app();
        $command = $app->commandFor($argv);

        if ($this->isVersion($argv)) {
            return $command->showVersion();
        }

        if ($this->isGlobalHelp($argv)) {
            return $app->showHelp();
        }

        if ($this->isHelp($argv)) {
            return $command->showHelp();
        }

        $this->di()->setShared('command', $app->parse($argv));

        return true;
    }

    protected function isGlobalHelp(array $argv): bool
    {
        // For a specific help, it would be [cmd, task, action, --help]
        // If it is just [cmd, --help] then we deduce it is global help!

        $isGlobal = ($argv[1][0] ?? '-') === '-' && ($argv[2][0] ?? '-') === '-';

        return $isGlobal && $this->isHelp($argv);
    }

    protected function isHelp(array $argv): bool
    {
        return \in_array('--help', $argv) || \in_array('-h', $argv);
    }

    protected function isVersion(array $argv): bool
    {
        return \in_array('--version', $argv) || \in_array('-V', $argv);
    }
}


1			<?php
2
3			namespace PhalconExt\Cli\Middleware;
4
5			use Ahc\Cli\Input\Command;
			0 ignored issues – show Bug introduced 2018-07-05 00:37 UTC by Report Bug Copy Issue Report The type `Ahc\Cli\Input\Command` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
6			use Phalcon\Cli\Console;
			0 ignored issues – show Bug introduced 2018-07-05 00:30 UTC by Report Bug Copy Issue Report The type `Phalcon\Cli\Console` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
7			use Phalcon\Cli\Task;
			0 ignored issues – show Bug introduced 2018-07-05 00:30 UTC by Report Bug Copy Issue Report The type `Phalcon\Cli\Task` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8			use PhalconExt\Di\ProvidesDi;
9
10			/**
11			* Factory middleware that injects Parser instance and responses to `--help` or `--version`.
12			*/
13			class Factory
14			{
15			use ProvidesDi;
16
17			public function before(Console $console)
18			{
19			$argv = $console->argv();
20			$app = $console->app();
21			$command = $app->commandFor($argv);
22
23			if ($this->isVersion($argv)) {
24			return $command->showVersion();
25			}
26
27			if ($this->isGlobalHelp($argv)) {
28			return $app->showHelp();
29			}
30
31			if ($this->isHelp($argv)) {
32			return $command->showHelp();
33			}
34
35			$this->di()->setShared('command', $app->parse($argv));
36
37			return true;
38			}
39
40			protected function isGlobalHelp(array $argv): bool
41			{
42			// For a specific help, it would be [cmd, task, action, --help]
43			// If it is just [cmd, --help] then we deduce it is global help!
44
45			$isGlobal = ($argv[1][0] ?? '-') === '-' && ($argv[2][0] ?? '-') === '-';
46
47			return $isGlobal && $this->isHelp($argv);
48			}
49
50			protected function isHelp(array $argv): bool
51			{
52			return \in_array('--help', $argv) \|\| \in_array('-h', $argv);
53			}
54
55			protected function isVersion(array $argv): bool
56			{
57			return \in_array('--version', $argv) \|\| \in_array('-V', $argv);
58			}
59			}
60

adhocore / phalcon-ext

Pull Request — master (#32)

Factory::isGlobalHelp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like