adhocore /
htmlup
| Total Complexity | 49 |
| Total Lines | 226 |
| Duplicated Lines | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 1 |
Complex classes like BlockElementParser often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use BlockElementParser, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | abstract class BlockElementParser |
||
| 15 | { |
||
| 16 | use HtmlHelper; |
||
| 17 | |||
| 18 | const RE_MD_QUOTE = '~^\s*(>+)\s+~'; |
||
| 19 | const RE_RAW = '/^<\/?\w.*?\/?>/'; |
||
| 20 | const RE_MD_SETEXT = '~^\s*(={3,}|-{3,})\s*$~'; |
||
| 21 | const RE_MD_CODE = '/^```\s*([\w-]+)?/'; |
||
| 22 | const RE_MD_RULE = '~^(_{3,}|\*{3,}|\-{3,})$~'; |
||
| 23 | const RE_MD_TCOL = '~(\|\s*\:)?\s*\-{3,}\s*(\:\s*\|)?~'; |
||
| 24 | const RE_MD_OL = '/^\d+\. /'; |
||
| 25 | |||
| 26 | protected $lines = []; |
||
| 27 | protected $stackList = []; |
||
| 28 | protected $stackBlock = []; |
||
| 29 | protected $stackTable = []; |
||
| 30 | |||
| 31 | protected $pointer = -1; |
||
| 32 | protected $listLevel = 0; |
||
| 33 | protected $quoteLevel = 0; |
||
| 34 | protected $indent = 0; |
||
| 35 | protected $nextIndent = 0; |
||
| 36 | protected $indentLen = 4; |
||
| 37 | |||
| 38 | protected $indentStr = ' '; |
||
| 39 | protected $line = ''; |
||
| 40 | protected $trimmedLine = ''; |
||
| 41 | protected $prevLine = ''; |
||
| 42 | protected $trimmedPrevLine = ''; |
||
| 43 | protected $nextLine = ''; |
||
| 44 | protected $trimmedNextLine = ''; |
||
| 45 | protected $markup = ''; |
||
| 46 | |||
| 47 | protected $inList = \false; |
||
| 48 | protected $inQuote = \false; |
||
| 49 | protected $inPara = \false; |
||
| 50 | protected $inHtml = \false; |
||
| 51 | protected $inTable = \false; |
||
| 52 | |||
| 53 | protected function parseBlockElements() |
||
| 54 | { |
||
| 55 | while (isset($this->lines[++$this->pointer])) { |
||
| 56 | $this->init(); |
||
|
Bug
introduced
by
|
|||
| 57 | |||
| 58 | if ($this->flush() || $this->raw()) { |
||
| 59 | continue; |
||
| 60 | } |
||
| 61 | |||
| 62 | $this->quote(); |
||
| 63 | |||
| 64 | if (($block = $this->isBlock()) || $this->inList) { |
||
| 65 | $this->markup .= $block ? '' : $this->trimmedLine; |
||
| 66 | |||
| 67 | continue; |
||
| 68 | } |
||
| 69 | |||
| 70 | $this->table() || $this->paragraph(); |
||
| 71 | } |
||
| 72 | } |
||
| 73 | |||
| 74 | protected function isBlock() |
||
| 77 | } |
||
| 78 | |||
| 79 | protected function atx() |
||
| 80 | { |
||
| 81 | if (\substr($this->trimmedLine, 0, 1) === '#') { |
||
| 82 | $level = \strlen($this->trimmedLine) - \strlen(\ltrim($this->trimmedLine, '#')); |
||
| 83 | $head = $this->h($level, $this->trimmedLine); |
||
| 84 | |||
| 85 | $this->markup .= $head; |
||
| 86 | |||
| 87 | return (bool) $head; |
||
| 88 | } |
||
| 89 | } |
||
| 90 | |||
| 91 | protected function setext() |
||
| 99 | } |
||
| 100 | } |
||
| 101 | |||
| 102 | protected function code() |
||
| 121 | } |
||
| 122 | } |
||
| 123 | |||
| 124 | private function codeInternal($codeBlock) |
||
| 125 | { |
||
| 126 | while (isset($this->lines[$this->pointer + 1])) { |
||
| 127 | $this->line = $this->escape($this->lines[$this->pointer + 1]); |
||
| 128 | |||
| 129 | if (($codeBlock && \substr(\ltrim($this->line), 0, 3) !== '```') |
||
| 130 | || \strpos($this->line, $this->indentStr) === 0 |
||
| 131 | ) { |
||
| 132 | $this->markup .= $this->codeLine($this->line, $codeBlock, $this->indentLen); |
||
| 133 | |||
| 134 | $this->pointer++; |
||
| 135 | |||
| 136 | continue; |
||
| 137 | } |
||
| 138 | |||
| 139 | break; |
||
| 140 | } |
||
| 141 | } |
||
| 142 | |||
| 143 | protected function rule() |
||
| 144 | { |
||
| 145 | $this->markup .= $hr = $this->hr($this->trimmedPrevLine, $this->trimmedLine); |
||
| 146 | |||
| 147 | return (bool) $hr; |
||
| 148 | } |
||
| 149 | |||
| 150 | protected function listt() |
||
| 171 | } |
||
| 172 | } |
||
| 173 | |||
| 174 | private function listInternal() |
||
| 175 | { |
||
| 176 | $isUl = \in_array(\substr($this->trimmedNextLine, 0, 2), ['- ', '* ', '+ ']); |
||
| 177 | |||
| 178 | if ($isUl || \preg_match(static::RE_MD_OL, $this->trimmedNextLine)) { |
||
| 179 | $wrapper = $isUl ? 'ul' : 'ol'; |
||
| 180 | if ($this->nextIndent > $this->indent) { |
||
| 181 | $this->stackList[] = "</li>\n"; |
||
| 182 | $this->stackList[] = "</$wrapper>"; |
||
| 183 | $this->markup .= "\n<$wrapper>\n"; |
||
| 184 | |||
| 185 | $this->listLevel++; |
||
| 186 | } else { |
||
| 187 | $this->markup .= "</li>\n"; |
||
| 188 | } |
||
| 189 | |||
| 190 | if ($this->nextIndent < $this->indent) { |
||
| 191 | $shift = \intval(($this->indent - $this->nextIndent) / $this->indentLen); |
||
| 192 | |||
| 193 | while ($shift--) { |
||
| 194 | $this->markup .= \array_pop($this->stackList); |
||
| 195 | |||
| 196 | if ($this->listLevel > 2) { |
||
| 197 | $this->markup .= \array_pop($this->stackList); |
||
| 198 | } |
||
| 199 | } |
||
| 200 | } |
||
| 201 | } else { |
||
| 202 | $this->markup .= "</li>\n"; |
||
| 203 | } |
||
| 204 | } |
||
| 205 | |||
| 206 | protected function table() |
||
| 227 | } |
||
| 228 | |||
| 229 | private function tableInternal($headerCount) |
||
| 240 | } |
||
| 241 | } |
||
| 243 |
Loading history...