Ae\FeatureBundle\Command\CreateFeatureCommand

Complexity

Total Complexity

3

Size/Duplication

Total Lines	77
Duplicated Lines	100 %

Coupling/Cohesion

Components	2
Dependencies	6

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	9	9	1
A	configure()	20	20	1
A	execute()	23	23	1

<?php

namespace Ae\FeatureBundle\Command;

use Ae\FeatureBundle\Entity\FeatureManager;
use Doctrine\ORM\EntityManager;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Command used to create a feature.
 *
 * @author Emanuele Minotto <emanuele@adespresso.com>
 */
class CreateFeatureCommand extends Command

This class seems to be duplicated in your project.

{
    /**
     * @var FeatureManager
     */
    private $featureManager;

    /**
     * @var EntityManager
     */
    private $entityManager;

    /**
     * @param FeatureManager $featureManager
     * @param EntityManager  $entityManager
     */
    public function __construct(
        FeatureManager $featureManager,
        EntityManager $entityManager

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    ) {
        parent::__construct();

        $this->featureManager = $featureManager;
        $this->entityManager = $entityManager;
    }

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setName('features:create')
            ->setDescription('Create a new feature')
            ->addArgument('parent', InputArgument::REQUIRED, 'Parent feature')
            ->addArgument('name', InputArgument::REQUIRED, 'Feature name')
            ->addOption(
                'enabled',
                null,
                InputOption::VALUE_NONE,
                'The feature will be created as enabled'
            )
            ->addOption(
                'role',
                null,
                InputOption::VALUE_REQUIRED,
                'The feature will be only for a role'
            );
    }

    /**
     * {@inheritdoc}
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $name = $input->getArgument('name');
        $parent = $input->getArgument('parent');

        $output->write(sprintf(
            'Creating <info>%s</info>.<info>%s</info>... ',
            $parent,
            $name
        ));

        $feature = $this->featureManager->findOrCreate($name, $parent);

        $feature->setEnabled($input->getOption('enabled'));
        $feature->setRole($input->getOption('role'));

        $this->entityManager->persist($feature);
        $this->entityManager->flush();

        $this->featureManager->emptyCache($name, $parent);

        $output->writeln('OK');
    }
}