FeatureSecurity::__construct() - Code Metrics - Inspection of "Restore some Breaking Changes" - adespresso/FeatureBundle - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#41)

by Emanuele

created 2018-05-04 12:21 UTC

FeatureSecurity::__construct() A

↳ Parent: FeatureSecurity

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace Ae\FeatureBundle\Security;

use Ae\FeatureBundle\Entity\Feature;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;

/**
 * Controls access to a Feature.
 *
 * @author Carlo Forghieri <[email protected]>
 */
class FeatureSecurity
{
    /**
     * @param AuthorizationCheckerInterface|null
     */
    protected $context;

    /**
     * @param AuthorizationCheckerInterface $context
     */
    public function __construct(AuthorizationCheckerInterface $context = null)
    {
        $this->context = $context;
    }

    /**
     * @param Feature $feature
     *
     * @return bool
     */
    public function isGranted(Feature $feature)
    {
        if (null === $this->context) {
            return false;
        }

        if (!$feature->isEnabled()) {
            return false;
        }

        if ($feature->getRole()) {
            if (!$this->context->isGranted($feature->getRole())) {
                return false;
            }
        }

        if ('' !== trim($feature->getParentRole())) {
            if (!$this->context->isGranted($feature->getParentRole())) {
                return false;
            }
        }

        return true;
    }
}


1		<?php
2
3		namespace Ae\FeatureBundle\Security;
4
5		use Ae\FeatureBundle\Entity\Feature;
6		use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
7
8		/**
9		* Controls access to a Feature.
10		*
11		* @author Carlo Forghieri <[email protected]>
12		*/
13		class FeatureSecurity
14		{
15		/**
16		* @param AuthorizationCheckerInterface\|null
17		*/
18		protected $context;
19
20		/**
21		* @param AuthorizationCheckerInterface $context
22		*/
23	8	public function __construct(AuthorizationCheckerInterface $context = null)
24		{
25	8	$this->context = $context;
26	8	}
27
28		/**
29		* @param Feature $feature
30		*
31		* @return bool
32		*/
33	8	public function isGranted(Feature $feature)
34		{
35	8	if (null === $this->context) {
36		return false;
37		}
38
39	8	if (!$feature->isEnabled()) {
40	2	return false;
41		}
42
43	6	if ($feature->getRole()) {
44	4	if (!$this->context->isGranted($feature->getRole())) {
45		return false;
46		}
47		}
48
49	6	if ('' !== trim($feature->getParentRole())) {
50	2	if (!$this->context->isGranted($feature->getParentRole())) {
51	2	return false;
52		}
53		}
54
55	4	return true;
56		}
57		}
58

adespresso / FeatureBundle

Pull Request — master (#41)

FeatureSecurity::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like