Feature::isGrantedForUser() - Code Metrics - Inspection of "Add utility isGrantedForUser" - adespresso/FeatureBundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#47)

by Emanuele

created 2019-02-25 20:48 UTC

Feature::isGrantedForUser() A

↳ Parent: Feature

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	3
dl	0
loc	9
ccs	0
cts	0
cp	0
crap	6
rs	10
c	0
b	0
f	0

<?php

namespace Ae\FeatureBundle\Service;

use Ae\FeatureBundle\Entity\Feature as FeatureEntity;
use Ae\FeatureBundle\Entity\FeatureManager;
use Ae\FeatureBundle\Security\FeatureSecurity;
use Exception;
use Symfony\Component\Security\Core\User\UserInterface;

/**
 * @author Carlo Forghieri <[email protected]>
 */
class Feature implements FeatureInterface
{
    /**
     * @var FeatureManager
     */
    protected $manager;

    /**
     * @var FeatureSecurity
     */
    protected $security;

    /**
     * @param FeatureManager  $manager
     * @param FeatureSecurity $security
     */
    public function __construct(
        FeatureManager $manager,
        FeatureSecurity $security
    ) {
        $this->manager = $manager;
        $this->security = $security;
    }

    /**
     * Check if a feature (defined by name/parent) is granted to the logged user.
     *
     * @param string $name
     * @param string $parent
     *
     * @return bool
     */
    public function isGranted($name, $parent)
    {
        try {
            return $this->security->isGranted(
                $this->manager->find($name, $parent)
            );
        } catch (Exception $exception) {
            return false;
        }
    }

    public function isGrantedForUser(string $name, string $parent, UserInterface $user): bool
    {
        $feature = $this->manager->find($name, $parent);

        if (!$feature instanceof FeatureEntity) {

            return false;
        }

        return $this->security->isGrantedForUser($feature, $user);
    }
}


1		<?php
2
3		namespace Ae\FeatureBundle\Service;
4
5		use Ae\FeatureBundle\Entity\Feature as FeatureEntity;
6		use Ae\FeatureBundle\Entity\FeatureManager;
7		use Ae\FeatureBundle\Security\FeatureSecurity;
8		use Exception;
9		use Symfony\Component\Security\Core\User\UserInterface;
10
11		/**
12		* @author Carlo Forghieri <[email protected]>
13		*/
14		class Feature implements FeatureInterface
15		{
16		/**
17		* @var FeatureManager
18		*/
19		protected $manager;
20
21		/**
22		* @var FeatureSecurity
23		*/
24		protected $security;
25
26		/**
27		* @param FeatureManager $manager
28	2	* @param FeatureSecurity $security
29		*/
30		public function __construct(
31		FeatureManager $manager,
32	2	FeatureSecurity $security
33	2	) {
34	2	$this->manager = $manager;
35		$this->security = $security;
36		}
37
38		/**
39		* Check if a feature (defined by name/parent) is granted to the logged user.
40		*
41		* @param string $name
42		* @param string $parent
43		*
44	2	* @return bool
45		*/
46		public function isGranted($name, $parent)
47	2	{
48	2	try {
49		return $this->security->isGranted(
50		$this->manager->find($name, $parent)
51		);
52		} catch (Exception $exception) {
53		return false;
54		}
55		}
56
57		public function isGrantedForUser(string $name, string $parent, UserInterface $user): bool
58		{
59		$feature = $this->manager->find($name, $parent);
60
61		if (!$feature instanceof FeatureEntity) {
		0 ignored issues – show introduced 2019-02-25 09:45 UTC by Report Bug Copy Issue Report `$feature` is always a sub-type of `Ae\FeatureBundle\Entity\Feature`. Loading history...
62		return false;
63		}
64
65		return $this->security->isGrantedForUser($feature, $user);
66		}
67		}
68

adespresso / FeatureBundle

Pull Request — master (#47)

Feature::isGrantedForUser() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like