CheckPending::__construct() - Code Metrics - Inspection of "Merge pull request #4 from adelowo/pending_charge" - adelowo/gbowo-paystack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a5479d...1a3f52 )

by Lanre

created 2017-07-25 08:41 UTC

CheckPending::__construct() A

↳ Parent: CheckPending

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	4
loc	4
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace Paystack\Customer;

use Gbowo\Adapter\Paystack\Traits\VerifyHttpStatusResponseCode;
use Gbowo\Plugin\AbstractPlugin;
use function GuzzleHttp\json_encode;
use function GuzzleHttp\json_decode;

class CheckPending extends AbstractPlugin

{
    use VerifyHttpStatusResponseCode;

    const GET_PENDING_CHARGE_ENDPOINT = "/charge/:ref";

    protected $baseUrl;

    public function __construct(string $baseUrl)
    {
        $this->baseUrl = $baseUrl;
    }

    public function getPluginAccessor(): string
    {
        return "checkPending";
    }

    public function handle(string $reference)
    {
        $response = $this->adapter->getHttpClient()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->get($this->baseUrl . str_replace(":ref", $reference, self::GET_PENDING_CHARGE_ENDPOINT));

        $this->verifyResponse($response);

        return json_decode($response->getBody(), true)["data"];
    }
}


1			<?php
2
3			namespace Paystack\Customer;
4
5			use Gbowo\Adapter\Paystack\Traits\VerifyHttpStatusResponseCode;
6			use Gbowo\Plugin\AbstractPlugin;
7			use function GuzzleHttp\json_encode;
8			use function GuzzleHttp\json_decode;
9
10		View Code Duplication	class CheckPending extends AbstractPlugin
			0 ignored issues – show Duplication introduced 2017-07-25 08:42 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11			{
12			use VerifyHttpStatusResponseCode;
13
14			const GET_PENDING_CHARGE_ENDPOINT = "/charge/:ref";
15
16			protected $baseUrl;
17
18	2		public function __construct(string $baseUrl)
19			{
20	2		$this->baseUrl = $baseUrl;
21	2		}
22
23	2		public function getPluginAccessor(): string
24			{
25	2		return "checkPending";
26			}
27
28	2		public function handle(string $reference)
29			{
30	2		$response = $this->adapter->getHttpClient()
			0 ignored issues – show Bug introduced 2017-03-03 20:45 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Gbowo\Contract\Adapter\AdapterInterface` as the method `getHttpClient()` does only exist in the following implementations of said interface: `Gbowo\Adapter\Amplifypay\AmplifypayAdapter`, `Gbowo\Adapter\Paystack\PaystackAdapter`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
31	2		->get($this->baseUrl . str_replace(":ref", $reference, self::GET_PENDING_CHARGE_ENDPOINT));
32
33	2		$this->verifyResponse($response);
34
35	1		return json_decode($response->getBody(), true)["data"];
36			}
37			}
38

adelowo / gbowo-paystack

GitHub Access Token became invalid

Push — master ( a5479d...1a3f52 )

CheckPending::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like