ExportTransactions::handle() - Code Metrics - adelowo/gbowo-paystack - Measure and Improve Code Quality continuously with Scrutinizer

ExportTransactions::handle() A
last analyzed 2017-07-25 08:43 UTC

↳ Parent: ExportTransactions

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	1
crap	1

<?php

namespace Paystack\Transaction;

use Gbowo\Adapter\Paystack\Traits\VerifyHttpStatusResponseCode;
use GuzzleHttp\json_decode;
use Gbowo\Plugin\AbstractPlugin;
use Psr\Http\Message\ResponseInterface;

class ExportTransactions extends AbstractPlugin
{

    use VerifyHttpStatusResponseCode;

    const TRANSACTION_ENDPOINT = "/transaction/export";

    protected $baseUrl;

    public function __construct(string $baseUrl)
    {
        $this->baseUrl = $baseUrl;
    }

    public function getPluginAccessor(): string
    {
        return "exportTransactions";
    }

    public function handle(array $params = [])
    {

        $link = $this->baseUrl . self::TRANSACTION_ENDPOINT . \Gbowo\toQueryParams($params);

        $response = $this->getExportedTransactions($link);

        $this->verifyResponse($response);

        return json_decode($response->getBody(), true)["data"]["path"];
    }

    protected function getExportedTransactions(string $link): ResponseInterface
    {
        return $this->adapter->getHttpClient()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->get($link);
    }
}


1		<?php
2
3		namespace Paystack\Transaction;
4
5		use Gbowo\Adapter\Paystack\Traits\VerifyHttpStatusResponseCode;
6		use GuzzleHttp\json_decode;
7		use Gbowo\Plugin\AbstractPlugin;
8		use Psr\Http\Message\ResponseInterface;
9
10		class ExportTransactions extends AbstractPlugin
11		{
12
13		use VerifyHttpStatusResponseCode;
14
15		const TRANSACTION_ENDPOINT = "/transaction/export";
16
17		protected $baseUrl;
18
19	2	public function __construct(string $baseUrl)
20		{
21	2	$this->baseUrl = $baseUrl;
22	2	}
23
24	2	public function getPluginAccessor(): string
25		{
26	2	return "exportTransactions";
27		}
28
29	2	public function handle(array $params = [])
30		{
31
32	2	$link = $this->baseUrl . self::TRANSACTION_ENDPOINT . \Gbowo\toQueryParams($params);
33
34	2	$response = $this->getExportedTransactions($link);
35
36	2	$this->verifyResponse($response);
37
38	1	return json_decode($response->getBody(), true)["data"]["path"];
39		}
40
41	2	protected function getExportedTransactions(string $link): ResponseInterface
42		{
43	2	return $this->adapter->getHttpClient()
		0 ignored issues – show Bug introduced 2017-03-03 20:45 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Gbowo\Contract\Adapter\AdapterInterface` as the method `getHttpClient()` does only exist in the following implementations of said interface: `Gbowo\Adapter\Amplifypay\AmplifypayAdapter`, `Gbowo\Adapter\Paystack\PaystackAdapter`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
44	2	->get($link);
45		}
46		}
47

adelowo / gbowo-paystack

GitHub Access Token became invalid

ExportTransactions::handle() A last analyzed 2017-07-25 08:43 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

ExportTransactions::handle() A
last analyzed 2017-07-25 08:43 UTC