CreateSubscription::makeBodyParams() - Code Metrics - adelowo/gbowo-paystack - Measure and Improve Code Quality continuously with Scrutinizer

CreateSubscription::makeBodyParams() A
last analyzed 2017-07-25 08:43 UTC

↳ Parent: CreateSubscription

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	3
crap	2

<?php

namespace Paystack\Subscription;

use Gbowo\Adapter\Paystack\Traits\VerifyHttpStatusResponseCode;
use function GuzzleHttp\json_encode;
use function GuzzleHttp\json_decode;
use Gbowo\Plugin\AbstractPlugin;

class CreateSubscription extends AbstractPlugin
{
    use VerifyHttpStatusResponseCode;

    const CREATE_SUBSCRIPTION_ENDPOINT = "/subscription";

    protected $baseUrl;

    public function __construct(string $baseUrl)
    {
        $this->baseUrl = $baseUrl;
    }

    public function getPluginAccessor(): string
    {
        return "createSubscription";
    }

    public function handle(
        string $customerIdentifier,
        string $planCode,
        string $customerAuth = ""
    ) {

        $response = $this->adapter->getHttpClient()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->post($this->baseUrl . self::CREATE_SUBSCRIPTION_ENDPOINT, [
                "body" => json_encode($this->makeBodyParams($customerIdentifier, $planCode, $customerAuth))
            ]);

        $this->verifyResponse($response);

        return json_decode($response->getBody(), true)["data"];
    }

    protected function makeBodyParams(
        string $customerIdentifier,
        string $planCode,
        string $customerAuth
    ): array {
        $bodyParams = ["customer" => $customerIdentifier, "plan" => $planCode];

        if ($customerAuth) {
            $bodyParams["authorization"] = $customerAuth;
        }

        return $bodyParams;
    }
}


1		<?php
2
3		namespace Paystack\Subscription;
4
5		use Gbowo\Adapter\Paystack\Traits\VerifyHttpStatusResponseCode;
6		use function GuzzleHttp\json_encode;
7		use function GuzzleHttp\json_decode;
8		use Gbowo\Plugin\AbstractPlugin;
9
10		class CreateSubscription extends AbstractPlugin
11		{
12		use VerifyHttpStatusResponseCode;
13
14		const CREATE_SUBSCRIPTION_ENDPOINT = "/subscription";
15
16		protected $baseUrl;
17
18	2	public function __construct(string $baseUrl)
19		{
20	2	$this->baseUrl = $baseUrl;
21	2	}
22
23	2	public function getPluginAccessor(): string
24		{
25	2	return "createSubscription";
26		}
27
28	2	public function handle(
29		string $customerIdentifier,
30		string $planCode,
31		string $customerAuth = ""
32		) {
33
34	2	$response = $this->adapter->getHttpClient()
		0 ignored issues – show Bug introduced 2017-03-03 20:45 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Gbowo\Contract\Adapter\AdapterInterface` as the method `getHttpClient()` does only exist in the following implementations of said interface: `Gbowo\Adapter\Amplifypay\AmplifypayAdapter`, `Gbowo\Adapter\Paystack\PaystackAdapter`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
35	2	->post($this->baseUrl . self::CREATE_SUBSCRIPTION_ENDPOINT, [
36	2	"body" => json_encode($this->makeBodyParams($customerIdentifier, $planCode, $customerAuth))
37		]);
38
39	2	$this->verifyResponse($response);
40
41	1	return json_decode($response->getBody(), true)["data"];
42		}
43
44	2	protected function makeBodyParams(
45		string $customerIdentifier,
46		string $planCode,
47		string $customerAuth
48		): array {
49	2	$bodyParams = ["customer" => $customerIdentifier, "plan" => $planCode];
50
51	2	if ($customerAuth) {
52	1	$bodyParams["authorization"] = $customerAuth;
53		}
54
55	2	return $bodyParams;
56		}
57		}
58

adelowo / gbowo-paystack

GitHub Access Token became invalid

CreateSubscription::makeBodyParams() A last analyzed 2017-07-25 08:43 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

CreateSubscription::makeBodyParams() A
last analyzed 2017-07-25 08:43 UTC