Adelf\LaravelMenu\LaravelMenuFilterFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	3	1
A	addFilter()	0	3	1

<?php

namespace Adelf\LaravelMenu;

use Adelf\LaravelMenu\Filters\LaravelMenuFilter;

final class LaravelMenuFilterFactory
{
    /**
     * @var array
     */
    private static $filters = [];

    /**
     * @param string $name
     * @param string | LaravelMenuFilter $filter class name or object - LaravelMenuFilter instance
     */
    public static function addFilter(string $name, $filter)
    {
        self::$filters[$name] = $filter;
    }

    /**
     * @param string $name
     * @return LaravelMenuFilter
     */
    public function create(string $name): LaravelMenuFilter
    {
        return app(self::$filters[$name]);

The expression return app(self::filters[$name]) could return the type Illuminate\Foundation\Application which is incompatible with the type-hinted return Adelf\LaravelMenu\Filters\LaravelMenuFilter. Consider adding an additional type-check to rule them out.

    }
}