Proposal::setJob() - Code Metrics - Inspection of "merge" - adelf/freelance-example - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3373e3...1218bb )

by Adel

created 2019-01-23 19:02 UTC

Proposal::setJob() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace App\Domain\Entities;

use App\Exceptions\Job\SameFreelancerProposalException;
use Doctrine\ORM\Mapping AS ORM;
use App\Domain\ValueObjects\Money;

/**
 * @ORM\Entity()
 */
final class Proposal
{
    /**
     * @var int
     * @ORM\Id
     * @ORM\Column(type="integer", unique=true)
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    private $id;


    /**
     * @ORM\ManyToOne(targetEntity="Job", inversedBy="proposals")
     * @ORM\JoinColumn(name="job_id", referencedColumnName="id")
     */
    private $job;

    /**
     * @var Freelancer
     * @ORM\ManyToOne(targetEntity="App\Domain\Entities\Freelancer")
     * @ORM\JoinColumn(nullable=false)
     */
    private $freelancer;

    /**
     * @var Money
     * @ORM\Embedded(class = "App\Domain\ValueObjects\Money")
     */
    private $hourRate;

    /**
     * @var string
     * @ORM\Column(type="string")
     */
    private $coverLetter;

    public function __construct(Job $job, Freelancer $freelancer, Money $hourRate, string $coverLetter)
    {
        $this->job = $job;
        $this->freelancer = $freelancer;
        $this->hourRate = $hourRate;
        $this->coverLetter = $coverLetter;
    }

    /**
     * @param \App\Domain\Entities\Proposal $other
     * @throws SameFreelancerProposalException
     */
    public function checkCompatibility(Proposal $other)
    {
        if ($this->freelancer->equals($other->freelancer)) {
            throw new SameFreelancerProposalException();
        }
    }
}

1			<?php
2
3			namespace App\Domain\Entities;
4
5			use App\Exceptions\Job\SameFreelancerProposalException;
6			use Doctrine\ORM\Mapping AS ORM;
7			use App\Domain\ValueObjects\Money;
8
9			/**
10			* @ORM\Entity()
11			*/
12			final class Proposal
13			{
14			/**
15			* @var int
16			* @ORM\Id
17			* @ORM\Column(type="integer", unique=true)
18			* @ORM\GeneratedValue(strategy="AUTO")
19			*/
20			private $id;
			0 ignored issues – show introduced 2019-01-23 19:05 UTC by Report Bug Copy Issue Report The private property `$id` is not used, and could be removed. Loading history...
21
22			/**
23			* @ORM\ManyToOne(targetEntity="Job", inversedBy="proposals")
24			* @ORM\JoinColumn(name="job_id", referencedColumnName="id")
25			*/
26			private $job;
27
28			/**
29			* @var Freelancer
30			* @ORM\ManyToOne(targetEntity="App\Domain\Entities\Freelancer")
31			* @ORM\JoinColumn(nullable=false)
32			*/
33			private $freelancer;
34
35			/**
36			* @var Money
37			* @ORM\Embedded(class = "App\Domain\ValueObjects\Money")
38			*/
39			private $hourRate;
40
41			/**
42			* @var string
43			* @ORM\Column(type="string")
44			*/
45			private $coverLetter;
46
47			public function __construct(Job $job, Freelancer $freelancer, Money $hourRate, string $coverLetter)
48			{
49			$this->job = $job;
50			$this->freelancer = $freelancer;
51			$this->hourRate = $hourRate;
52			$this->coverLetter = $coverLetter;
53			}
54
55			/**
56			* @param \App\Domain\Entities\Proposal $other
57			* @throws SameFreelancerProposalException
58			*/
59			public function checkCompatibility(Proposal $other)
60			{
61			if ($this->freelancer->equals($other->freelancer)) {
62			throw new SameFreelancerProposalException();
63			}
64			}
65			}

adelf / freelance-example

Push — master ( 3373e3...1218bb )

Proposal::setJob() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like