Ofx::__construct() - Code Metrics - Inspection of "Leve gambiarra para implementar o JsonSerialize" - adelarcubs/ofxparser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f5773e...1d76e5 )

by Adelar

created 2017-04-26 19:50 UTC

Ofx::__construct() A

↳ Parent: Ofx

Complexity

Conditions	3
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
ccs	10
cts	10
cp	1
rs	9.4285
cc	3
eloc	7
nc	4
nop	1
crap	3

<?php
namespace Adelarcubs\OFXParser;

use JsonSerializable;
use SimpleXMLElement;

/**
 *
 * @author Adelar Tiemann Junior <[email protected]>
 */
class Ofx implements JsonSerializable
{

    public $ofx;

    private $movements = [];

    public function __construct(SimpleXMLElement $xml)
    {
        $this->ofx = $xml;

        if (isset($this->ofx->BANKMSGSRSV1->STMTTRNRS->STMTRS->BANKTRANLIST->STMTTRN)) {
            $movements = $this->ofx->BANKMSGSRSV1->STMTTRNRS->STMTRS->BANKTRANLIST->STMTTRN;
        }
        if (isset($this->ofx->CREDITCARDMSGSRSV1->CCSTMTTRNRS->CCSTMTRS->BANKTRANLIST)) {
            $movements = $this->ofx->CREDITCARDMSGSRSV1->CCSTMTTRNRS->CCSTMTRS->BANKTRANLIST;
        }

        $this->exportMovements($movements);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    public function getMovements()
    {
        return $this->movements;
    }

    private function exportMovements(SimpleXMLElement $xml)
    {
        foreach ($xml as $value) {
            $this->movements[] = new OfxMovement($value);
        }
    }

    public function jsonSerialize()
    {
        return json_decode(json_encode($this->ofx), true);
    }
}


1		<?php
2		namespace Adelarcubs\OFXParser;
3
4		use JsonSerializable;
5		use SimpleXMLElement;
6
7		/**
8		*
9		* @author Adelar Tiemann Junior <[email protected]>
10		*/
11		class Ofx implements JsonSerializable
12		{
13
14		public $ofx;
15
16		private $movements = [];
17
18	4	public function __construct(SimpleXMLElement $xml)
19		{
20	4	$this->ofx = $xml;
21
22	4	if (isset($this->ofx->BANKMSGSRSV1->STMTTRNRS->STMTRS->BANKTRANLIST->STMTTRN)) {
23	3	$movements = $this->ofx->BANKMSGSRSV1->STMTTRNRS->STMTRS->BANKTRANLIST->STMTTRN;
24	3	}
25	4	if (isset($this->ofx->CREDITCARDMSGSRSV1->CCSTMTTRNRS->CCSTMTRS->BANKTRANLIST)) {
26	1	$movements = $this->ofx->CREDITCARDMSGSRSV1->CCSTMTTRNRS->CCSTMTRS->BANKTRANLIST;
27	1	}
28
29	4	$this->exportMovements($movements);
		0 ignored issues – show Bug introduced 2017-04-26 19:52 UTC by Report Bug Copy Issue Report The variable `$movements` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
30	4	}
31
32	4	public function getMovements()
33		{
34	4	return $this->movements;
35		}
36
37	4	private function exportMovements(SimpleXMLElement $xml)
38		{
39	4	foreach ($xml as $value) {
40	4	$this->movements[] = new OfxMovement($value);
41	4	}
42	4	}
43
44		public function jsonSerialize()
45		{
46		return json_decode(json_encode($this->ofx), true);
47		}
48		}
49

adelarcubs / ofxparser

Push — master ( f5773e...1d76e5 )

Ofx::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like