OfxTest - Code Metrics - Inspection of "Mais alguns ajustes nos testes, agora valida a exc..." - adelarcubs/ofxparser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 77f799...365b3d )

by Adelar

created 2015-12-05 22:22 UTC

OfxTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
wmc	3
c	3
b	0
f	0
lcom	1
cbo	2
dl	0
loc	26
rs	10

3 Methods

Rating	Name	Size	Complexity
A	setUp()	5	1
A	constructorShouldConfigureAttributes()	4	1
A	invalidFile()	3	1

<?php
namespace Adelarcubs\OFXParser;

use PHPUnit_Framework_TestCase;
use SimpleXMLElement;

/**
 *
 * @author Adelar Tiemann Junior <[email protected]>
 */
class OfxTest extends PHPUnit_Framework_TestCase
{

    private $ofx;

    protected function setUp()
    {
        // $this->ofx = new Ofx(new SimpleXMLElement('fixtures/data.ofx'));
        $this->ofx = Ofx::loadFromFile(__DIR__ . '/fixtures/data.ofx');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @test
     */
    public function constructorShouldConfigureAttributes()
    {
        $this->assertInstanceOf(Ofx::class, $this->ofx);
    }
    /**
     * @test
     * @expectedException InvalidArgumentException
     */
    public function invalidFile(){
        $ofx = Ofx::loadFromFile('Anywhere');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2			namespace Adelarcubs\OFXParser;
3
4			use PHPUnit_Framework_TestCase;
5			use SimpleXMLElement;
6
7			/**
8			*
9			* @author Adelar Tiemann Junior <[email protected]>
10			*/
11			class OfxTest extends PHPUnit_Framework_TestCase
12			{
13
14			private $ofx;
15
16			protected function setUp()
17			{
18			// $this->ofx = new Ofx(new SimpleXMLElement('fixtures/data.ofx'));
19			$this->ofx = Ofx::loadFromFile(__DIR__ . '/fixtures/data.ofx');
			0 ignored issues – show Documentation introduced 2015-12-05 22:11 UTC by Report Bug Copy Issue Report `__DIR__ . '/fixtures/data.ofx'` is of type `string`, but the function expects a `object<Adelarcubs\OFXParser\unknown>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
20			}
21
22			/**
23			* @test
24			*/
25			public function constructorShouldConfigureAttributes()
26			{
27			$this->assertInstanceOf(Ofx::class, $this->ofx);
28			}
29			/**
30			* @test
31			* @expectedException InvalidArgumentException
32			*/
33			public function invalidFile(){
34			$ofx = Ofx::loadFromFile('Anywhere');
			0 ignored issues – show Documentation introduced 2015-12-05 22:24 UTC by Report Bug Copy Issue Report `'Anywhere'` is of type `string`, but the function expects a `object<Adelarcubs\OFXParser\unknown>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Unused Code introduced 2015-12-05 22:24 UTC by Report Bug Copy Issue Report `$ofx` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35			}
36			}
37

adelarcubs / ofxparser

Push — master ( 77f799...365b3d )

OfxTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like