Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 18 | class ReferenceSetter { |
||
| 19 | |||
| 20 | private WikibaseApi $api; |
||
|
|
|||
| 21 | |||
| 22 | private \Serializers\Serializer $referenceSerializer; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * @param WikibaseApi $api |
||
| 26 | * @param Serializer $referenceSerializer |
||
| 27 | */ |
||
| 28 | public function __construct( WikibaseApi $api, Serializer $referenceSerializer ) { |
||
| 29 | $this->api = $api; |
||
| 30 | $this->referenceSerializer = $referenceSerializer; |
||
| 31 | } |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @since 0.2 |
||
| 35 | * |
||
| 36 | * @param Reference $reference new reference value |
||
| 37 | * @param Statement|StatementGuid|string $statement Statement object or GUID which has the reference |
||
| 38 | * @param Reference|string|null $targetReference target (old) reference of hash |
||
| 39 | * @param EditInfo|null $editInfo |
||
| 40 | * |
||
| 41 | * @throws UnexpectedValueException |
||
| 42 | */ |
||
| 43 | public function set( Reference $reference, $statement, $targetReference = null, EditInfo $editInfo = null ): bool { |
||
| 44 | if ( is_string( $statement ) ) { |
||
| 45 | $guid = $statement; |
||
| 46 | } elseif ( $statement instanceof StatementGuid ) { |
||
| 47 | $guid = $statement->getSerialization(); |
||
| 48 | } elseif ( $statement instanceof Statement ) { |
||
| 49 | $guid = $statement->getGuid(); |
||
| 50 | } else { |
||
| 51 | throw new UnexpectedValueException( 'Could not get statement guid from $statement' ); |
||
| 52 | } |
||
| 53 | if ( !is_string( $guid ) ) { |
||
| 54 | throw new UnexpectedValueException( 'Unexpected statement guid got from $statement' ); |
||
| 55 | } |
||
| 56 | |||
| 57 | $referenceSerialization = $this->referenceSerializer->serialize( $reference ); |
||
| 58 | |||
| 59 | $params = [ |
||
| 60 | 'statement' => $guid, |
||
| 61 | 'snaks' => json_encode( $referenceSerialization['snaks'] ), |
||
| 62 | 'snaks-order' => json_encode( $referenceSerialization['snaks-order'] ), |
||
| 63 | ]; |
||
| 64 | |||
| 65 | if ( $targetReference !== null ) { |
||
| 66 | if ( $targetReference instanceof Reference ) { |
||
| 67 | $targetReference = $reference->getHash(); |
||
| 68 | } |
||
| 69 | if ( !is_string( $targetReference ) ) { |
||
| 70 | throw new UnexpectedValueException( 'Could not get reference hash from $targetReference' ); |
||
| 71 | } |
||
| 72 | $params['reference'] = $targetReference; |
||
| 73 | } |
||
| 74 | |||
| 75 | $this->api->postRequest( 'wbsetreference', $params, $editInfo ); |
||
| 76 | return true; |
||
| 77 | } |
||
| 78 | |||
| 79 | } |
||
| 80 |