ValueParser::parse() - Code Metrics - Inspection of "Add ValueParser::parseAsync method" - addwiki/wikibase-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4adc53...288f8e )

by adam

created 2015-12-18 16:58 UTC

ValueParser::parse() A

↳ Parent: ValueParser

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	5
Bugs	0	Features	4

Metric	Value
c	5
b	0
f	4
dl	0
loc	3
ccs	0
cts	2
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	2
crap	2

<?php

namespace Wikibase\Api\Service;

use DataValues\DataValue;
use Deserializers\Deserializer;
use GuzzleHttp\Promise\Promise;
use Mediawiki\Api\MediawikiApi;
use Mediawiki\Api\SimpleRequest;

/**
 * @access private
 *
 * @author Adam Shorland
 * @author Thomas Arrow
 */
class ValueParser {

	/**
	 * @var MediawikiApi
	 */
	private $api;

	/**
	 * @var Deserializer
	 */
	private $dataValueDeserializer;

	/**
	 * @param MediawikiApi $api
	 * @param Deserializer $dataValueDeserializer
	 */
	public function __construct( MediawikiApi $api, Deserializer $dataValueDeserializer ) {
		$this->api = $api;
		$this->dataValueDeserializer = $dataValueDeserializer;
	}

	/**
	 * @since 0.2
	 *
	 * @param string $value
	 * @param string $parser Id of the ValueParser to use
	 *
	 * @returns DataValue
	 */
	public function parse( $value, $parser ) {
		return $this->parseAsync( $value, $parser )->wait();
	}

	/**
	 * @since 0.7
	 *
	 * @param string $value
	 * @param string $parser Id of the ValueParser to use
	 *
	 * @returns Promise of a DataValue object
	 */
	public function parseAsync( $value, $parser ) {
		$promise = $this->api->getRequestAsync(
			new SimpleRequest(
				'wbparsevalue',
				array( 'parser' => $parser, 'values' => $value )
			)
		);

		return $promise->then(
			function ( $result ) {
				return $this->dataValueDeserializer->deserialize( $result['results'][0] );
			}
		);
	}

}


1			<?php
2
3			namespace Wikibase\Api\Service;
4
5			use DataValues\DataValue;
6			use Deserializers\Deserializer;
7			use GuzzleHttp\Promise\Promise;
8			use Mediawiki\Api\MediawikiApi;
9			use Mediawiki\Api\SimpleRequest;
10
11			/**
12			* @access private
13			*
14			* @author Adam Shorland
15			* @author Thomas Arrow
16			*/
17			class ValueParser {
18
19			/**
20			* @var MediawikiApi
21			*/
22			private $api;
23
24			/**
25			* @var Deserializer
26			*/
27			private $dataValueDeserializer;
28
29			/**
30			* @param MediawikiApi $api
31			* @param Deserializer $dataValueDeserializer
32			*/
33			public function __construct( MediawikiApi $api, Deserializer $dataValueDeserializer ) {
34			$this->api = $api;
35			$this->dataValueDeserializer = $dataValueDeserializer;
36			}
37
38			/**
39			* @since 0.2
40			*
41			* @param string $value
42			* @param string $parser Id of the ValueParser to use
43			*
44			* @returns DataValue
45			*/
46			public function parse( $value, $parser ) {
47			return $this->parseAsync( $value, $parser )->wait();
48			}
49
50			/**
51			* @since 0.7
52			*
53			* @param string $value
54			* @param string $parser Id of the ValueParser to use
55			*
56			* @returns Promise of a DataValue object
57			*/
58			public function parseAsync( $value, $parser ) {
59			$promise = $this->api->getRequestAsync(
60			new SimpleRequest(
61			'wbparsevalue',
62			array( 'parser' => $parser, 'values' => $value )
63			)
64			);
65
66			return $promise->then(
67			function ( $result ) {
68			return $this->dataValueDeserializer->deserialize( $result['results'][0] );
69			}
70			);
71			}
72
73			}
74

addwiki / wikibase-api

Push — master ( 4adc53...288f8e )

ValueParser::parse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like