Wikibase\Api\Service\RevisionGetter

Complexity

Total Complexity

10

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

57.14%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getFromId()	0	8	2
A	getFromSiteLink()	0	7	1
A	getFromSiteAndTitle()	0	7	1
A	newRevisionFromResult()	0	13	2
A	getContentFromEntity()	0	10	3

<?php

namespace Wikibase\Api\Service;

use Deserializers\Deserializer;
use Mediawiki\Api\MediawikiApi;
use Mediawiki\Api\SimpleRequest;
use Mediawiki\DataModel\PageIdentifier;
use Mediawiki\DataModel\Revision;
use RuntimeException;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\Property;
use Wikibase\DataModel\ItemContent;
use Wikibase\DataModel\PropertyContent;
use Wikibase\DataModel\SiteLink;

/**
 * @access private
 *
 * @author Addshore
 */
class RevisionGetter {

	/**
	 * @var MediawikiApi
	 */
	protected $api;

	/**
	 * @var Deserializer
	 */
	protected $entityDeserializer;

	/**
	 * @param MediawikiApi $api
	 * @param Deserializer $entityDeserializer
	 */
	public function __construct( MediawikiApi $api, Deserializer $entityDeserializer ) {
		$this->api = $api;
		$this->entityDeserializer = $entityDeserializer;
	}

	/**
	 * @since 0.1
	 * @param string|EntityId $id
	 * @returns Revision
	 */
	public function getFromId( $id ) {
		if( $id instanceof EntityId ) {
			$id = $id->getSerialization();
		}

		$result = $this->api->getRequest( new SimpleRequest( 'wbgetentities', array( 'ids' => $id ) ) );
		return $this->newRevisionFromResult( array_shift( $result['entities'] ) );
	}

	/**
	 * @since 0.1
	 * @param SiteLink $siteLink
	 * @returns Revision
	 */
	public function getFromSiteLink( SiteLink $siteLink ) {
		$result = $this->api->getRequest( new SimpleRequest(
			'wbgetentities',
			array( 'sites' => $siteLink->getSiteId(), 'titles' => $siteLink->getPageName() )
		) );
		return $this->newRevisionFromResult( array_shift( $result['entities'] ) );
	}

	/**
	 * @since 0.1
	 * @param string $siteId
	 * @param string $title
	 * @returns Revision
	 */
	public function getFromSiteAndTitle( $siteId, $title ) {
		$result = $this->api->getRequest( new SimpleRequest(
			'wbgetentities',
			array( 'sites' => $siteId, 'titles' => $title )
		) );
		return $this->newRevisionFromResult( array_shift( $result['entities'] ) );
	}
	
	/**
	 * @param array $entityResult
	 * @returns Revision
	 * @todo this could be factored into a different class?
	 */
	private function newRevisionFromResult( array $entityResult ) {
		if( array_key_exists( 'missing', $entityResult ) ) {
			return false; //Throw an exception?
		}
		return new Revision(
			$this->getContentFromEntity( $this->entityDeserializer->deserialize( $entityResult ) ),
			new PageIdentifier( null, intval( $entityResult['pageid'] ) ),
			$entityResult['lastrevid'],
			null,
			null,
			$entityResult['modified']
		);
	}

	/**
	 * @param Item|Property $entity
	 *
	 * @throws RuntimeException
	 * @return ItemContent|PropertyContent
	 * @todo this could be factored into a different class?
	 */
	private function getContentFromEntity( $entity ) {
		switch ( $entity->getType() ) {
			case Item::ENTITY_TYPE:
				return new ItemContent( $entity );

It seems like $entity defined by parameter $entity on line 111 can also be of type object<Wikibase\DataModel\Entity\Property>; however, Wikibase\DataModel\ItemContent::__construct() does only seem to accept object<Wikibase\DataModel\Entity\Item>, maybe add an additional type check?

			case Property::ENTITY_TYPE:
				return new PropertyContent( $entity );

It seems like $entity defined by parameter $entity on line 111 can also be of type object<Wikibase\DataModel\Entity\Item>; however, Wikibase\DataModel\PropertyContent::__construct() does only seem to accept object<Wikibase\DataModel\Entity\Property>, maybe add an additional type check?

			default:
				throw new RuntimeException( 'I cant get a content for this type of entity' );
		}
	}

}