Issues in PageGetter.php (master) - Issues in master - addwiki/mediawiki-api - Measure and Improve Code Quality continuously with Scrutinizer

Issues (37)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Service/PageGetter.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Mediawiki\Api\Service;

use Mediawiki\Api\SimpleRequest;
use Mediawiki\DataModel\Content;
use Mediawiki\DataModel\EditInfo;
use Mediawiki\DataModel\Page;
use Mediawiki\DataModel\PageIdentifier;
use Mediawiki\DataModel\Revision;
use Mediawiki\DataModel\Revisions;
use Mediawiki\DataModel\Title;
use RuntimeException;

/**
 * @access private
 *
 * @author Addshore
 */
class PageGetter extends Service {

	/**
	 * @since 0.2
	 *
	 * @param int $id
	 * @param array $extraParams
	 *
	 * @return Page
	 */
	public function getFromRevisionId( $id, array $extraParams = [] ) {

		$result =
			$this->api->getRequest(
				new SimpleRequest(
					'query',
					$this->getQuery( [ 'revids' => $id ], $extraParams )
				)
			);

		return $this->newPageFromResult( array_shift( $result['query']['pages'] ) );
	}

	/**
	 * @since 0.2
	 *
	 * @param string|Title $title
	 * @param array $extraParams
	 *
	 * @return Page
	 */
	public function getFromTitle( $title, array $extraParams = [] ) {
		if ( $title instanceof Title ) {
			$title = $title->getTitle();

		}
		$result =
			$this->api->getRequest(
				new SimpleRequest(
					'query',
					$this->getQuery( [ 'titles' => $title ], $extraParams )
				)
			);

		return $this->newPageFromResult( array_shift( $result['query']['pages'] ) );
	}

	/**
	 * @since 0.2
	 *
	 * @param int $id
	 * @param array $extraParams
	 *
	 * @return Page
	 */
	public function getFromPageId( $id, array $extraParams = [] ) {

		$result =
			$this->api->getRequest(
				new SimpleRequest(
					'query',
					$this->getQuery( [ 'pageids' => $id ], $extraParams )
				)
			);

		return $this->newPageFromResult( array_shift( $result['query']['pages'] ) );
	}

	/**
	 * @since 0.4
	 *
	 * @param PageIdentifier $pageIdentifier
	 * @param array $extraParams
	 *
	 * @throws RuntimeException
	 * @return Page
	 */
	public function getFromPageIdentifier(
		PageIdentifier $pageIdentifier,
		array $extraParams = []
	) {
		if ( !$pageIdentifier->identifiesPage() ) {
			throw new RuntimeException( '$pageIdentifier does not identify a page' );
		}
		if ( $pageIdentifier->getId() !== null ) {
			return $this->getFromPageId( $pageIdentifier->getId(), $extraParams );
		} else {
			return $this->getFromTitle( $pageIdentifier->getTitle(), $extraParams );
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		}
	}

	/**
	 * @since 0.2
	 *
	 * @param Page $page
	 * @param array $extraParams
	 *
	 * @return Page
	 */
	public function getFromPage( Page $page, array $extraParams = [] ) {
		$result =
			$this->api->getRequest(
				new SimpleRequest(
					'query',
					$this->getQuery( [ 'pageids' => $page->getId() ], $extraParams )

				)
			);
		$revisions = $this->getRevisionsFromResult( array_shift( $result['query']['pages'] ) );
		$revisions->addRevisions( $page->getRevisions() );

		return new Page(
			$page->getPageIdentifier(),
			$revisions
		);
	}

	/**
	 * @since 0.2
	 *
	 * @param Revision $revision
	 * @param array $extraParams
	 *
	 * @return Page
	 */
	public function getFromRevision( Revision $revision, array $extraParams = [] ) {
		$result =
			$this->api->getRequest(
				new SimpleRequest(
					'query',
					$this->getQuery( [ 'revids' => $revision->getId() ], $extraParams )
				)
			);
		$revisions = $this->getRevisionsFromResult( array_shift( $result['query']['pages'] ) );
		$revisions->addRevision( $revision );

		return new Page(
			new PageIdentifier(
				new Title(
					$result['title'],
					$result['ns']
				),
				$result['pageid']
			),
			$revisions
		);
	}

	/**
	 * @param array $additionalParams
	 *
	 * @param array $extraParams
	 *
	 * @return array
	 */
	private function getQuery( $additionalParams, array $extraParams = [] ) {
		$base = [
			'prop' => 'revisions|info|pageprops',
			'rvprop' => 'ids|flags|timestamp|user|size|sha1|comment|content|tags',
			'inprop' => 'protection',
		];

		return array_merge( $extraParams, $base, $additionalParams );
	}

	/**
	 * @param array $array
	 *
	 * @return Revisions
	 */
	private function getRevisionsFromResult( $array ) {
		$revisions = new Revisions();
		$pageid = $array['pageid'];
		foreach ( $array['revisions'] as $revision ) {
			$revision['comment'] = ( isset( $revision['comment'] ) ) ? $revision['comment'] : '';
			$revisions->addRevision(
				new Revision(
					$this->getContent( $array['contentmodel'], $revision['*'] ),
					new PageIdentifier( new Title( $array['title'], $array['ns'] ), $pageid ),
					$revision['revid'],
					new EditInfo(
						$revision['comment'],
						array_key_exists( 'minor', $revision ),
						array_key_exists( 'bot', $revision )
					),
					$revision['user'],
					$revision['timestamp']
				)
			);
		}

		return $revisions;
	}

	/**
	 * @param string $model
	 * @param string $content returned from the API
	 *
	 * @throws RuntimeException
	 * @return Content
	 */
	private function getContent( $model, $content ) {
		return new Content( $content, $model );
	}

	/**
	 * @param array $array
	 *
	 * @return Page
	 */
	private function newPageFromResult( $array ) {
		if ( array_key_exists( 'pageid', $array ) ) {
			$pageid = $array['pageid'];
			$revisions = $this->getRevisionsFromResult( $array );
		} else {
			$pageid = 0;
			$revisions = new Revisions();
		}

		return new Page(
			new PageIdentifier(
				new Title(
					$array['title'],
					$array['ns']
				),
				$pageid
			),
			$revisions
		);
	}

}


1			<?php
2
3			namespace Mediawiki\Api\Service;
4
5			use Mediawiki\Api\SimpleRequest;
6			use Mediawiki\DataModel\Content;
7			use Mediawiki\DataModel\EditInfo;
8			use Mediawiki\DataModel\Page;
9			use Mediawiki\DataModel\PageIdentifier;
10			use Mediawiki\DataModel\Revision;
11			use Mediawiki\DataModel\Revisions;
12			use Mediawiki\DataModel\Title;
13			use RuntimeException;
14
15			/**
16			* @access private
17			*
18			* @author Addshore
19			*/
20			class PageGetter extends Service {
21
22			/**
23			* @since 0.2
24			*
25			* @param int $id
26			* @param array $extraParams
27			*
28			* @return Page
29			*/
30		View Code Duplication	public function getFromRevisionId( $id, array $extraParams = [] ) {
			0 ignored issues – show Duplication introduced 2021-01-24 16:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31			$result =
32			$this->api->getRequest(
33			new SimpleRequest(
34			'query',
35			$this->getQuery( [ 'revids' => $id ], $extraParams )
36			)
37			);
38
39			return $this->newPageFromResult( array_shift( $result['query']['pages'] ) );
40			}
41
42			/**
43			* @since 0.2
44			*
45			* @param string\|Title $title
46			* @param array $extraParams
47			*
48			* @return Page
49			*/
50	7		public function getFromTitle( $title, array $extraParams = [] ) {
51	7		if ( $title instanceof Title ) {
52	7		$title = $title->getTitle();
			0 ignored issues – show Deprecated Code introduced 2015-12-12 15:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Mediawiki\DataModel\Title::getTitle()` has been deprecated with message: in 0.6 use getText (makes things look cleaner) This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
53	7		}
54			$result =
55	7		$this->api->getRequest(
56	7		new SimpleRequest(
57	7		'query',
58	7		$this->getQuery( [ 'titles' => $title ], $extraParams )
59	7		)
60	7		);
61
62	7		return $this->newPageFromResult( array_shift( $result['query']['pages'] ) );
63			}
64
65			/**
66			* @since 0.2
67			*
68			* @param int $id
69			* @param array $extraParams
70			*
71			* @return Page
72			*/
73	1	View Code Duplication	public function getFromPageId( $id, array $extraParams = [] ) {
			0 ignored issues – show Duplication introduced 2021-01-24 16:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
74			$result =
75	1		$this->api->getRequest(
76	1		new SimpleRequest(
77	1		'query',
78	1		$this->getQuery( [ 'pageids' => $id ], $extraParams )
79	1		)
80	1		);
81
82	1		return $this->newPageFromResult( array_shift( $result['query']['pages'] ) );
83			}
84
85			/**
86			* @since 0.4
87			*
88			* @param PageIdentifier $pageIdentifier
89			* @param array $extraParams
90			*
91			* @throws RuntimeException
92			* @return Page
93			*/
94	5		public function getFromPageIdentifier(
95			PageIdentifier $pageIdentifier,
96			array $extraParams = []
97			) {
98	5		if ( !$pageIdentifier->identifiesPage() ) {
99			throw new RuntimeException( '$pageIdentifier does not identify a page' );
100			}
101	5		if ( $pageIdentifier->getId() !== null ) {
102			return $this->getFromPageId( $pageIdentifier->getId(), $extraParams );
103			} else {
104	5		return $this->getFromTitle( $pageIdentifier->getTitle(), $extraParams );
			0 ignored issues – show Bug introduced 2015-12-12 15:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$pageIdentifier->getTitle()` can be `null`; however, `getFromTitle()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
105			}
106			}
107
108			/**
109			* @since 0.2
110			*
111			* @param Page $page
112			* @param array $extraParams
113			*
114			* @return Page
115			*/
116			public function getFromPage( Page $page, array $extraParams = [] ) {
117			$result =
118			$this->api->getRequest(
119			new SimpleRequest(
120			'query',
121			$this->getQuery( [ 'pageids' => $page->getId() ], $extraParams )
			0 ignored issues – show Deprecated Code introduced 2015-12-12 15:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Mediawiki\DataModel\Page::getId()` has been deprecated with message: since 0.5 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
122			)
123			);
124			$revisions = $this->getRevisionsFromResult( array_shift( $result['query']['pages'] ) );
125			$revisions->addRevisions( $page->getRevisions() );
126
127			return new Page(
128			$page->getPageIdentifier(),
129			$revisions
130			);
131			}
132
133			/**
134			* @since 0.2
135			*
136			* @param Revision $revision
137			* @param array $extraParams
138			*
139			* @return Page
140			*/
141			public function getFromRevision( Revision $revision, array $extraParams = [] ) {
142			$result =
143			$this->api->getRequest(
144			new SimpleRequest(
145			'query',
146			$this->getQuery( [ 'revids' => $revision->getId() ], $extraParams )
147			)
148			);
149			$revisions = $this->getRevisionsFromResult( array_shift( $result['query']['pages'] ) );
150			$revisions->addRevision( $revision );
151
152			return new Page(
153			new PageIdentifier(
154			new Title(
155			$result['title'],
156			$result['ns']
157			),
158			$result['pageid']
159			),
160			$revisions
161			);
162			}
163
164			/**
165			* @param array $additionalParams
166			*
167			* @param array $extraParams
168			*
169			* @return array
170			*/
171	8		private function getQuery( $additionalParams, array $extraParams = [] ) {
172			$base = [
173	8		'prop' => 'revisions\|info\|pageprops',
174	8		'rvprop' => 'ids\|flags\|timestamp\|user\|size\|sha1\|comment\|content\|tags',
175	8		'inprop' => 'protection',
176	8		];
177
178	8		return array_merge( $extraParams, $base, $additionalParams );
179			}
180
181			/**
182			* @param array $array
183			*
184			* @return Revisions
185			*/
186	8		private function getRevisionsFromResult( $array ) {
187	8		$revisions = new Revisions();
188	8		$pageid = $array['pageid'];
189	8		foreach ( $array['revisions'] as $revision ) {
190	8		$revision['comment'] = ( isset( $revision['comment'] ) ) ? $revision['comment'] : '';
191	8		$revisions->addRevision(
192	8		new Revision(
193	8		$this->getContent( $array['contentmodel'], $revision['*'] ),
194	8		new PageIdentifier( new Title( $array['title'], $array['ns'] ), $pageid ),
195	8		$revision['revid'],
196	8		new EditInfo(
197	8		$revision['comment'],
198	8		array_key_exists( 'minor', $revision ),
199	8		array_key_exists( 'bot', $revision )
200	8		),
201	8		$revision['user'],
202	8		$revision['timestamp']
203	8		)
204	8		);
205			}
206	8
207			return $revisions;
208			}
209
210			/**
211			* @param string $model
212			* @param string $content returned from the API
213			*
214			* @throws RuntimeException
215			* @return Content
216	8		*/
217	8		private function getContent( $model, $content ) {
218			return new Content( $content, $model );
219			}
220
221			/**
222			* @param array $array
223			*
224			* @return Page
225	8		*/
226	8		private function newPageFromResult( $array ) {
227	8		if ( array_key_exists( 'pageid', $array ) ) {
228	8		$pageid = $array['pageid'];
229	8		$revisions = $this->getRevisionsFromResult( $array );
230	1		} else {
231	1		$pageid = 0;
232			$revisions = new Revisions();
233			}
234	8
235	8		return new Page(
236	8		new PageIdentifier(
237	8		new Title(
238	8		$array['title'],
239	8		$array['ns']
240			),
241	8		$pageid
242			),
243	8		$revisions
244			);
245			}
246
247			}
248

addwiki / mediawiki-api

Issues (37)

Security Analysis no request data

src/Service/PageGetter.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like