RevisionUndoer::getParamsFromRevision() - Code Metrics - Inspection of "Add new parent Service class and make its $api pro..." - addwiki/mediawiki-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#49)

by Sam

created 2017-11-20 02:37 UTC

RevisionUndoer::getParamsFromRevision() A

↳ Parent: RevisionUndoer

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
ccs	0
cts	9
cp	0
rs	9.4285
cc	2
eloc	9
nc	2
nop	1
crap	6

<?php

namespace Mediawiki\Api\Service;

use Mediawiki\Api\SimpleRequest;
use Mediawiki\DataModel\Revision;

/**
 * @access private
 *
 * @author Addshore
 */
class RevisionUndoer extends Service {

	/**
	 * @param Revision $revision
	 *
	 * @return bool
	 */
	public function undo( Revision $revision ) {
		$this->api->postRequest( new SimpleRequest(
			'edit',
			$this->getParamsFromRevision( $revision )
		) );
		return true;
	}

	/**
	 * @param Revision $revision
	 *
	 * @return array
	 */
	private function getParamsFromRevision( Revision $revision ) {
		$params = [
			'undo' => $revision->getId(),
			'token' => $this->api->getToken(),
		];

		if ( !is_null( $revision->getPageIdentifier()->getId() ) ) {
			$params['pageid'] = $revision->getPageIdentifier()->getId();
		} else {
			$params['title'] = $revision->getPageIdentifier()->getTitle()->getTitle();
		}

		return $params;
	}

}


1			<?php
2
3			namespace Mediawiki\Api\Service;
4
5			use Mediawiki\Api\SimpleRequest;
6			use Mediawiki\DataModel\Revision;
7
8			/**
9			* @access private
10			*
11			* @author Addshore
12			*/
13			class RevisionUndoer extends Service {
14
15			/**
16			* @param Revision $revision
17			*
18			* @return bool
19			*/
20			public function undo( Revision $revision ) {
21			$this->api->postRequest( new SimpleRequest(
22			'edit',
23			$this->getParamsFromRevision( $revision )
24			) );
25			return true;
26			}
27
28			/**
29			* @param Revision $revision
30			*
31			* @return array
32			*/
33			private function getParamsFromRevision( Revision $revision ) {
34			$params = [
35			'undo' => $revision->getId(),
36			'token' => $this->api->getToken(),
37			];
38
39			if ( !is_null( $revision->getPageIdentifier()->getId() ) ) {
40			$params['pageid'] = $revision->getPageIdentifier()->getId();
41			} else {
42			$params['title'] = $revision->getPageIdentifier()->getTitle()->getTitle();
43			}
44
45			return $params;
46			}
47
48			}
49

addwiki / mediawiki-api

Pull Request — master (#49)

RevisionUndoer::getParamsFromRevision() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like