Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 13 | class RevisionUndoer extends Service { |
||
| 14 | |||
| 15 | /** |
||
| 16 | * @param Revision $revision |
||
| 17 | */ |
||
| 18 | public function undo( Revision $revision ): bool { |
||
| 25 | |||
| 26 | /** |
||
| 27 | * @param Revision $revision |
||
| 28 | * |
||
| 29 | * @return array <string int|string|null> |
||
| 30 | */ |
||
| 31 | private function getParamsFromRevision( Revision $revision ): array { |
||
| 45 | |||
| 46 | } |
||
| 47 |