Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 14 | class RevisionRollbacker extends Service { |
||
| 15 | |||
| 16 | /** |
||
| 17 | * @since 0.3 |
||
| 18 | * |
||
| 19 | * @param Revision $revision |
||
| 20 | * @param Title|null $title if using MW 1.24 of lower (https://gerrit.wikimedia.org/r/#/c/133063/) |
||
| 21 | */ |
||
| 22 | public function rollback( Revision $revision, Title $title = null ): bool { |
||
| 29 | |||
| 30 | /** |
||
| 31 | * |
||
| 32 | * @return array <string mixed>|array<string, string|null> |
||
| 33 | */ |
||
| 34 | private function getRollbackParams( Revision $revision, ?Title $title ): array { |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @param Revision $revision |
||
| 51 | */ |
||
| 52 | private function getTokenForRevision( Revision $revision ): string { |
||
| 66 | |||
| 67 | } |
||
| 68 |