Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | class RevisionSaver extends Service { |
||
17 | |||
18 | /** |
||
19 | * @since 0.2 |
||
20 | * |
||
21 | * @param Revision $revision |
||
22 | * @param EditInfo|null $editInfo |
||
23 | * |
||
24 | * @return bool success |
||
25 | */ |
||
26 | 10 | public function save( Revision $revision, EditInfo $editInfo = null ) { |
|
34 | |||
35 | /** |
||
36 | * @param Revision $revision |
||
37 | * @param EditInfo|null $editInfo |
||
38 | * |
||
39 | * @throws RuntimeException |
||
40 | * @return array |
||
41 | */ |
||
42 | 10 | private function getEditParams( Revision $revision, EditInfo $editInfo = null ) { |
|
43 | 10 | if ( !$revision->getPageIdentifier()->identifiesPage() ) { |
|
44 | throw new RuntimeException( '$revision PageIdentifier does not identify a page' ); |
||
45 | } |
||
46 | |||
47 | 10 | $params = []; |
|
48 | |||
49 | 10 | $content = $revision->getContent(); |
|
50 | 10 | $data = $content->getData(); |
|
51 | 10 | if ( !is_string( $data ) ) { |
|
52 | throw new RuntimeException( 'Dont know how to save content of this model.' ); |
||
53 | } |
||
54 | 10 | $params['text'] = $content->getData(); |
|
55 | 10 | $params['md5'] = md5( $content->getData() ); |
|
56 | |||
57 | 10 | $timestamp = $revision->getTimestamp(); |
|
58 | 10 | if ( $timestamp !== null ) { |
|
59 | $params['basetimestamp'] = $timestamp; |
||
60 | } |
||
61 | |||
62 | 10 | View Code Duplication | if ( $revision->getPageIdentifier()->getId() !== null ) { |
|
|||
63 | $params['pageid'] = $revision->getPageIdentifier()->getId(); |
||
64 | } else { |
||
65 | 10 | $params['title'] = $revision->getPageIdentifier()->getTitle()->getTitle(); |
|
66 | } |
||
67 | |||
68 | 10 | $params['token'] = $this->api->getToken(); |
|
69 | |||
70 | 10 | if ( $this->api->isLoggedin() ) { |
|
71 | $params['assert'] = 'user'; |
||
72 | } |
||
73 | |||
74 | 10 | $this->addEditInfoParams( $editInfo, $params ); |
|
75 | |||
76 | 10 | return $params; |
|
77 | } |
||
78 | |||
79 | /** |
||
80 | * @param null|EditInfo $editInfo |
||
81 | * @param array &$params |
||
82 | */ |
||
83 | 10 | private function addEditInfoParams( $editInfo, &$params ) { |
|
95 | |||
96 | } |
||
97 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.