Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | class NamespaceGetter extends Service { |
||
14 | |||
15 | /** |
||
16 | * Find a namespace by its canonical name |
||
17 | * |
||
18 | * @param string $canonicalName |
||
19 | * @return NamespaceInfo|null |
||
20 | */ |
||
21 | 2 | public function getNamespaceByCanonicalName( $canonicalName ) { |
|
22 | 2 | $result = $this->getNamespaceResult()['query']; |
|
23 | 2 | View Code Duplication | foreach ( $result['namespaces'] as $nsInfo ) { |
|
|||
24 | 2 | if ( !empty( $nsInfo['canonical'] ) && $nsInfo['canonical'] === $canonicalName ) { |
|
25 | 1 | return $this->createNamespaceFromQuery( $nsInfo, $result['namespacealiases'] ); |
|
26 | } |
||
27 | 2 | } |
|
28 | 1 | return null; |
|
29 | } |
||
30 | |||
31 | /** |
||
32 | * Find a namespace by its canonical name, local name or namespace alias |
||
33 | * |
||
34 | * @param string $name |
||
35 | * @return NamespaceInfo|null |
||
36 | */ |
||
37 | 2 | public function getNamespaceByName( $name ) { |
|
38 | 2 | $result = $this->getNamespaceResult()['query']; |
|
39 | 2 | View Code Duplication | foreach ( $result['namespaces'] as $nsInfo ) { |
40 | 2 | if ( ( !empty( $nsInfo['canonical'] ) && $nsInfo['canonical'] === $name ) || |
|
41 | 2 | $nsInfo['*'] === $name ) { |
|
42 | 1 | return $this->createNamespaceFromQuery( $nsInfo, $result['namespacealiases'] ); |
|
43 | } |
||
44 | 2 | } |
|
45 | 1 | foreach ( $result['namespacealiases'] as $alias ) { |
|
46 | 1 | if ( $alias['*'] === $name && !empty( $result['namespaces'][$alias['id']] ) ) { |
|
47 | 1 | return $this->createNamespaceFromQuery( |
|
48 | 1 | $result['namespaces'][$alias['id']], |
|
49 | 1 | $result['namespacealiases'] |
|
50 | 1 | ); |
|
51 | } |
||
52 | 1 | } |
|
53 | return null; |
||
54 | } |
||
55 | |||
56 | /** |
||
57 | * @return NamespaceInfo[] |
||
58 | */ |
||
59 | 1 | public function getNamespaces() { |
|
69 | |||
70 | 4 | private function createNamespaceFromQuery( $nsInfo, $namespaceAliases ) { |
|
80 | |||
81 | /** |
||
82 | * @param int $id |
||
83 | * @param array $namespaceAliases Alias list, as returned by the API |
||
84 | * @return string[] |
||
85 | */ |
||
86 | 4 | private function getAliases( $id, $namespaceAliases ) { |
|
95 | |||
96 | /** |
||
97 | * @return array |
||
98 | */ |
||
99 | 5 | private function getNamespaceResult() { |
|
107 | |||
108 | } |
||
109 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.