Complex classes like MediawikiApi often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use MediawikiApi, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
25 | class MediawikiApi implements MediawikiApiInterface, LoggerAwareInterface { |
||
26 | |||
27 | /** |
||
28 | * @var ClientInterface|null Should be accessed through getClient |
||
29 | */ |
||
30 | private $client = null; |
||
31 | |||
32 | /** |
||
33 | * @var bool|string |
||
34 | */ |
||
35 | private $isLoggedIn; |
||
36 | |||
37 | /** |
||
38 | * @var MediawikiSession |
||
39 | */ |
||
40 | private $session; |
||
41 | |||
42 | /** |
||
43 | * @var string |
||
44 | */ |
||
45 | private $version; |
||
46 | |||
47 | /** |
||
48 | * @var LoggerInterface |
||
49 | */ |
||
50 | private $logger; |
||
51 | |||
52 | /** |
||
53 | * @var string |
||
54 | */ |
||
55 | private $apiUrl; |
||
56 | |||
57 | /** |
||
58 | * @since 2.0.0 |
||
59 | * |
||
60 | * @param string $apiEndpoint e.g. https://en.wikipedia.org/w/api.php |
||
61 | * |
||
62 | * @return self returns a MediawikiApi instance using $apiEndpoint |
||
63 | */ |
||
64 | public static function newFromApiEndpoint( $apiEndpoint ) { |
||
67 | |||
68 | /** |
||
69 | * @since 2.0.0 |
||
70 | * |
||
71 | * @param string $url e.g. https://en.wikipedia.org OR https://de.wikipedia.org/wiki/Berlin |
||
72 | * |
||
73 | * @return self returns a MediawikiApi instance using the apiEndpoint provided by the RSD |
||
74 | * file accessible on all Mediawiki pages |
||
75 | * |
||
76 | * @see https://en.wikipedia.org/wiki/Really_Simple_Discovery |
||
77 | */ |
||
78 | 1 | public static function newFromPage( $url ) { |
|
85 | |||
86 | /** |
||
87 | * @param string $apiUrl The API Url |
||
88 | * @param ClientInterface|null $client Guzzle Client |
||
89 | * @param MediawikiSession|null $session Inject a custom session here |
||
90 | */ |
||
91 | 23 | public function __construct( $apiUrl, ClientInterface $client = null, MediawikiSession $session = null ) { |
|
105 | |||
106 | /** |
||
107 | * Get the API URL (the URL to which API requests are sent, usually ending in api.php). |
||
108 | * This is useful if you've created this object via MediawikiApi::newFromPage(). |
||
109 | * @return string The API URL. |
||
110 | */ |
||
111 | public function getApiUrl() |
||
115 | |||
116 | /** |
||
117 | * @return ClientInterface |
||
118 | */ |
||
119 | 20 | private function getClient() { |
|
127 | |||
128 | /** |
||
129 | * Sets a logger instance on the object |
||
130 | * |
||
131 | * @since 1.1 |
||
132 | * |
||
133 | * @param LoggerInterface $logger |
||
134 | * |
||
135 | * @return null |
||
136 | */ |
||
137 | public function setLogger( LoggerInterface $logger ) { |
||
141 | |||
142 | /** |
||
143 | * @since 2.0 |
||
144 | * |
||
145 | * @param Request $request |
||
146 | * |
||
147 | * @return PromiseInterface |
||
148 | * Normally promising an array, though can be mixed (json_decode result) |
||
149 | * Can throw UsageExceptions or RejectionExceptions |
||
150 | */ |
||
151 | 1 | public function getRequestAsync( Request $request ) { |
|
162 | |||
163 | /** |
||
164 | * @since 2.0 |
||
165 | * |
||
166 | * @param Request $request |
||
167 | * |
||
168 | * @return PromiseInterface |
||
169 | * Normally promising an array, though can be mixed (json_decode result) |
||
170 | * Can throw UsageExceptions or RejectionExceptions |
||
171 | */ |
||
172 | 1 | public function postRequestAsync( Request $request ) { |
|
183 | |||
184 | /** |
||
185 | * @since 0.2 |
||
186 | * |
||
187 | * @param Request $request |
||
188 | * |
||
189 | * @return mixed Normally an array |
||
190 | */ |
||
191 | 9 | public function getRequest( Request $request ) { |
|
200 | |||
201 | /** |
||
202 | * @since 0.2 |
||
203 | * |
||
204 | * @param Request $request |
||
205 | * |
||
206 | * @return mixed Normally an array |
||
207 | */ |
||
208 | 9 | public function postRequest( Request $request ) { |
|
217 | |||
218 | /** |
||
219 | * @param ResponseInterface $response |
||
220 | * |
||
221 | * @return mixed |
||
222 | * @throws UsageException |
||
223 | */ |
||
224 | 18 | private function decodeResponse( ResponseInterface $response ) { |
|
232 | |||
233 | /** |
||
234 | * @param Request $request |
||
235 | * @param string $paramsKey either 'query' or 'form_params' |
||
236 | * |
||
237 | * @throws RequestException |
||
238 | * |
||
239 | * @return array as needed by ClientInterface::get and ClientInterface::post |
||
240 | */ |
||
241 | 20 | private function getClientRequestOptions( Request $request, $paramsKey ) { |
|
247 | |||
248 | /** |
||
249 | * @return array |
||
250 | */ |
||
251 | 16 | private function getDefaultHeaders() { |
|
256 | |||
257 | 16 | private function getUserAgent() { |
|
264 | |||
265 | /** |
||
266 | * @param $result |
||
267 | */ |
||
268 | 16 | private function logWarnings( $result ) { |
|
275 | |||
276 | /** |
||
277 | * @param array $result |
||
278 | * |
||
279 | * @throws UsageException |
||
280 | */ |
||
281 | 16 | private function throwUsageExceptions( $result ) { |
|
290 | |||
291 | /** |
||
292 | * @since 0.1 |
||
293 | * |
||
294 | * @return bool|string false or the name of the current user |
||
295 | */ |
||
296 | 16 | public function isLoggedin() { |
|
299 | |||
300 | /** |
||
301 | * @since 0.1 |
||
302 | * |
||
303 | * @param ApiUser $apiUser |
||
304 | * |
||
305 | * @throws UsageException |
||
306 | * @return bool success |
||
307 | */ |
||
308 | 2 | public function login( ApiUser $apiUser ) { |
|
324 | |||
325 | /** |
||
326 | * @param ApiUser $apiUser |
||
327 | * |
||
328 | * @return string[] |
||
329 | */ |
||
330 | 2 | private function getLoginParams( ApiUser $apiUser ) { |
|
341 | |||
342 | /** |
||
343 | * @param array $result |
||
344 | * |
||
345 | * @throws UsageException |
||
346 | */ |
||
347 | 1 | private function throwLoginUsageException( $result ) { |
|
356 | |||
357 | /** |
||
358 | * @param string $loginResult |
||
359 | * |
||
360 | * @return string |
||
361 | */ |
||
362 | 1 | private function getLoginExceptionMessage( $loginResult ) { |
|
384 | |||
385 | /** |
||
386 | * @since 0.1 |
||
387 | * |
||
388 | * @return bool success |
||
389 | */ |
||
390 | 2 | public function logout() { |
|
400 | |||
401 | /** |
||
402 | * @since 0.1 |
||
403 | * |
||
404 | * @param string $type |
||
405 | * |
||
406 | * @return string |
||
407 | */ |
||
408 | 2 | public function getToken( $type = 'csrf' ) { |
|
411 | |||
412 | /** |
||
413 | * @since 0.1 |
||
414 | * |
||
415 | * Clears all tokens stored by the api |
||
416 | */ |
||
417 | 1 | public function clearTokens() { |
|
420 | |||
421 | /** |
||
422 | * @return string |
||
423 | */ |
||
424 | 4 | public function getVersion(){ |
|
439 | |||
440 | } |
||
441 |