Complex classes like MediawikiApi often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use MediawikiApi, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 27 | class MediawikiApi implements MediawikiApiInterface, LoggerAwareInterface { |
||
| 28 | |||
| 29 | /** |
||
| 30 | * @var ClientInterface|null Should be accessed through getClient |
||
| 31 | */ |
||
| 32 | private $client = null; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @var bool|string |
||
| 36 | */ |
||
| 37 | private $isLoggedIn; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @var MediawikiSession |
||
| 41 | */ |
||
| 42 | private $session; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @var string |
||
| 46 | */ |
||
| 47 | private $version; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @var LoggerInterface |
||
| 51 | */ |
||
| 52 | private $logger; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @var string |
||
| 56 | */ |
||
| 57 | private $apiUrl; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * @since 2.0 |
||
| 61 | * |
||
| 62 | * @param string $apiEndpoint e.g. https://en.wikipedia.org/w/api.php |
||
| 63 | * |
||
| 64 | * @return self returns a MediawikiApi instance using $apiEndpoint |
||
| 65 | */ |
||
| 66 | public static function newFromApiEndpoint( $apiEndpoint ) { |
||
| 69 | |||
| 70 | /** |
||
| 71 | * Create a new MediawikiApi object from a URL to any page in a MediaWiki website. |
||
| 72 | * |
||
| 73 | * @since 2.0 |
||
| 74 | * @see https://en.wikipedia.org/wiki/Really_Simple_Discovery |
||
| 75 | * |
||
| 76 | * @param string $url e.g. https://en.wikipedia.org OR https://de.wikipedia.org/wiki/Berlin |
||
| 77 | * @return self returns a MediawikiApi instance using the apiEndpoint provided by the RSD |
||
| 78 | * file accessible on all Mediawiki pages |
||
| 79 | * @throws RsdException If the RSD URL could not be found in the page's HTML. |
||
| 80 | */ |
||
| 81 | 3 | public static function newFromPage( $url ) { |
|
| 113 | |||
| 114 | /** |
||
| 115 | * @param string $apiUrl The API Url |
||
| 116 | * @param ClientInterface|null $client Guzzle Client |
||
| 117 | * @param MediawikiSession|null $session Inject a custom session here |
||
| 118 | */ |
||
| 119 | 24 | public function __construct( $apiUrl, ClientInterface $client = null, |
|
| 134 | |||
| 135 | /** |
||
| 136 | * Get the API URL (the URL to which API requests are sent, usually ending in api.php). |
||
| 137 | * This is useful if you've created this object via MediawikiApi::newFromPage(). |
||
| 138 | * |
||
| 139 | * @since 2.3 |
||
| 140 | * |
||
| 141 | * @return string The API URL. |
||
| 142 | */ |
||
| 143 | public function getApiUrl() { |
||
| 146 | |||
| 147 | /** |
||
| 148 | * @return ClientInterface |
||
| 149 | */ |
||
| 150 | 21 | private function getClient() { |
|
| 158 | |||
| 159 | /** |
||
| 160 | * Sets a logger instance on the object |
||
| 161 | * |
||
| 162 | * @since 1.1 |
||
| 163 | * |
||
| 164 | * @param LoggerInterface $logger The new Logger object. |
||
| 165 | * |
||
| 166 | * @return null |
||
| 167 | */ |
||
| 168 | public function setLogger( LoggerInterface $logger ) { |
||
| 172 | |||
| 173 | /** |
||
| 174 | * @since 2.0 |
||
| 175 | * |
||
| 176 | * @param Request $request The GET request to send. |
||
| 177 | * |
||
| 178 | * @return PromiseInterface |
||
| 179 | * Normally promising an array, though can be mixed (json_decode result) |
||
| 180 | * Can throw UsageExceptions or RejectionExceptions |
||
| 181 | */ |
||
| 182 | 1 | public function getRequestAsync( Request $request ) { |
|
| 193 | |||
| 194 | /** |
||
| 195 | * @since 2.0 |
||
| 196 | * |
||
| 197 | * @param Request $request The POST request to send. |
||
| 198 | * |
||
| 199 | * @return PromiseInterface |
||
| 200 | * Normally promising an array, though can be mixed (json_decode result) |
||
| 201 | * Can throw UsageExceptions or RejectionExceptions |
||
| 202 | */ |
||
| 203 | 1 | public function postRequestAsync( Request $request ) { |
|
| 214 | |||
| 215 | /** |
||
| 216 | * @since 0.2 |
||
| 217 | * |
||
| 218 | * @param Request $request The GET request to send. |
||
| 219 | * |
||
| 220 | * @return mixed Normally an array |
||
| 221 | */ |
||
| 222 | 9 | public function getRequest( Request $request ) { |
|
| 231 | |||
| 232 | /** |
||
| 233 | * @since 0.2 |
||
| 234 | * |
||
| 235 | * @param Request $request The POST request to send. |
||
| 236 | * |
||
| 237 | * @return mixed Normally an array |
||
| 238 | */ |
||
| 239 | 10 | public function postRequest( Request $request ) { |
|
| 248 | |||
| 249 | /** |
||
| 250 | * @param ResponseInterface $response |
||
| 251 | * |
||
| 252 | * @return mixed |
||
| 253 | * @throws UsageException |
||
| 254 | */ |
||
| 255 | 21 | private function decodeResponse( ResponseInterface $response ) { |
|
| 263 | |||
| 264 | /** |
||
| 265 | * @param Request $request |
||
| 266 | * |
||
| 267 | * @return string |
||
| 268 | */ |
||
| 269 | 9 | private function getPostRequestEncoding( Request $request ) { |
|
| 280 | |||
| 281 | /** |
||
| 282 | * @param Request $request |
||
| 283 | * @param string $paramsKey either 'query' or 'multipart' |
||
| 284 | * |
||
| 285 | * @throws RequestException |
||
| 286 | * |
||
| 287 | * @return array as needed by ClientInterface::get and ClientInterface::post |
||
| 288 | */ |
||
| 289 | 21 | private function getClientRequestOptions( Request $request, $paramsKey ) { |
|
| 290 | 21 | $params = array_merge( $request->getParams(), [ 'format' => 'json' ] ); |
|
| 291 | 21 | if ( $paramsKey === 'multipart' ) { |
|
| 292 | 1 | $params = $this->encodeMultipartParams( $request, $params ); |
|
| 293 | 1 | } |
|
| 294 | |||
| 295 | return [ |
||
| 296 | 21 | $paramsKey => $params, |
|
| 297 | 21 | 'headers' => array_merge( $this->getDefaultHeaders(), $request->getHeaders() ), |
|
| 298 | 21 | ]; |
|
| 299 | } |
||
| 300 | |||
| 301 | /** |
||
| 302 | * Turn the normal key-value array of request parameters into a multipart array where each |
||
| 303 | * parameter is a new array with a 'name' and 'contents' elements (and optionally more, if the |
||
| 304 | * request is a MultipartRequest). |
||
| 305 | * |
||
| 306 | * @param Request $request The request to which the parameters belong. |
||
| 307 | * @param string[] $params The existing parameters. Not the same as $request->getParams(). |
||
| 308 | * |
||
| 309 | * @return array |
||
| 310 | */ |
||
| 311 | 1 | private function encodeMultipartParams( Request $request, $params ) { |
|
| 312 | // See if there are any multipart parameters in this request. |
||
| 313 | 1 | $multipartParams = ( $request instanceof MultipartRequest ) |
|
| 314 | 1 | ? $request->getMultipartParams() |
|
| 315 | 1 | : []; |
|
| 316 | 1 | return array_map( |
|
| 317 | 1 | function ( $name, $value ) use ( $multipartParams ) { |
|
| 318 | $partParams = [ |
||
| 319 | 1 | 'name' => $name, |
|
| 320 | 1 | 'contents' => $value, |
|
| 321 | 1 | ]; |
|
| 322 | 1 | if ( isset( $multipartParams[ $name ] ) ) { |
|
| 323 | // If extra parameters have been set for this part, use them. |
||
| 324 | $partParams = array_merge( $multipartParams[ $name ], $partParams ); |
||
| 325 | } |
||
| 326 | 1 | return $partParams; |
|
| 327 | 1 | }, |
|
| 328 | 1 | array_keys( $params ), |
|
| 329 | $params |
||
| 330 | 1 | ); |
|
| 331 | } |
||
| 332 | |||
| 333 | /** |
||
| 334 | * @return array |
||
| 335 | */ |
||
| 336 | 17 | private function getDefaultHeaders() { |
|
| 337 | return [ |
||
| 338 | 17 | 'User-Agent' => $this->getUserAgent(), |
|
| 339 | 17 | ]; |
|
| 340 | } |
||
| 341 | |||
| 342 | 17 | private function getUserAgent() { |
|
| 343 | 17 | $loggedIn = $this->isLoggedin(); |
|
| 344 | 17 | if ( $loggedIn ) { |
|
| 345 | return 'addwiki-mediawiki-client/' . $loggedIn; |
||
| 346 | } |
||
| 347 | 17 | return 'addwiki-mediawiki-client'; |
|
| 348 | } |
||
| 349 | |||
| 350 | /** |
||
| 351 | * @param $result |
||
| 352 | */ |
||
| 353 | 17 | private function logWarnings( $result ) { |
|
| 354 | 17 | if ( is_array( $result ) && array_key_exists( 'warnings', $result ) ) { |
|
| 355 | foreach ( $result['warnings'] as $module => $warningData ) { |
||
| 356 | // Accomodate both formatversion=2 and old-style API results |
||
| 357 | $logPrefix = $module . ': '; |
||
| 358 | if ( isset( $warningData['*'] ) ) { |
||
| 359 | $this->logger->warning( $logPrefix . $warningData['*'], [ 'data' => $warningData ] ); |
||
| 360 | } else { |
||
| 361 | $this->logger->warning( $logPrefix . $warningData['warnings'], [ 'data' => $warningData ] ); |
||
| 362 | } |
||
| 363 | } |
||
| 364 | } |
||
| 365 | 17 | } |
|
| 366 | |||
| 367 | /** |
||
| 368 | * @param array $result |
||
| 369 | * |
||
| 370 | * @throws UsageException |
||
| 371 | */ |
||
| 372 | 17 | private function throwUsageExceptions( $result ) { |
|
| 373 | 17 | if ( is_array( $result ) && array_key_exists( 'error', $result ) ) { |
|
| 374 | 2 | throw new UsageException( |
|
| 375 | 2 | $result['error']['code'], |
|
| 376 | 2 | $result['error']['info'], |
|
| 377 | $result |
||
| 378 | 2 | ); |
|
| 379 | } |
||
| 380 | 15 | } |
|
| 381 | |||
| 382 | /** |
||
| 383 | * @since 0.1 |
||
| 384 | * |
||
| 385 | * @return bool|string false or the name of the current user |
||
| 386 | */ |
||
| 387 | 17 | public function isLoggedin() { |
|
| 390 | |||
| 391 | /** |
||
| 392 | * @since 0.1 |
||
| 393 | * |
||
| 394 | * @param ApiUser $apiUser The ApiUser to log in as. |
||
| 395 | * |
||
| 396 | * @throws UsageException |
||
| 397 | * @return bool success |
||
| 398 | */ |
||
| 399 | 2 | public function login( ApiUser $apiUser ) { |
|
| 400 | 2 | $this->logger->log( LogLevel::DEBUG, 'Logging in' ); |
|
| 401 | 2 | $credentials = $this->getLoginParams( $apiUser ); |
|
| 402 | 2 | $result = $this->postRequest( new SimpleRequest( 'login', $credentials ) ); |
|
| 403 | 2 | if ( $result['login']['result'] == "NeedToken" ) { |
|
| 404 | 2 | $params = array_merge( [ 'lgtoken' => $result['login']['token'] ], $credentials ); |
|
| 405 | 2 | $result = $this->postRequest( new SimpleRequest( 'login', $params ) ); |
|
| 406 | 2 | } |
|
| 407 | 2 | if ( $result['login']['result'] == "Success" ) { |
|
| 408 | 1 | $this->isLoggedIn = $apiUser->getUsername(); |
|
| 409 | 1 | return true; |
|
| 410 | } |
||
| 411 | |||
| 412 | 1 | $this->isLoggedIn = false; |
|
| 413 | 1 | $this->logger->log( LogLevel::DEBUG, 'Login failed.', $result ); |
|
| 414 | 1 | $this->throwLoginUsageException( $result ); |
|
| 415 | return false; |
||
| 416 | } |
||
| 417 | |||
| 418 | /** |
||
| 419 | * @param ApiUser $apiUser |
||
| 420 | * |
||
| 421 | * @return string[] |
||
| 422 | */ |
||
| 423 | 2 | private function getLoginParams( ApiUser $apiUser ) { |
|
| 424 | $params = [ |
||
| 425 | 2 | 'lgname' => $apiUser->getUsername(), |
|
| 426 | 2 | 'lgpassword' => $apiUser->getPassword(), |
|
| 427 | 2 | ]; |
|
| 428 | |||
| 429 | 2 | if ( !is_null( $apiUser->getDomain() ) ) { |
|
| 430 | $params['lgdomain'] = $apiUser->getDomain(); |
||
| 431 | } |
||
| 432 | 2 | return $params; |
|
| 433 | } |
||
| 434 | |||
| 435 | /** |
||
| 436 | * @param array $result |
||
| 437 | * |
||
| 438 | * @throws UsageException |
||
| 439 | */ |
||
| 440 | 1 | private function throwLoginUsageException( $result ) { |
|
| 451 | |||
| 452 | /** |
||
| 453 | * @since 0.1 |
||
| 454 | * |
||
| 455 | * @return bool success |
||
| 456 | */ |
||
| 457 | 2 | public function logout() { |
|
| 467 | |||
| 468 | /** |
||
| 469 | * @since 0.1 |
||
| 470 | * |
||
| 471 | * @param string $type The token type to get. |
||
| 472 | * |
||
| 473 | * @return string |
||
| 474 | */ |
||
| 475 | 2 | public function getToken( $type = 'csrf' ) { |
|
| 478 | |||
| 479 | /** |
||
| 480 | * Clear all tokens stored by the API. |
||
| 481 | * |
||
| 482 | * @since 0.1 |
||
| 483 | */ |
||
| 484 | 1 | public function clearTokens() { |
|
| 487 | |||
| 488 | /** |
||
| 489 | * @return string |
||
| 490 | */ |
||
| 491 | 4 | public function getVersion() { |
|
| 492 | 4 | if ( !isset( $this->version ) ) { |
|
| 493 | 4 | $result = $this->getRequest( new SimpleRequest( 'query', [ |
|
| 506 | |||
| 507 | } |
||
| 508 |